HDFS-15151 Use TransmitFile for file to socket data transfer #1825
+345
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
April 27, 2017 14:16
added 13 commits
December 7, 2018 11:53
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
goiri
reviewed
Jan 31, 2020
| "The function transmitFile is not supported on Unix"); | ||
| #endif | ||
|
|
||
| #ifdef WINDOWS |
There was a problem hiding this comment.
i was following the way this was done just above for Windows_extendWorkingSetSize
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/nativeio/NativeIO.java
Show resolved
Hide resolved
| @@ -819,6 +849,12 @@ public static boolean access(String path, AccessRight desiredAccess) | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| public static void setConf(Configuration conf) { | |||
There was a problem hiding this comment.
Should we name this a little bit more specific and not only setConf? initTransmitFileEnabledConf()?
There was a problem hiding this comment.
it's not meant to be only for enabling transmitfile, but generally for reloading/resetting the configuration
| * Set the configuration to be used by this object. | ||
| * @param conf configuration to be used | ||
| */ | ||
| public static void setConf(Configuration conf) { |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
goiri
reviewed
Feb 1, 2020
| int nTransfered = (int) fileCh.transferTo(position, count, getChannel()); | ||
| int nTransfered = (int) NativeIO.transferTo(fileCh, | ||
| fileInputStream.getFD(), getChannel(), | ||
| ((SelChImpl) getChannel()).getFD(), position, count); |
There was a problem hiding this comment.
I cannot find an easy way out but can you see if we can remove:
SelChImpl is internal proprietary API and may be removed in a future release
| throw_ioe(env, WSAGetLastError()); | ||
| } | ||
| return numberOfBytesToWrite; | ||
| #endif |
There was a problem hiding this comment.
Anyway to rewrite this so we don't get:
NativeIO.c:1413:1: warning: control reaches end of non-void function [-Wreturn-type]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTICE
Please create an issue in ASF JIRA before opening a pull request,
and you need to set the title of the pull request which starts with
the corresponding JIRA issue number. (e.g. HADOOP-XXXXX. Fix a typo in YYY.)
For more details, please see https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute