Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HDFS-15322. Make NflyFS to work when ViewFsOverloadScheme's scheme and target uris schemes are same. #2025

Merged
merged 3 commits into from May 22, 2020

Conversation

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 39s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 3 new or modified test files.
_ trunk Compile Tests _
+0 🆗 mvndep 1m 17s Maven dependency ordering for branch
-1 ❌ mvninstall 23m 11s root in trunk failed.
+1 💚 compile 22m 4s trunk passed
+1 💚 checkstyle 3m 0s trunk passed
+1 💚 mvnsite 3m 11s trunk passed
-1 ❌ shadedclient 23m 9s branch has errors when building and testing our client artifacts.
+1 💚 javadoc 1m 49s trunk passed
+0 🆗 spotbugs 3m 16s Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚 findbugs 5m 36s trunk passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 26s Maven dependency ordering for patch
+1 💚 mvninstall 2m 11s the patch passed
+1 💚 compile 18m 15s the patch passed
+1 💚 javac 18m 15s the patch passed
-0 ⚠️ checkstyle 2m 53s root: The patch generated 3 new + 126 unchanged - 0 fixed = 129 total (was 126)
+1 💚 mvnsite 2m 50s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
-1 ❌ shadedclient 16m 14s patch has errors when building and testing our client artifacts.
+1 💚 javadoc 1m 46s the patch passed
+1 💚 findbugs 5m 36s the patch passed
_ Other Tests _
-1 ❌ unit 9m 31s hadoop-common in the patch passed.
-1 ❌ unit 113m 1s hadoop-hdfs in the patch passed.
+1 💚 asflicense 0m 54s The patch does not generate ASF License warnings.
256m 8s
Reason Tests
Failed junit tests hadoop.fs.viewfs.TestViewFsTrash
hadoop.hdfs.qjournal.server.TestJournalNodeSync
hadoop.hdfs.server.namenode.TestNameNodeRetryCacheMetrics
hadoop.hdfs.server.namenode.ha.TestBootstrapAliasmap
Subsystem Report/Notes
Docker ClientAPI=1.40 ServerAPI=1.40 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-2025/1/artifact/out/Dockerfile
GITHUB PR #2025
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux 63798a6f64d4 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 6e416a8
Default Java Private Build-1.8.0_252-8u252-b09-1~18.04-b09
mvninstall https://builds.apache.org/job/hadoop-multibranch/job/PR-2025/1/artifact/out/branch-mvninstall-root.txt
checkstyle https://builds.apache.org/job/hadoop-multibranch/job/PR-2025/1/artifact/out/diff-checkstyle-root.txt
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-2025/1/artifact/out/patch-unit-hadoop-common-project_hadoop-common.txt
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-2025/1/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-2025/1/testReport/
Max. process+thread count 3064 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-2025/1/console
versions git=2.17.1 maven=3.6.0 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 14s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 3 new or modified test files.
_ trunk Compile Tests _
+0 🆗 mvndep 0m 21s Maven dependency ordering for branch
-1 ❌ mvninstall 21m 57s root in trunk failed.
+1 💚 compile 18m 1s trunk passed
+1 💚 checkstyle 2m 51s trunk passed
+1 💚 mvnsite 2m 44s trunk passed
-1 ❌ shadedclient 22m 22s branch has errors when building and testing our client artifacts.
+1 💚 javadoc 1m 43s trunk passed
+0 🆗 spotbugs 3m 8s Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚 findbugs 5m 10s trunk passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 21s Maven dependency ordering for patch
+1 💚 mvninstall 1m 59s the patch passed
+1 💚 compile 17m 21s the patch passed
+1 💚 javac 17m 21s the patch passed
-0 ⚠️ checkstyle 2m 54s root: The patch generated 1 new + 126 unchanged - 0 fixed = 127 total (was 126)
+1 💚 mvnsite 2m 44s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
-1 ❌ shadedclient 16m 16s patch has errors when building and testing our client artifacts.
+1 💚 javadoc 1m 43s the patch passed
+1 💚 findbugs 5m 32s the patch passed
_ Other Tests _
+1 💚 unit 9m 27s hadoop-common in the patch passed.
-1 ❌ unit 116m 53s hadoop-hdfs in the patch passed.
+1 💚 asflicense 0m 52s The patch does not generate ASF License warnings.
250m 25s
Reason Tests
Failed junit tests hadoop.hdfs.qjournal.server.TestJournalNodeSync
hadoop.hdfs.server.namenode.TestNameNodeRetryCacheMetrics
Subsystem Report/Notes
Docker ClientAPI=1.40 ServerAPI=1.40 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-2025/2/artifact/out/Dockerfile
GITHUB PR #2025
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux 7936941687ab 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / a3809d2
Default Java Private Build-1.8.0_252-8u252-b09-1~18.04-b09
mvninstall https://builds.apache.org/job/hadoop-multibranch/job/PR-2025/2/artifact/out/branch-mvninstall-root.txt
checkstyle https://builds.apache.org/job/hadoop-multibranch/job/PR-2025/2/artifact/out/diff-checkstyle-root.txt
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-2025/2/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-2025/2/testReport/
Max. process+thread count 2884 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-2025/2/console
versions git=2.17.1 maven=3.6.0 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 36s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 3 new or modified test files.
_ trunk Compile Tests _
+0 🆗 mvndep 1m 2s Maven dependency ordering for branch
+1 💚 mvninstall 19m 1s trunk passed
+1 💚 compile 18m 25s trunk passed
+1 💚 checkstyle 2m 33s trunk passed
+1 💚 mvnsite 2m 57s trunk passed
+1 💚 shadedclient 20m 3s branch has no errors when building and testing our client artifacts.
+1 💚 javadoc 1m 54s trunk passed
+0 🆗 spotbugs 3m 14s Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚 findbugs 5m 26s trunk passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 26s Maven dependency ordering for patch
+1 💚 mvninstall 2m 4s the patch passed
+1 💚 compile 16m 59s the patch passed
+1 💚 javac 16m 59s the patch passed
-0 ⚠️ checkstyle 2m 37s root: The patch generated 1 new + 126 unchanged - 0 fixed = 127 total (was 126)
+1 💚 mvnsite 2m 52s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 shadedclient 14m 6s patch has no errors when building and testing our client artifacts.
+1 💚 javadoc 1m 57s the patch passed
+1 💚 findbugs 5m 36s the patch passed
_ Other Tests _
+1 💚 unit 9m 29s hadoop-common in the patch passed.
-1 ❌ unit 113m 43s hadoop-hdfs in the patch passed.
+1 💚 asflicense 1m 1s The patch does not generate ASF License warnings.
241m 9s
Reason Tests
Failed junit tests hadoop.hdfs.server.blockmanagement.TestUnderReplicatedBlocks
hadoop.hdfs.server.namenode.TestNameNodeRetryCacheMetrics
hadoop.hdfs.server.namenode.TestNamenodeRetryCache
hadoop.hdfs.server.balancer.TestBalancerRPCDelay
hadoop.hdfs.TestSafeModeWithStripedFileWithRandomECPolicy
hadoop.hdfs.server.namenode.TestAddStripedBlockInFBR
hadoop.hdfs.server.balancer.TestBalancerWithHANameNodes
hadoop.hdfs.TestDecommissionWithStriped
hadoop.hdfs.server.namenode.TestDecommissioningStatus
hadoop.hdfs.TestReconstructStripedFile
hadoop.hdfs.server.balancer.TestBalancerWithMultipleNameNodes
hadoop.hdfs.TestDFSPermission
hadoop.hdfs.server.balancer.TestBalancerWithNodeGroup
hadoop.hdfs.client.impl.TestBlockReaderLocal
Subsystem Report/Notes
Docker ClientAPI=1.40 ServerAPI=1.40 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-2025/3/artifact/out/Dockerfile
GITHUB PR #2025
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux cd51160939de 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / cef0756
Default Java Private Build-1.8.0_252-8u252-b09-1~18.04-b09
checkstyle https://builds.apache.org/job/hadoop-multibranch/job/PR-2025/3/artifact/out/diff-checkstyle-root.txt
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-2025/3/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-2025/3/testReport/
Max. process+thread count 3909 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-2025/3/console
versions git=2.17.1 maven=3.6.0 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 41s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 3 new or modified test files.
_ trunk Compile Tests _
+0 🆗 mvndep 0m 25s Maven dependency ordering for branch
+1 💚 mvninstall 20m 21s trunk passed
+1 💚 compile 17m 40s trunk passed
+1 💚 checkstyle 2m 38s trunk passed
-1 ❌ mvnsite 0m 34s hadoop-common in trunk failed.
+1 💚 shadedclient 19m 35s branch has no errors when building and testing our client artifacts.
+1 💚 javadoc 1m 47s trunk passed
+0 🆗 spotbugs 3m 8s Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚 findbugs 5m 25s trunk passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 27s Maven dependency ordering for patch
+1 💚 mvninstall 2m 7s the patch passed
+1 💚 compile 17m 1s the patch passed
+1 💚 javac 17m 1s the patch passed
+1 💚 checkstyle 2m 49s the patch passed
-1 ❌ mvnsite 0m 38s hadoop-common in the patch failed.
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 shadedclient 16m 11s patch has no errors when building and testing our client artifacts.
+1 💚 javadoc 2m 3s the patch passed
+1 💚 findbugs 6m 33s the patch passed
_ Other Tests _
+1 💚 unit 10m 19s hadoop-common in the patch passed.
-1 ❌ unit 106m 24s hadoop-hdfs in the patch passed.
+1 💚 asflicense 1m 5s The patch does not generate ASF License warnings.
236m 52s
Reason Tests
Failed junit tests hadoop.hdfs.server.blockmanagement.TestUnderReplicatedBlocks
hadoop.hdfs.server.namenode.TestNameNodeRetryCacheMetrics
hadoop.hdfs.server.namenode.TestAddOverReplicatedStripedBlocks
hadoop.hdfs.server.balancer.TestBalancerService
hadoop.hdfs.tools.TestWebHDFSStoragePolicyCommands
hadoop.hdfs.server.balancer.TestBalancerWithEncryptedTransfer
hadoop.hdfs.server.balancer.TestBalancerWithHANameNodes
hadoop.hdfs.TestMultipleNNPortQOP
hadoop.hdfs.server.namenode.TestEditLogRace
hadoop.hdfs.TestReadStripedFileWithDNFailure
hadoop.hdfs.tools.TestECAdmin
hadoop.hdfs.server.namenode.TestDefaultBlockPlacementPolicy
hadoop.hdfs.server.balancer.TestBalancerWithNodeGroup
hadoop.hdfs.TestAclsEndToEnd
Subsystem Report/Notes
Docker ClientAPI=1.40 ServerAPI=1.40 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-2025/4/artifact/out/Dockerfile
GITHUB PR #2025
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux 37c0736596f8 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / cef0756
Default Java Private Build-1.8.0_252-8u252-b09-1~18.04-b09
mvnsite https://builds.apache.org/job/hadoop-multibranch/job/PR-2025/4/artifact/out/branch-mvnsite-hadoop-common-project_hadoop-common.txt
mvnsite https://builds.apache.org/job/hadoop-multibranch/job/PR-2025/4/artifact/out/patch-mvnsite-hadoop-common-project_hadoop-common.txt
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-2025/4/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-2025/4/testReport/
Max. process+thread count 4207 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-2025/4/console
versions git=2.17.1 maven=3.6.0 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

Copy link
Contributor

@jojochuang jojochuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Could you verify the test failures are unrelated?

@umamaheswararao
Copy link
Contributor Author

Thanks @jojochuang for the review!
I verified test failures due to :
java.lang.OutOfMemoryError: unable to create new native thread
In very latest change was only just unused import removal. Prior to that these test were passed in previous report already. So, they are unrelated to this changes.

@umamaheswararao umamaheswararao merged commit 4734c77 into apache:trunk May 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants