HDFS-15483. Ordered snapshot deletion: Disallow rename between two snapshottable directories. #2172

bshashikant · 2020-07-27T12:29:50Z

please check https://issues.apache.org/jira/browse/HDFS-15483

hadoop-yetus · 2020-07-27T15:17:08Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 17s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s	The patch appears to include 1 new or modified test files.
		_ trunk Compile Tests _
+1 💚	mvninstall	19m 14s	trunk passed
+1 💚	compile	1m 14s	trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚	compile	1m 7s	trunk passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09
+1 💚	checkstyle	0m 46s	trunk passed
+1 💚	mvnsite	1m 14s	trunk passed
+1 💚	shadedclient	16m 2s	branch has no errors when building and testing our client artifacts.
-1 ❌	javadoc	0m 36s	hadoop-hdfs in trunk failed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.
+1 💚	javadoc	0m 47s	trunk passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09
+0 🆗	spotbugs	2m 57s	Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	2m 55s	trunk passed
		_ Patch Compile Tests _
+1 💚	mvninstall	1m 5s	the patch passed
+1 💚	compile	1m 8s	the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚	javac	1m 8s	the patch passed
+1 💚	compile	1m 1s	the patch passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09
+1 💚	javac	1m 1s	the patch passed
-0 ⚠️	checkstyle	0m 41s	hadoop-hdfs-project/hadoop-hdfs: The patch generated 2 new + 25 unchanged - 0 fixed = 27 total (was 25)
+1 💚	mvnsite	1m 5s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	shadedclient	13m 37s	patch has no errors when building and testing our client artifacts.
-1 ❌	javadoc	0m 31s	hadoop-hdfs in the patch failed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.
+1 💚	javadoc	0m 42s	the patch passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09
-1 ❌	findbugs	3m 2s	hadoop-hdfs-project/hadoop-hdfs generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0)
		_ Other Tests _
-1 ❌	unit	95m 26s	hadoop-hdfs in the patch passed.
+1 💚	asflicense	0m 43s	The patch does not generate ASF License warnings.
		166m 14s

Reason	Tests
FindBugs	module:hadoop-hdfs-project/hadoop-hdfs
	Dead store to dst in org.apache.hadoop.hdfs.server.namenode.FSDirSnapshotOp.checkUnderSameSnapshottableRoot(FSDirectory, INodesInPath, INodesInPath) At FSDirSnapshotOp.java:org.apache.hadoop.hdfs.server.namenode.FSDirSnapshotOp.checkUnderSameSnapshottableRoot(FSDirectory, INodesInPath, INodesInPath) At FSDirSnapshotOp.java:[line 357]
	Dead store to src in org.apache.hadoop.hdfs.server.namenode.FSDirSnapshotOp.checkUnderSameSnapshottableRoot(FSDirectory, INodesInPath, INodesInPath) At FSDirSnapshotOp.java:org.apache.hadoop.hdfs.server.namenode.FSDirSnapshotOp.checkUnderSameSnapshottableRoot(FSDirectory, INodesInPath, INodesInPath) At FSDirSnapshotOp.java:[line 356]
Failed junit tests	hadoop.hdfs.server.namenode.TestNameNodeRetryCacheMetrics
	hadoop.hdfs.server.balancer.TestBalancerRPCDelay
	hadoop.fs.contract.hdfs.TestHDFSContractMultipartUploader
	hadoop.tools.TestHdfsConfigFields

Subsystem	Report/Notes
Docker	ClientAPI=1.40 ServerAPI=1.40 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-2172/1/artifact/out/Dockerfile
GITHUB PR	#2172
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux 73f27ed726b0 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / `60a2546`
Default Java	Private Build-1.8.0_252-8u252-b09-1~18.04-b09
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_252-8u252-b09-1~18.04-b09
javadoc	https://builds.apache.org/job/hadoop-multibranch/job/PR-2172/1/artifact/out/branch-javadoc-hadoop-hdfs-project_hadoop-hdfs-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.txt
checkstyle	https://builds.apache.org/job/hadoop-multibranch/job/PR-2172/1/artifact/out/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
javadoc	https://builds.apache.org/job/hadoop-multibranch/job/PR-2172/1/artifact/out/patch-javadoc-hadoop-hdfs-project_hadoop-hdfs-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.txt
findbugs	https://builds.apache.org/job/hadoop-multibranch/job/PR-2172/1/artifact/out/new-findbugs-hadoop-hdfs-project_hadoop-hdfs.html
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-2172/1/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-2172/1/testReport/
Max. process+thread count	5034 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-2172/1/console
versions	git=2.17.1 maven=3.6.0 findbugs=4.0.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

mukul1987

Thanks for the patch @bshashikant . The patch looks good to me. Some minor comments.

...-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirRenameOp.java

...roject/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirSnapshotOp.java

.../test/java/org/apache/hadoop/hdfs/server/namenode/TestRenameWithOrderedSnapshotDeletion.java

hadoop-yetus · 2020-07-29T10:44:54Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 27s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s	The patch appears to include 1 new or modified test files.
		_ trunk Compile Tests _
+1 💚	mvninstall	22m 12s	trunk passed
+1 💚	compile	1m 18s	trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚	compile	1m 8s	trunk passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09
+1 💚	checkstyle	0m 47s	trunk passed
+1 💚	mvnsite	1m 16s	trunk passed
+1 💚	shadedclient	17m 34s	branch has no errors when building and testing our client artifacts.
-1 ❌	javadoc	0m 33s	hadoop-hdfs in trunk failed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.
+1 💚	javadoc	0m 41s	trunk passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09
+0 🆗	spotbugs	3m 16s	Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	3m 13s	trunk passed
		_ Patch Compile Tests _
+1 💚	mvninstall	1m 10s	the patch passed
+1 💚	compile	1m 12s	the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚	javac	1m 12s	the patch passed
+1 💚	compile	1m 3s	the patch passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09
+1 💚	javac	1m 3s	the patch passed
+1 💚	checkstyle	0m 42s	the patch passed
+1 💚	mvnsite	1m 10s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	shadedclient	15m 36s	patch has no errors when building and testing our client artifacts.
-1 ❌	javadoc	0m 30s	hadoop-hdfs in the patch failed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.
+1 💚	javadoc	0m 39s	the patch passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09
+1 💚	findbugs	3m 10s	the patch passed
		_ Other Tests _
-1 ❌	unit	117m 32s	hadoop-hdfs in the patch passed.
+1 💚	asflicense	1m 45s	The patch does not generate ASF License warnings.
		195m 18s

Reason	Tests
Failed junit tests	hadoop.hdfs.server.blockmanagement.TestBlockTokenWithDFSStriped
	hadoop.hdfs.server.namenode.sps.TestStoragePolicySatisfierWithStripedFile
	hadoop.hdfs.TestReadStripedFileWithDecodingDeletedData
	hadoop.hdfs.TestDFSOutputStream
	hadoop.tools.TestHdfsConfigFields
	hadoop.hdfs.TestSafeMode
	hadoop.hdfs.server.namenode.TestAddOverReplicatedStripedBlocks
	hadoop.hdfs.server.namenode.TestNameNodeRespectsBindHostKeys
	hadoop.hdfs.TestReconstructStripedFileWithRandomECPolicy
	hadoop.hdfs.server.blockmanagement.TestUnderReplicatedBlocks
	hadoop.hdfs.TestMaintenanceState
	hadoop.hdfs.TestErasureCodingPolicies
	hadoop.hdfs.server.namenode.ha.TestHAAppend
	hadoop.fs.contract.hdfs.TestHDFSContractMultipartUploader
	hadoop.hdfs.server.sps.TestExternalStoragePolicySatisfier
	hadoop.hdfs.TestGetFileChecksum

Subsystem	Report/Notes
Docker	ClientAPI=1.40 ServerAPI=1.40 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-2172/2/artifact/out/Dockerfile
GITHUB PR	#2172
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux e86c3674eb0d 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / `3eaf627`
Default Java	Private Build-1.8.0_252-8u252-b09-1~18.04-b09
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_252-8u252-b09-1~18.04-b09
javadoc	https://builds.apache.org/job/hadoop-multibranch/job/PR-2172/2/artifact/out/branch-javadoc-hadoop-hdfs-project_hadoop-hdfs-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.txt
javadoc	https://builds.apache.org/job/hadoop-multibranch/job/PR-2172/2/artifact/out/patch-javadoc-hadoop-hdfs-project_hadoop-hdfs-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-2172/2/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-2172/2/testReport/
Max. process+thread count	3101 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-2172/2/console
versions	git=2.17.1 maven=3.6.0 findbugs=4.0.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

mukul1987

Thanks for updating the patch @bshashikant. +1 the patch looks good to me.

...-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirRenameOp.java

hadoop-yetus · 2020-07-31T05:41:21Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	28m 46s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s	The patch appears to include 1 new or modified test files.
		_ trunk Compile Tests _
+1 💚	mvninstall	20m 12s	trunk passed
+1 💚	compile	1m 15s	trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚	compile	1m 14s	trunk passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09
+1 💚	checkstyle	0m 45s	trunk passed
+1 💚	mvnsite	1m 15s	trunk passed
+1 💚	shadedclient	16m 4s	branch has no errors when building and testing our client artifacts.
-1 ❌	javadoc	0m 33s	hadoop-hdfs in trunk failed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.
+1 💚	javadoc	0m 44s	trunk passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09
+0 🆗	spotbugs	3m 8s	Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	3m 6s	trunk passed
		_ Patch Compile Tests _
-1 ❌	mvninstall	0m 40s	hadoop-hdfs in the patch failed.
-1 ❌	compile	0m 42s	hadoop-hdfs in the patch failed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.
-1 ❌	javac	0m 42s	hadoop-hdfs in the patch failed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.
-1 ❌	compile	0m 41s	hadoop-hdfs in the patch failed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09.
-1 ❌	javac	0m 41s	hadoop-hdfs in the patch failed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09.
+1 💚	checkstyle	0m 46s	the patch passed
-1 ❌	mvnsite	0m 43s	hadoop-hdfs in the patch failed.
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
-1 ❌	shadedclient	4m 11s	patch has errors when building and testing our client artifacts.
-1 ❌	javadoc	0m 29s	hadoop-hdfs in the patch failed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.
+1 💚	javadoc	0m 39s	the patch passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09
-1 ❌	findbugs	0m 41s	hadoop-hdfs in the patch failed.
		_ Other Tests _
-1 ❌	unit	0m 41s	hadoop-hdfs in the patch failed.
+1 💚	asflicense	0m 28s	The patch does not generate ASF License warnings.
		86m 22s

Subsystem	Report/Notes
Docker	ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2172/3/artifact/out/Dockerfile
GITHUB PR	#2172
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux cac2576e299d 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / `05b3337`
Default Java	Private Build-1.8.0_252-8u252-b09-1~18.04-b09
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_252-8u252-b09-1~18.04-b09
javadoc	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2172/3/artifact/out/branch-javadoc-hadoop-hdfs-project_hadoop-hdfs-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.txt
mvninstall	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2172/3/artifact/out/patch-mvninstall-hadoop-hdfs-project_hadoop-hdfs.txt
compile	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2172/3/artifact/out/patch-compile-hadoop-hdfs-project_hadoop-hdfs-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.txt
javac	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2172/3/artifact/out/patch-compile-hadoop-hdfs-project_hadoop-hdfs-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.txt
compile	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2172/3/artifact/out/patch-compile-hadoop-hdfs-project_hadoop-hdfs-jdkPrivateBuild-1.8.0_252-8u252-b09-1~18.04-b09.txt
javac	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2172/3/artifact/out/patch-compile-hadoop-hdfs-project_hadoop-hdfs-jdkPrivateBuild-1.8.0_252-8u252-b09-1~18.04-b09.txt
mvnsite	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2172/3/artifact/out/patch-mvnsite-hadoop-hdfs-project_hadoop-hdfs.txt
javadoc	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2172/3/artifact/out/patch-javadoc-hadoop-hdfs-project_hadoop-hdfs-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.txt
findbugs	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2172/3/artifact/out/patch-findbugs-hadoop-hdfs-project_hadoop-hdfs.txt
unit	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2172/3/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2172/3/testReport/
Max. process+thread count	414 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2172/3/console
versions	git=2.17.1 maven=3.6.0 findbugs=4.0.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

hemanthboyina · 2020-08-06T17:40:12Z

the code has to be updated as the method isSnapshotDeletionOrdered() got removed

…apshottable directories.

hadoop-yetus · 2020-08-12T09:53:27Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 5s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s	The patch appears to include 1 new or modified test files.
		_ trunk Compile Tests _
+1 💚	mvninstall	31m 3s	trunk passed
+1 💚	compile	1m 14s	trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚	compile	1m 7s	trunk passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09
+1 💚	checkstyle	0m 49s	trunk passed
+1 💚	mvnsite	1m 15s	trunk passed
+1 💚	shadedclient	17m 48s	branch has no errors when building and testing our client artifacts.
+1 💚	javadoc	0m 51s	trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚	javadoc	1m 17s	trunk passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09
+0 🆗	spotbugs	3m 11s	Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	3m 9s	trunk passed
-0 ⚠️	patch	3m 26s	Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
		_ Patch Compile Tests _
+1 💚	mvninstall	1m 8s	the patch passed
+1 💚	compile	1m 12s	the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚	javac	1m 12s	the patch passed
+1 💚	compile	1m 14s	the patch passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09
+1 💚	javac	1m 14s	the patch passed
+1 💚	checkstyle	0m 46s	the patch passed
+1 💚	mvnsite	1m 19s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	shadedclient	15m 19s	patch has no errors when building and testing our client artifacts.
+1 💚	javadoc	0m 47s	the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚	javadoc	1m 17s	the patch passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09
+1 💚	findbugs	3m 21s	the patch passed
		_ Other Tests _
-1 ❌	unit	110m 24s	hadoop-hdfs in the patch passed.
+1 💚	asflicense	0m 37s	The patch does not generate ASF License warnings.
		198m 27s

Reason	Tests
Failed junit tests	hadoop.hdfs.server.sps.TestExternalStoragePolicySatisfier
	hadoop.hdfs.server.blockmanagement.TestBlockTokenWithDFSStriped
	hadoop.hdfs.server.namenode.TestDecommissioningStatusWithBackoffMonitor
	hadoop.fs.contract.hdfs.TestHDFSContractMultipartUploader
	hadoop.hdfs.server.namenode.TestNameNodeRetryCacheMetrics
	hadoop.hdfs.server.namenode.TestINodeFile

Subsystem	Report/Notes
Docker	ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2172/6/artifact/out/Dockerfile
GITHUB PR	#2172
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux f5fed21c1b4c 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / `11cec9a`
Default Java	Private Build-1.8.0_252-8u252-b09-1~18.04-b09
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_252-8u252-b09-1~18.04-b09
unit	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2172/6/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2172/6/testReport/
Max. process+thread count	3245 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2172/6/console
versions	git=2.17.1 maven=3.6.0 findbugs=4.0.6
Powered by	Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

szetszwo

Thanks @bshashikant . Some comments inlined.

...doop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/snapshot/SnapshotManager.java

...roject/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirSnapshotOp.java

hadoop-yetus · 2020-08-14T10:33:18Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 39s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s	The patch appears to include 1 new or modified test files.
		_ trunk Compile Tests _
+1 💚	mvninstall	30m 45s	trunk passed
+1 💚	compile	1m 26s	trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚	compile	1m 13s	trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
+1 💚	checkstyle	0m 50s	trunk passed
+1 💚	mvnsite	1m 22s	trunk passed
+1 💚	shadedclient	17m 7s	branch has no errors when building and testing our client artifacts.
+1 💚	javadoc	0m 50s	trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚	javadoc	1m 24s	trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
+0 🆗	spotbugs	3m 4s	Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	3m 1s	trunk passed
-0 ⚠️	patch	3m 19s	Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
		_ Patch Compile Tests _
+1 💚	mvninstall	1m 9s	the patch passed
+1 💚	compile	1m 11s	the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚	javac	1m 11s	the patch passed
+1 💚	compile	1m 3s	the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
+1 💚	javac	1m 3s	the patch passed
+1 💚	checkstyle	0m 41s	the patch passed
+1 💚	mvnsite	1m 13s	the patch passed
-1 ❌	whitespace	0m 0s	The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
+1 💚	shadedclient	14m 36s	patch has no errors when building and testing our client artifacts.
+1 💚	javadoc	0m 54s	the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚	javadoc	1m 29s	the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
+1 💚	findbugs	4m 13s	the patch passed
		_ Other Tests _
-1 ❌	unit	133m 35s	hadoop-hdfs in the patch passed.
+1 💚	asflicense	0m 44s	The patch does not generate ASF License warnings.
		221m 19s

Reason	Tests
Failed junit tests	hadoop.hdfs.server.diskbalancer.command.TestDiskBalancerCommand
	hadoop.hdfs.server.namenode.TestReconstructStripedBlocks
	hadoop.hdfs.server.blockmanagement.TestBlockTokenWithDFSStriped
	hadoop.hdfs.server.balancer.TestBalancerWithEncryptedTransfer
	hadoop.hdfs.TestDFSStripedOutputStreamWithRandomECPolicy
	hadoop.hdfs.server.datanode.TestBPOfferService
	hadoop.hdfs.TestDecommissionWithStripedBackoffMonitor
	hadoop.hdfs.web.TestWebHdfsWithMultipleNameNodes
	hadoop.hdfs.TestReconstructStripedFile
	hadoop.hdfs.TestReconstructStripedFileWithRandomECPolicy
	hadoop.hdfs.TestErasureCodingExerciseAPIs
	hadoop.hdfs.TestFileChecksum
	hadoop.hdfs.server.namenode.TestHDFSConcat
	hadoop.hdfs.TestErasureCodingPolicies
	hadoop.hdfs.TestErasureCodingPoliciesWithRandomECPolicy
	hadoop.hdfs.security.token.block.TestBlockToken
	hadoop.hdfs.TestEncryptionZones
	hadoop.hdfs.TestErasureCodingPolicyWithSnapshotWithRandomECPolicy
	hadoop.hdfs.TestDFSStripedInputStream
	hadoop.hdfs.server.balancer.TestBalancerRPCDelay
	hadoop.hdfs.server.namenode.TestCheckpoint
	hadoop.hdfs.TestReadStripedFileWithDecodingDeletedData
	hadoop.hdfs.server.datanode.TestDirectoryScanner
	hadoop.hdfs.server.namenode.TestFSEditLogLoader
	hadoop.hdfs.TestDecommissionWithStriped
	hadoop.hdfs.TestDFSStripedOutputStreamWithFailure
	hadoop.hdfs.server.namenode.TestNameNodeRetryCacheMetrics
	hadoop.fs.contract.hdfs.TestHDFSContractMultipartUploader
	hadoop.hdfs.server.namenode.ha.TestHAAppend
	hadoop.hdfs.TestErasureCodingPolicyWithSnapshot
	hadoop.hdfs.server.balancer.TestBalancerWithMultipleNameNodes
	hadoop.hdfs.server.namenode.TestAddStripedBlocks
	hadoop.hdfs.server.balancer.TestBalancerWithNodeGroup

Subsystem	Report/Notes
Docker	ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2172/7/artifact/out/Dockerfile
GITHUB PR	#2172
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux 84a9f384f098 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / `86bbd38`
Default Java	Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
whitespace	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2172/7/artifact/out/whitespace-eol.txt
unit	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2172/7/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2172/7/testReport/
Max. process+thread count	4666 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2172/7/console
versions	git=2.17.1 maven=3.6.0 findbugs=4.0.6
Powered by	Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

szetszwo

+1 the latest change looks good.

...-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirRenameOp.java

hadoop-yetus · 2020-08-14T18:53:22Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 31s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s	The patch appears to include 1 new or modified test files.
		_ trunk Compile Tests _
+1 💚	mvninstall	31m 23s	trunk passed
+1 💚	compile	1m 29s	trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚	compile	1m 17s	trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
+1 💚	checkstyle	0m 54s	trunk passed
+1 💚	mvnsite	1m 29s	trunk passed
+1 💚	shadedclient	19m 49s	branch has no errors when building and testing our client artifacts.
+1 💚	javadoc	0m 50s	trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚	javadoc	1m 22s	trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
+0 🆗	spotbugs	3m 9s	Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	3m 7s	trunk passed
-0 ⚠️	patch	3m 24s	Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
		_ Patch Compile Tests _
+1 💚	mvninstall	1m 10s	the patch passed
+1 💚	compile	1m 12s	the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚	javac	1m 12s	the patch passed
+1 💚	compile	1m 3s	the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
+1 💚	javac	1m 3s	the patch passed
+1 💚	checkstyle	0m 42s	the patch passed
+1 💚	mvnsite	1m 8s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	shadedclient	15m 35s	patch has no errors when building and testing our client artifacts.
+1 💚	javadoc	0m 50s	the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚	javadoc	1m 20s	the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
+1 💚	findbugs	3m 17s	the patch passed
		_ Other Tests _
-1 ❌	unit	110m 40s	hadoop-hdfs in the patch passed.
+1 💚	asflicense	0m 37s	The patch does not generate ASF License warnings.
		202m 13s

Reason	Tests
Failed junit tests	hadoop.hdfs.server.sps.TestExternalStoragePolicySatisfier
	hadoop.fs.contract.hdfs.TestHDFSContractMultipartUploader
	hadoop.hdfs.server.balancer.TestBalancerWithHANameNodes
	hadoop.hdfs.server.datanode.TestBPOfferService

Subsystem	Report/Notes
Docker	ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2172/8/artifact/out/Dockerfile
GITHUB PR	#2172
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname	Linux 8649f4764f23 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / `15a76e8`
Default Java	Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
unit	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2172/8/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2172/8/testReport/
Max. process+thread count	3187 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2172/8/console
versions	git=2.17.1 maven=3.6.0 findbugs=4.0.6
Powered by	Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

hemanthboyina · 2020-08-17T07:25:58Z

+1

hemanthboyina · 2020-08-17T07:28:58Z

thanks @bshashikant for the contribution , thanks @szetszwo @mukul1987 for the reveiw

…apshottable directories. (apache#2172) (cherry picked from commit 092bfe7) Change-Id: I4d2b8105dc2f9fbebb9c79100edfb1b1c36f3347 (cherry picked from commit 4efcff0)

bshashikant requested a review from mukul1987 July 27, 2020 12:29

mukul1987 requested changes Jul 29, 2020

View reviewed changes

mukul1987 approved these changes Jul 29, 2020

View reviewed changes

...-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirRenameOp.java Outdated Show resolved Hide resolved

bshashikant requested a review from szetszwo July 29, 2020 18:10

bshashikant added 3 commits August 12, 2020 11:14

HDFS-15483. Ordered snapshot deletion: Disallow rename between two sn…

4e9d96a

…apshottable directories.

Addressed review comments.

6d5c151

Rebased to latest trunk and added snapshotTrashRoot config check.

70f6603

bshashikant force-pushed the HDFS-15483 branch from 6058607 to 70f6603 Compare August 12, 2020 06:23

szetszwo requested changes Aug 13, 2020

View reviewed changes

bshashikant added 2 commits August 14, 2020 11:17

Addressed review comments.

279e772

Removede empty line added in SnapshotManager.Java.

edee22e

szetszwo approved these changes Aug 14, 2020

View reviewed changes

hemanthboyina reviewed Aug 14, 2020

View reviewed changes

...-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirRenameOp.java Show resolved Hide resolved

Addressed whitespace issues.

8444f5d

hemanthboyina merged commit 092bfe7 into apache:trunk Aug 17, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HDFS-15483. Ordered snapshot deletion: Disallow rename between two snapshottable directories. #2172

HDFS-15483. Ordered snapshot deletion: Disallow rename between two snapshottable directories. #2172

bshashikant commented Jul 27, 2020

hadoop-yetus commented Jul 27, 2020

mukul1987 left a comment

hadoop-yetus commented Jul 29, 2020

mukul1987 left a comment

hadoop-yetus commented Jul 31, 2020

hemanthboyina commented Aug 6, 2020 •

edited

Loading

hadoop-yetus commented Aug 12, 2020

szetszwo left a comment

hadoop-yetus commented Aug 14, 2020

szetszwo left a comment

hadoop-yetus commented Aug 14, 2020

hemanthboyina commented Aug 17, 2020

hemanthboyina commented Aug 17, 2020

HDFS-15483. Ordered snapshot deletion: Disallow rename between two snapshottable directories. #2172

HDFS-15483. Ordered snapshot deletion: Disallow rename between two snapshottable directories. #2172

Conversation

bshashikant commented Jul 27, 2020

hadoop-yetus commented Jul 27, 2020

mukul1987 left a comment

Choose a reason for hiding this comment

hadoop-yetus commented Jul 29, 2020

mukul1987 left a comment

Choose a reason for hiding this comment

hadoop-yetus commented Jul 31, 2020

hemanthboyina commented Aug 6, 2020 • edited Loading

hadoop-yetus commented Aug 12, 2020

szetszwo left a comment

Choose a reason for hiding this comment

hadoop-yetus commented Aug 14, 2020

szetszwo left a comment

Choose a reason for hiding this comment

hadoop-yetus commented Aug 14, 2020

hemanthboyina commented Aug 17, 2020

hemanthboyina commented Aug 17, 2020

hemanthboyina commented Aug 6, 2020 •

edited

Loading