HDFS-15498. Show snapshots deletion status in snapList cmd. #2181

bshashikant · 2020-07-31T04:32:46Z

please see https://issues.apache.org/jira/browse/HDFS-15498

hadoop-yetus · 2020-07-31T08:33:45Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	29m 41s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+0 🆗	prototool	0m 1s	prototool was not available.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s	The patch appears to include 1 new or modified test files.
		_ trunk Compile Tests _
+0 🆗	mvndep	1m 4s	Maven dependency ordering for branch
+1 💚	mvninstall	21m 45s	trunk passed
+1 💚	compile	4m 13s	trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚	compile	3m 49s	trunk passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09
+1 💚	checkstyle	0m 59s	trunk passed
+1 💚	mvnsite	2m 5s	trunk passed
+1 💚	shadedclient	18m 45s	branch has no errors when building and testing our client artifacts.
-1 ❌	javadoc	0m 35s	hadoop-hdfs-client in trunk failed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.
-1 ❌	javadoc	0m 32s	hadoop-hdfs in trunk failed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.
+1 💚	javadoc	1m 10s	trunk passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09
+0 🆗	spotbugs	3m 8s	Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	5m 33s	trunk passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 22s	Maven dependency ordering for patch
+1 💚	mvninstall	1m 55s	the patch passed
+1 💚	compile	4m 8s	the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚	cc	4m 8s	the patch passed
+1 💚	javac	4m 8s	the patch passed
+1 💚	compile	3m 44s	the patch passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09
+1 💚	cc	3m 44s	the patch passed
+1 💚	javac	3m 44s	the patch passed
-0 ⚠️	checkstyle	0m 55s	hadoop-hdfs-project: The patch generated 1 new + 60 unchanged - 0 fixed = 61 total (was 60)
+1 💚	mvnsite	1m 59s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	shadedclient	15m 28s	patch has no errors when building and testing our client artifacts.
-1 ❌	javadoc	0m 33s	hadoop-hdfs-client in the patch failed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.
-1 ❌	javadoc	0m 29s	hadoop-hdfs in the patch failed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.
+1 💚	javadoc	1m 5s	the patch passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09
-1 ❌	findbugs	2m 34s	hadoop-hdfs-project/hadoop-hdfs-client generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
		_ Other Tests _
+1 💚	unit	1m 55s	hadoop-hdfs-client in the patch passed.
-1 ❌	unit	109m 7s	hadoop-hdfs in the patch passed.
+1 💚	asflicense	0m 36s	The patch does not generate ASF License warnings.
		239m 0s

Reason	Tests
FindBugs	module:hadoop-hdfs-project/hadoop-hdfs-client
	There is an apparent infinite recursive loop in org.apache.hadoop.hdfs.protocol.SnapshotStatus$Bean.isDELETED() At SnapshotStatus.java:recursive loop in org.apache.hadoop.hdfs.protocol.SnapshotStatus$Bean.isDELETED() At SnapshotStatus.java:[line 220]
Failed junit tests	hadoop.hdfs.server.namenode.TestNameNodeRetryCacheMetrics
	hadoop.fs.contract.hdfs.TestHDFSContractMultipartUploader
	hadoop.hdfs.server.blockmanagement.TestBlockTokenWithDFSStriped

Subsystem	Report/Notes
Docker	ClientAPI=1.40 ServerAPI=1.40 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-2181/1/artifact/out/Dockerfile
GITHUB PR	#2181
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle cc prototool
uname	Linux 2bcb330357a9 4.15.0-101-generic #102-Ubuntu SMP Mon May 11 10:07:26 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / `05b3337`
Default Java	Private Build-1.8.0_252-8u252-b09-1~18.04-b09
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_252-8u252-b09-1~18.04-b09
javadoc	https://builds.apache.org/job/hadoop-multibranch/job/PR-2181/1/artifact/out/branch-javadoc-hadoop-hdfs-project_hadoop-hdfs-client-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.txt
javadoc	https://builds.apache.org/job/hadoop-multibranch/job/PR-2181/1/artifact/out/branch-javadoc-hadoop-hdfs-project_hadoop-hdfs-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.txt
checkstyle	https://builds.apache.org/job/hadoop-multibranch/job/PR-2181/1/artifact/out/diff-checkstyle-hadoop-hdfs-project.txt
javadoc	https://builds.apache.org/job/hadoop-multibranch/job/PR-2181/1/artifact/out/patch-javadoc-hadoop-hdfs-project_hadoop-hdfs-client-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.txt
javadoc	https://builds.apache.org/job/hadoop-multibranch/job/PR-2181/1/artifact/out/patch-javadoc-hadoop-hdfs-project_hadoop-hdfs-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.txt
findbugs	https://builds.apache.org/job/hadoop-multibranch/job/PR-2181/1/artifact/out/new-findbugs-hadoop-hdfs-project_hadoop-hdfs-client.html
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-2181/1/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-2181/1/testReport/
Max. process+thread count	2785 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-2181/1/console
versions	git=2.17.1 maven=3.6.0 findbugs=4.0.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

mukul1987

Thanks for the patch @bshashikant. The patch looks good to me. Some minor comments.

...project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/SnapshotStatus.java

...oop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/snapshot/TestListSnapshot.java

hadoop-yetus · 2020-07-31T18:27:41Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 50s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+0 🆗	prototool	0m 1s	prototool was not available.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s	The patch appears to include 1 new or modified test files.
		_ trunk Compile Tests _
+0 🆗	mvndep	1m 2s	Maven dependency ordering for branch
+1 💚	mvninstall	22m 20s	trunk passed
+1 💚	compile	4m 20s	trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚	compile	3m 53s	trunk passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09
+1 💚	checkstyle	0m 58s	trunk passed
+1 💚	mvnsite	2m 4s	trunk passed
+1 💚	shadedclient	18m 35s	branch has no errors when building and testing our client artifacts.
-1 ❌	javadoc	0m 38s	hadoop-hdfs-client in trunk failed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.
-1 ❌	javadoc	0m 31s	hadoop-hdfs in trunk failed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.
+1 💚	javadoc	1m 11s	trunk passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09
+0 🆗	spotbugs	3m 6s	Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	5m 31s	trunk passed
		_ Patch Compile Tests _
+0 🆗	mvndep	0m 21s	Maven dependency ordering for patch
+1 💚	mvninstall	1m 55s	the patch passed
+1 💚	compile	4m 9s	the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚	cc	4m 9s	the patch passed
+1 💚	javac	4m 9s	the patch passed
+1 💚	compile	3m 45s	the patch passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09
+1 💚	cc	3m 45s	the patch passed
+1 💚	javac	3m 45s	the patch passed
+1 💚	checkstyle	0m 53s	the patch passed
+1 💚	mvnsite	1m 56s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	shadedclient	15m 43s	patch has no errors when building and testing our client artifacts.
-1 ❌	javadoc	0m 34s	hadoop-hdfs-client in the patch failed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.
-1 ❌	javadoc	0m 29s	hadoop-hdfs in the patch failed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.
+1 💚	javadoc	1m 7s	the patch passed with JDK Private Build-1.8.0_252-8u252-b09-1~18.04-b09
+1 💚	findbugs	5m 42s	the patch passed
		_ Other Tests _
+1 💚	unit	1m 58s	hadoop-hdfs-client in the patch passed.
-1 ❌	unit	109m 44s	hadoop-hdfs in the patch passed.
+1 💚	asflicense	0m 36s	The patch does not generate ASF License warnings.
		212m 44s

Reason	Tests
Failed junit tests	hadoop.hdfs.server.sps.TestExternalStoragePolicySatisfier
	hadoop.hdfs.TestGetFileChecksum
	hadoop.hdfs.server.namenode.TestNameNodeRetryCacheMetrics
	hadoop.fs.contract.hdfs.TestHDFSContractMultipartUploader

Subsystem	Report/Notes
Docker	ClientAPI=1.40 ServerAPI=1.40 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-2181/2/artifact/out/Dockerfile
GITHUB PR	#2181
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle cc prototool
uname	Linux d245145b5086 4.15.0-91-generic #92-Ubuntu SMP Fri Feb 28 11:09:48 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	personality/hadoop.sh
git revision	trunk / `e756fe3`
Default Java	Private Build-1.8.0_252-8u252-b09-1~18.04-b09
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_252-8u252-b09-1~18.04-b09
javadoc	https://builds.apache.org/job/hadoop-multibranch/job/PR-2181/2/artifact/out/branch-javadoc-hadoop-hdfs-project_hadoop-hdfs-client-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.txt
javadoc	https://builds.apache.org/job/hadoop-multibranch/job/PR-2181/2/artifact/out/branch-javadoc-hadoop-hdfs-project_hadoop-hdfs-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.txt
javadoc	https://builds.apache.org/job/hadoop-multibranch/job/PR-2181/2/artifact/out/patch-javadoc-hadoop-hdfs-project_hadoop-hdfs-client-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.txt
javadoc	https://builds.apache.org/job/hadoop-multibranch/job/PR-2181/2/artifact/out/patch-javadoc-hadoop-hdfs-project_hadoop-hdfs-jdkUbuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1.txt
unit	https://builds.apache.org/job/hadoop-multibranch/job/PR-2181/2/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
Test Results	https://builds.apache.org/job/hadoop-multibranch/job/PR-2181/2/testReport/
Max. process+thread count	3116 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project
Console output	https://builds.apache.org/job/hadoop-multibranch/job/PR-2181/2/console
versions	git=2.17.1 maven=3.6.0 findbugs=4.0.6
Powered by	Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

mukul1987

Thanks for updating the patch @bshashikant. +1 patch looks good to me.

hemanthboyina · 2020-08-01T16:32:54Z

changes looks good @bshashikant , can we extend snapshot deletion status in "ls" command ?
as -ls /user/.snapshot details will also give all snapshot related details for /user

mukul1987 · 2020-08-02T16:02:23Z

@hemanthboyina, we are not modifying the "ls" command because the changes will be backward incompatible.

mukul1987 · 2020-08-02T16:27:26Z

The patch looks good to me. I will commit them shortly.

). Change-Id: I30986780aacecb3f33d0a93dead400b95b83ba74 (cherry picked from commit 28d67f1)

HDFS-15498. Show snapshots deletion status in snapList cmd.

4f468ca

bshashikant requested review from szetszwo and mukul1987 July 31, 2020 04:32

mukul1987 requested changes Jul 31, 2020

View reviewed changes

...project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/SnapshotStatus.java Outdated Show resolved Hide resolved

...oop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/snapshot/TestListSnapshot.java Show resolved Hide resolved

Addressed review comments.

5004f41

mukul1987 approved these changes Jul 31, 2020

View reviewed changes

mukul1987 merged commit d8a2df2 into apache:trunk Aug 2, 2020

jojochuang pushed a commit to jojochuang/hadoop that referenced this pull request May 23, 2023

HDFS-15498. Show snapshots deletion status in snapList cmd. (apache#2181

6bb2648

). Change-Id: I30986780aacecb3f33d0a93dead400b95b83ba74 (cherry picked from commit 28d67f1)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HDFS-15498. Show snapshots deletion status in snapList cmd. #2181

HDFS-15498. Show snapshots deletion status in snapList cmd. #2181

bshashikant commented Jul 31, 2020

hadoop-yetus commented Jul 31, 2020

mukul1987 left a comment

hadoop-yetus commented Jul 31, 2020

mukul1987 left a comment

hemanthboyina commented Aug 1, 2020

mukul1987 commented Aug 2, 2020

mukul1987 commented Aug 2, 2020

HDFS-15498. Show snapshots deletion status in snapList cmd. #2181

HDFS-15498. Show snapshots deletion status in snapList cmd. #2181

Conversation

bshashikant commented Jul 31, 2020

hadoop-yetus commented Jul 31, 2020

mukul1987 left a comment

Choose a reason for hiding this comment

hadoop-yetus commented Jul 31, 2020

mukul1987 left a comment

Choose a reason for hiding this comment

hemanthboyina commented Aug 1, 2020

mukul1987 commented Aug 2, 2020

mukul1987 commented Aug 2, 2020