HDFS-15515: mkdirs on fallback should throw IOE out instead of suppressing and returning false #2205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ssing and returning false
|
💔 -1 overall
This message was automatically generated. |
ayushtkn
approved these changes
Aug 10, 2020
There was a problem hiding this comment.
Thanx @umamaheswararao for the work here.
Chnages LGTM, test failures seems unrelated.
+1
| @@ -759,7 +759,11 @@ public void testMkdirsShouldReturnFalseWhenFallbackFSNotAvailable() | |||
| cluster.shutdownNameNodes(); // Stopping fallback server | |||
| // /user1/test1 does not exist in mount internal dir tree, it would | |||
| // attempt to create in fallback. | |||
| assertFalse(vfs.mkdirs(nextLevelToInternalDir)); | |||
| try { | |||
| vfs.mkdirs(nextLevelToInternalDir); | |||
There was a problem hiding this comment.
Use LambdaTestUtils.intercept()
There was a problem hiding this comment.
Done, thanks
|
LGTM-just change the test to use intercept() |
|
+1 after changing to intercept() |
|
💔 -1 overall
This message was automatically generated. |
asfgit
pushed a commit
that referenced
this pull request
Aug 13, 2020
…ssing and returning false (#2205) * HDFS-15515: mkdirs on fallback should throw IOE out instead of suppressing and returning false * Used LambdaTestUtils#intercept in test
umamaheswararao
added a commit
that referenced
this pull request
Aug 25, 2020
…ssing and returning false (#2205) * HDFS-15515: mkdirs on fallback should throw IOE out instead of suppressing and returning false * Used LambdaTestUtils#intercept in test (cherry picked from commit 99b120a)
umamaheswararao
added a commit
that referenced
this pull request
Aug 25, 2020
…ssing and returning false (#2205) * HDFS-15515: mkdirs on fallback should throw IOE out instead of suppressing and returning false * Used LambdaTestUtils#intercept in test (cherry picked from commit 99b120a)
jojochuang
pushed a commit
to jojochuang/hadoop
that referenced
this pull request
May 23, 2023
…ssing and returning false (apache#2205) * HDFS-15515: mkdirs on fallback should throw IOE out instead of suppressing and returning false * Used LambdaTestUtils#intercept in test (cherry picked from commit 8955a6c) Change-Id: I9e8e340f6f5b7d42bdca632d6983543b3548aa4d (cherry picked from commit 0538650)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/HDFS-15515