HDFS-15557. Log the reason why a storage log file can't be deleted #2274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NickyYe
changed the title
|
💔 -1 overall
This message was automatically generated. |
NickyYe
changed the title
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
liuml07
reviewed
Sep 4, 2020
| try { | ||
| Files.delete(origFile.toPath()); | ||
| } catch (IOException e) { | ||
| throw new IOException("Could not delete original file " + origFile |
There was a problem hiding this comment.
Is it simpler
throw new IOException("Could not delete original file " + origFile, e);
Other than that, +1
|
💔 -1 overall
This message was automatically generated. |
|
Not sure why the build came out so badly... let's see if we can retrigger. |
goiri
approved these changes
Sep 21, 2020
|
@liuml07 any further comments? |
|
+1 Not sure why the QA is not coming back cleanly here...not related to the change. |
goiri
approved these changes
Sep 22, 2020
bilaharith
pushed a commit
to bilaharith/hadoop
that referenced
this pull request
Sep 27, 2020
jojochuang
pushed a commit
to jojochuang/hadoop
that referenced
this pull request
May 23, 2023
…pache#2274) (cherry picked from commit ae089f2) Change-Id: I59e5a3508fa630b327a5d0d573a2cce9a1ed3570
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/HDFS-15557
NOTICE
Please create an issue in ASF JIRA before opening a pull request,
and you need to set the title of the pull request which starts with
the corresponding JIRA issue number. (e.g. HADOOP-XXXXX. Fix a typo in YYY.)
For more details, please see https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute