HDFS-15516.Add info for create flags in NameNode audit logs. #2281
+71
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💔 -1 overall
This message was automatically generated. |
jianghuazhu
force-pushed
the
HDFS-15516
branch
from
7c9997e
to
486b544
Compare
|
💔 -1 overall
This message was automatically generated. |
jianghuazhu
force-pushed
the
HDFS-15516
branch
from
486b544
to
caa5b79
Compare
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
jianghuazhu
force-pushed
the
HDFS-15516
branch
from
caa5b79
to
e0997f7
Compare
|
💔 -1 overall
This message was automatically generated. |
sunchao
reviewed
Sep 15, 2020
| @@ -2639,10 +2639,11 @@ HdfsFileStatus startFile(String src, PermissionStatus permissions, | |||
| createParent, replication, blockSize, supportedVersions, ecPolicyName, | |||
| storagePolicy, logRetryCache); | |||
| } catch (AccessControlException e) { | |||
| logAuditEvent(false, "create", src); | |||
| logAuditEvent(false, "create(options=" + flag.toString() + ")", src); | |||
There was a problem hiding this comment.
can we leave a space after "create" so it is consistent with rename? e.g., "create (options=..."
There was a problem hiding this comment.
thanks for your suggestion.
I will modify it.
| final FileSystem fs = cluster.getFileSystem(); | ||
| final Path p = new Path("/debug.log"); | ||
| FSDataOutputStream stm = fs.create(p); | ||
| assertTrue(auditlog.getOutput().contains("create(options")); |
There was a problem hiding this comment.
can we test a few more cases? e.g., with or without flag, and check whether the content of the flag is actually logged correctly.
There was a problem hiding this comment.
thanks for your suggestion.
I will modify it.
jianghuazhu
force-pushed
the
HDFS-15516
branch
from
e0997f7
to
10afd5d
Compare
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
jianghuazhu
force-pushed
the
HDFS-15516
branch
from
10afd5d
to
c6c5b39
Compare
|
💔 -1 overall
This message was automatically generated. |
jianghuazhu
force-pushed
the
HDFS-15516
branch
from
c6c5b39
to
e667f64
Compare
|
🎊 +1 overall
This message was automatically generated. |
|
@ayushtkn, I made some changes, can you review it? |
|
🎊 +1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTICE
Please create an issue in ASF JIRA before opening a pull request,
and you need to set the title of the pull request which starts with
the corresponding JIRA issue number. (e.g. HADOOP-XXXXX. Fix a typo in YYY.)
For more details, please see https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute