Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HDFS-15585: ViewDFS#getDelegationToken should not throw UnsupportedOperationException. #2312

Merged
merged 2 commits into from Sep 18, 2020
Merged

HDFS-15585: ViewDFS#getDelegationToken should not throw UnsupportedOperationException. #2312

merged 2 commits into from Sep 18, 2020

Conversation

umamaheswararao
Copy link
Contributor

ayushtkn
ayushtkn approved these changes Sep 18, 2020
View reviewed changes
Copy link
Member

@ayushtkn ayushtkn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanx @umamaheswararao for the fix.
Changes LGTM +1

...-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestViewDistributedFileSystem.java Outdated Show resolved Hide resolved
@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 0m 30s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
+0 🆗 mvndep 3m 18s Maven dependency ordering for branch
+1 💚 mvninstall 25m 54s trunk passed
+1 💚 compile 4m 1s trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚 compile 3m 45s trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
+1 💚 checkstyle 1m 0s trunk passed
+1 💚 mvnsite 2m 17s trunk passed
+1 💚 shadedclient 18m 15s branch has no errors when building and testing our client artifacts.
+1 💚 javadoc 1m 31s trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚 javadoc 2m 1s trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
+0 🆗 spotbugs 2m 23s Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚 findbugs 5m 31s trunk passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 27s Maven dependency ordering for patch
+1 💚 mvninstall 1m 51s the patch passed
+1 💚 compile 4m 11s the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚 javac 4m 11s the patch passed
+1 💚 compile 4m 25s the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
+1 💚 javac 4m 25s the patch passed
+1 💚 checkstyle 0m 58s the patch passed
+1 💚 mvnsite 2m 11s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 shadedclient 16m 36s patch has no errors when building and testing our client artifacts.
+1 💚 javadoc 1m 29s the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚 javadoc 1m 58s the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
-1 ❌ findbugs 3m 15s hadoop-hdfs in the patch failed.
_ Other Tests _
-1 ❌ unit 0m 48s hadoop-hdfs-client in the patch failed.
-1 ❌ unit 0m 26s hadoop-hdfs in the patch failed.
+0 🆗 asflicense 0m 25s ASF License check generated no output?
110m 11s
Subsystem Report/Notes
Docker ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2312/2/artifact/out/Dockerfile
GITHUB PR #2312
JIRA Issue HDFS-15585
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux 5c04e8f0e001 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / eacbe07
Default Java Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
findbugs https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2312/2/artifact/out/patch-findbugs-hadoop-hdfs-project_hadoop-hdfs.txt
unit https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2312/2/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs-client.txt
unit https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2312/2/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2312/2/testReport/
Max. process+thread count 414 (vs. ulimit of 5500)
modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2312/2/console
versions git=2.17.1 maven=3.6.0 findbugs=4.0.6
Powered by Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 32m 46s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 1 new or modified test files.
_ trunk Compile Tests _
+0 🆗 mvndep 3m 12s Maven dependency ordering for branch
+1 💚 mvninstall 28m 18s trunk passed
+1 💚 compile 4m 19s trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚 compile 3m 51s trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
+1 💚 checkstyle 0m 59s trunk passed
+1 💚 mvnsite 2m 8s trunk passed
+1 💚 shadedclient 18m 51s branch has no errors when building and testing our client artifacts.
+1 💚 javadoc 1m 25s trunk passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚 javadoc 1m 56s trunk passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
+0 🆗 spotbugs 2m 29s Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚 findbugs 5m 39s trunk passed
_ Patch Compile Tests _
+0 🆗 mvndep 0m 22s Maven dependency ordering for patch
+1 💚 mvninstall 1m 56s the patch passed
+1 💚 compile 5m 0s the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚 javac 5m 0s the patch passed
+1 💚 compile 4m 32s the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
+1 💚 javac 4m 32s the patch passed
+1 💚 checkstyle 0m 58s the patch passed
+1 💚 mvnsite 2m 15s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 shadedclient 16m 13s patch has no errors when building and testing our client artifacts.
+1 💚 javadoc 1m 21s the patch passed with JDK Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1
+1 💚 javadoc 1m 51s the patch passed with JDK Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
+1 💚 findbugs 5m 57s the patch passed
_ Other Tests _
+1 💚 unit 1m 58s hadoop-hdfs-client in the patch passed.
-1 ❌ unit 113m 4s hadoop-hdfs in the patch passed.
+1 💚 asflicense 0m 45s The patch does not generate ASF License warnings.
260m 36s
Reason Tests
Failed junit tests hadoop.hdfs.TestSnapshotCommands
hadoop.hdfs.TestFileChecksumCompositeCrc
hadoop.hdfs.server.blockmanagement.TestBlockTokenWithDFSStriped
hadoop.hdfs.TestFileChecksum
hadoop.hdfs.server.namenode.TestNameNodeRetryCacheMetrics
hadoop.hdfs.server.sps.TestExternalStoragePolicySatisfier
hadoop.hdfs.server.balancer.TestBalancer
Subsystem Report/Notes
Docker ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2312/1/artifact/out/Dockerfile
GITHUB PR #2312
JIRA Issue HDFS-15585
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux 0ae17e1e753e 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / eacbe07
Default Java Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.8+10-post-Ubuntu-0ubuntu118.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_265-8u265-b01-0ubuntu2~18.04-b01
unit https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2312/1/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2312/1/testReport/
Max. process+thread count 3100 (vs. ulimit of 5500)
modules C: hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2312/1/console
versions git=2.17.1 maven=3.6.0 findbugs=4.0.6
Powered by Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

@ayushtkn ayushtkn merged commit 7bba4c6 into apache:trunk Sep 18, 2020
asfgit pushed a commit that referenced this pull request Sep 18, 2020
@umamaheswararao @ayushtkn
HDFS-15585: ViewDFS#getDelegationToken should not throw UnsupportedOp…
2ce5846 
…erationException. (#2312). Contributed by Uma Maheswara Rao G.
@umamaheswararao
Copy link
Contributor Author

Thanks @ayushtkn for the commit.

bilaharith pushed a commit to bilaharith/hadoop that referenced this pull request Sep 27, 2020
@umamaheswararao @bilaharith
HDFS-15585: ViewDFS#getDelegationToken should not throw UnsupportedOp…
fd22cd7 
…erationException. (apache#2312). Contributed by Uma Maheswara Rao G.
jojochuang pushed a commit to jojochuang/hadoop that referenced this pull request May 23, 2023
@umamaheswararao
HDFS-15585: ViewDFS#getDelegationToken should not throw UnsupportedOp…
d191396 
…erationException. (apache#2312). Contributed by Uma Maheswara Rao G.

(cherry picked from commit 7bba4c6)
Change-Id: Id3092aff9f8773e2a6190756bc2062584fc444a8
(cherry picked from commit 0bdef920066fc9935a6a880a40eac35a62544d66)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ayushtkn ayushtkn ayushtkn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@umamaheswararao @hadoop-yetus @ayushtkn