Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YARN-10469. YARN-UI2 The accuracy of the percentage values in the same chart on the YARN 'Cluster OverView' page are inconsistent #2401

Merged
merged 2 commits into from Nov 2, 2020

Conversation

echohlne
Copy link
Contributor

@echohlne echohlne commented Oct 22, 2020

JIRA: https://issues.apache.org/jira/browse/YARN-10469

Ensure the accuracy of the percentage values in the same chart on the YARN 'Cluster OverView' page are consistent
just a small improvement.

before modified, the cluster overview page shows like this:
reproduce

After modified, the manual test results are as follows:
fixed

@echohlne echohlne changed the title [YARN-10469][YARN-UI2] The accuracy of the percentage values in the same chart on the YARN 'Cluster OverView' page are inconsistent YARN-10469. YARN-UI2 The accuracy of the percentage values in the same chart on the YARN 'Cluster OverView' page are inconsistent Oct 22, 2020
@hadoop-yetus
Copy link

🎊 +1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 35s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 jshint 0m 0s jshint was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
_ trunk Compile Tests _
+1 💚 mvninstall 31m 23s trunk passed
+1 💚 shadedclient 46m 17s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 0m 13s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 shadedclient 14m 48s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 asflicense 0m 32s The patch does not generate ASF License warnings.
64m 16s
Subsystem Report/Notes
Docker ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2401/1/artifact/out/Dockerfile
GITHUB PR #2401
JIRA Issue YARN-10469
Optional Tests dupname asflicense shadedclient jshint
uname Linux 88b0502f0282 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 7435604
Max. process+thread count 414 (vs. ulimit of 5500)
modules C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-ui
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2401/1/console
versions git=2.17.1 maven=3.6.0
Powered by Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

Copy link
Member

@jiwq jiwq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 Thanks @akiyamaneko for the contribution.

@echohlne
Copy link
Contributor Author

@jiwq Is there anyone else who can help review or merge the code? thanks 😁

@jiwq
Copy link
Member

jiwq commented Oct 30, 2020

@tangzhankun Can you help to review and merge it?

@tangzhankun tangzhankun merged commit deea5d8 into apache:trunk Nov 2, 2020
@tangzhankun
Copy link
Contributor

tangzhankun commented Nov 2, 2020

Merged it just now.
@jiwq Thanks for the review.
@akiyamaneko Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants