HDFS-15643. EC: Fix checksum computation in case of native encoders. #2424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
This was referenced Oct 30, 2020
|
The build is failing - This is something weird, Luckily I had one successful build on the jira, post that seems the Jenkins isn't happy with me. :-( |
@ayushtkn , this error used to show up from time to time. It was one of the things we discussed on the mailing list. |
|
Thanx @amahussein I have touched the test file. Well the test didn't run in this PR due to OOM. The only time it ran was yesterday. I have a patch too, seems the build crashed there as well. Will try a couple of times, If no help, I think we need to reach Infra guys. |
|
💔 -1 overall
This message was automatically generated. |
Oh..now the other fixed flaky tests fail again :) |
|
💔 -1 overall
This message was automatically generated. |
Happens sometimes. :-) On the jira too, We have the test passed. So, If you are +1 on the changes, I will revert the last commit(The change in test file) |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
+1 (non binding) |
|
💔 -1 overall
This message was automatically generated. |
aajisaka
approved these changes
Nov 4, 2020
asfgit
pushed a commit
that referenced
this pull request
Nov 4, 2020
…2424). Contributed by Ayush Saxena.
asfgit
pushed a commit
that referenced
this pull request
Nov 4, 2020
…2424). Contributed by Ayush Saxena.
asfgit
pushed a commit
that referenced
this pull request
Nov 4, 2020
…2424). Contributed by Ayush Saxena.
|
Thanx @aajisaka and @amahussein for the reviews!!! @amahussein it would be good to give a check to the tests that failed again, post getting fixed recently. I will try to figure out from the jenkins report, you to give a check |
|
Thanks @ayushtkn .. |
asfgit
pushed a commit
that referenced
this pull request
Nov 6, 2020
…2424). Contributed by Ayush Saxena.
Xushaohong
pushed a commit
to Xushaohong/hadoop
that referenced
this pull request
Jul 20, 2022
…e encoders. (apache#2424). Contributed by Ayush Saxena.
jojochuang
pushed a commit
to jojochuang/hadoop
that referenced
this pull request
May 23, 2023
…pache#2424). Contributed by Ayush Saxena. (cherry picked from commit 76a7c0c) Change-Id: Id1dc3c49eaca9d6c0fdd250d6a75444ccf46d507 (cherry picked from commit 1b8a9fde30a160dbc8c8810623716ea67549c36b)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/HDFS-15643
This is the reason for failure of TestFileChecksum when ISA-L is loaded