You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The patch appears to include 12 new or modified test files.
_ branch-2.10 Compile Tests _
+0 🆗
mvndep
2m 12s
Maven dependency ordering for branch
+1 💚
mvninstall
14m 53s
branch-2.10 passed
+1 💚
compile
13m 24s
branch-2.10 passed
+1 💚
checkstyle
2m 21s
branch-2.10 passed
+1 💚
mvnsite
6m 54s
branch-2.10 passed
+1 💚
javadoc
5m 18s
branch-2.10 passed
+0 🆗
spotbugs
2m 3s
Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚
findbugs
11m 6s
branch-2.10 passed
_ Patch Compile Tests _
+0 🆗
mvndep
0m 24s
Maven dependency ordering for patch
+1 💚
mvninstall
4m 39s
the patch passed
+1 💚
compile
12m 55s
the patch passed
-1 ❌
javac
12m 55s
root generated 79 new + 1531 unchanged - 3 fixed = 1610 total (was 1534)
+1 💚
checkstyle
2m 18s
root: The patch generated 0 new + 1008 unchanged - 11 fixed = 1008 total (was 1019)
+1 💚
mvnsite
6m 30s
the patch passed
+1 💚
whitespace
0m 0s
The patch has no whitespace issues.
+1 💚
javadoc
5m 27s
the patch passed
-1 ❌
findbugs
2m 45s
hadoop-common-project/hadoop-common generated 15 new + 0 unchanged - 0 fixed = 15 total (was 0)
_ Other Tests _
-1 ❌
unit
9m 18s
hadoop-common in the patch failed.
-1 ❌
unit
63m 3s
hadoop-hdfs in the patch failed.
+1 💚
unit
5m 0s
hadoop-hdfs-httpfs in the patch passed.
-1 ❌
unit
17m 55s
hadoop-hdfs-rbf in the patch failed.
-1 ❌
unit
67m 22s
hadoop-yarn-server-resourcemanager in the patch failed.
+1 💚
unit
4m 24s
hadoop-mapreduce-client-hs in the patch passed.
+1 💚
asflicense
0m 59s
The patch does not generate ASF License warnings.
287m 31s
Reason
Tests
FindBugs
module:hadoop-common-project/hadoop-common
Inconsistent synchronization of org.apache.hadoop.security.LdapGroupsMapping.bindPassword; locked 75% of time Unsynchronized access at LdapGroupsMapping.java:75% of time Unsynchronized access at LdapGroupsMapping.java:[line 631]
Inconsistent synchronization of org.apache.hadoop.security.LdapGroupsMapping.bindUser; locked 50% of time Unsynchronized access at LdapGroupsMapping.java:50% of time Unsynchronized access at LdapGroupsMapping.java:[line 630]
Inconsistent synchronization of org.apache.hadoop.security.LdapGroupsMapping.conf; locked 50% of time Unsynchronized access at LdapGroupsMapping.java:50% of time Unsynchronized access at LdapGroupsMapping.java:[line 633]
Inconsistent synchronization of org.apache.hadoop.security.LdapGroupsMapping.groupHierarchyLevels; locked 50% of time Unsynchronized access at LdapGroupsMapping.java:50% of time Unsynchronized access at LdapGroupsMapping.java:[line 340]
Inconsistent synchronization of org.apache.hadoop.security.LdapGroupsMapping.groupNameAttr; locked 50% of time Unsynchronized access at LdapGroupsMapping.java:50% of time Unsynchronized access at LdapGroupsMapping.java:[line 534]
Inconsistent synchronization of org.apache.hadoop.security.LdapGroupsMapping.ldapCxtFactoryClass; locked 50% of time Unsynchronized access at LdapGroupsMapping.java:50% of time Unsynchronized access at LdapGroupsMapping.java:[line 614]
Inconsistent synchronization of org.apache.hadoop.security.LdapGroupsMapping.ldapUrls; locked 50% of time Unsynchronized access at LdapGroupsMapping.java:50% of time Unsynchronized access at LdapGroupsMapping.java:[line 751]
Inconsistent synchronization of org.apache.hadoop.security.LdapGroupsMapping.memberOfAttr; locked 60% of time Unsynchronized access at LdapGroupsMapping.java:60% of time Unsynchronized access at LdapGroupsMapping.java:[line 504]
Inconsistent synchronization of org.apache.hadoop.security.LdapGroupsMapping.numAttemptsBeforeFailover; locked 50% of time Unsynchronized access at LdapGroupsMapping.java:50% of time Unsynchronized access at LdapGroupsMapping.java:[line 346]
Inconsistent synchronization of org.apache.hadoop.security.LdapGroupsMapping.posixGidAttr; locked 50% of time Unsynchronized access at LdapGroupsMapping.java:50% of time Unsynchronized access at LdapGroupsMapping.java:[line 398]
Inconsistent synchronization of org.apache.hadoop.security.LdapGroupsMapping.posixUidAttr; locked 60% of time Unsynchronized access at LdapGroupsMapping.java:60% of time Unsynchronized access at LdapGroupsMapping.java:[line 399]
Inconsistent synchronization of org.apache.hadoop.security.LdapGroupsMapping.useOneQuery; locked 66% of time Unsynchronized access at LdapGroupsMapping.java:66% of time Unsynchronized access at LdapGroupsMapping.java:[line 497]
Inconsistent synchronization of org.apache.hadoop.security.LdapGroupsMapping.useSsl; locked 66% of time Unsynchronized access at LdapGroupsMapping.java:66% of time Unsynchronized access at LdapGroupsMapping.java:[line 619]
Inconsistent synchronization of org.apache.hadoop.security.LdapGroupsMapping.userSearchFilter; locked 66% of time Unsynchronized access at LdapGroupsMapping.java:66% of time Unsynchronized access at LdapGroupsMapping.java:[line 486]
Inconsistent synchronization of org.apache.hadoop.security.LdapGroupsMapping.userbaseDN; locked 66% of time Unsynchronized access at LdapGroupsMapping.java:66% of time Unsynchronized access at LdapGroupsMapping.java:[line 486]
amahussein
changed the title
HADOOP-17079. [branch-2.10] Optimize UGI#getGroups by adding UGI#getGroupsSet
HADOOP-17485. port UGI#getGroupsSet optimizations into 2.10
Jan 21, 2021
hadoop-common-project/hadoop-common generated 15 new + 0 unchanged - 0 fixed = 15 total (was 0)
_ Other Tests _
-1 ❌
unit
9m 14s
hadoop-common in the patch failed.
-1 ❌
unit
65m 18s
hadoop-hdfs in the patch failed.
+1 💚
unit
5m 3s
hadoop-hdfs-httpfs in the patch passed.
-1 ❌
unit
18m 15s
hadoop-hdfs-rbf in the patch failed.
-1 ❌
unit
67m 48s
hadoop-yarn-server-resourcemanager in the patch failed.
+1 💚
unit
4m 37s
hadoop-mapreduce-client-hs in the patch passed.
+1 💚
asflicense
1m 0s
The patch does not generate ASF License warnings.
290m 12s
Reason
Tests
FindBugs
module:hadoop-common-project/hadoop-common
Inconsistent synchronization of org.apache.hadoop.security.LdapGroupsMapping.bindPassword; locked 75% of time Unsynchronized access at LdapGroupsMapping.java:75% of time Unsynchronized access at LdapGroupsMapping.java:[line 630]
Inconsistent synchronization of org.apache.hadoop.security.LdapGroupsMapping.bindUser; locked 50% of time Unsynchronized access at LdapGroupsMapping.java:50% of time Unsynchronized access at LdapGroupsMapping.java:[line 629]
Inconsistent synchronization of org.apache.hadoop.security.LdapGroupsMapping.conf; locked 50% of time Unsynchronized access at LdapGroupsMapping.java:50% of time Unsynchronized access at LdapGroupsMapping.java:[line 632]
Inconsistent synchronization of org.apache.hadoop.security.LdapGroupsMapping.groupHierarchyLevels; locked 50% of time Unsynchronized access at LdapGroupsMapping.java:50% of time Unsynchronized access at LdapGroupsMapping.java:[line 340]
Inconsistent synchronization of org.apache.hadoop.security.LdapGroupsMapping.groupNameAttr; locked 50% of time Unsynchronized access at LdapGroupsMapping.java:50% of time Unsynchronized access at LdapGroupsMapping.java:[line 533]
Inconsistent synchronization of org.apache.hadoop.security.LdapGroupsMapping.ldapCxtFactoryClass; locked 50% of time Unsynchronized access at LdapGroupsMapping.java:50% of time Unsynchronized access at LdapGroupsMapping.java:[line 613]
Inconsistent synchronization of org.apache.hadoop.security.LdapGroupsMapping.ldapUrls; locked 50% of time Unsynchronized access at LdapGroupsMapping.java:50% of time Unsynchronized access at LdapGroupsMapping.java:[line 750]
Inconsistent synchronization of org.apache.hadoop.security.LdapGroupsMapping.memberOfAttr; locked 60% of time Unsynchronized access at LdapGroupsMapping.java:60% of time Unsynchronized access at LdapGroupsMapping.java:[line 503]
Inconsistent synchronization of org.apache.hadoop.security.LdapGroupsMapping.numAttemptsBeforeFailover; locked 50% of time Unsynchronized access at LdapGroupsMapping.java:50% of time Unsynchronized access at LdapGroupsMapping.java:[line 346]
Inconsistent synchronization of org.apache.hadoop.security.LdapGroupsMapping.posixGidAttr; locked 50% of time Unsynchronized access at LdapGroupsMapping.java:50% of time Unsynchronized access at LdapGroupsMapping.java:[line 398]
Inconsistent synchronization of org.apache.hadoop.security.LdapGroupsMapping.posixUidAttr; locked 60% of time Unsynchronized access at LdapGroupsMapping.java:60% of time Unsynchronized access at LdapGroupsMapping.java:[line 399]
Inconsistent synchronization of org.apache.hadoop.security.LdapGroupsMapping.useOneQuery; locked 66% of time Unsynchronized access at LdapGroupsMapping.java:66% of time Unsynchronized access at LdapGroupsMapping.java:[line 496]
Inconsistent synchronization of org.apache.hadoop.security.LdapGroupsMapping.useSsl; locked 66% of time Unsynchronized access at LdapGroupsMapping.java:66% of time Unsynchronized access at LdapGroupsMapping.java:[line 618]
Inconsistent synchronization of org.apache.hadoop.security.LdapGroupsMapping.userSearchFilter; locked 66% of time Unsynchronized access at LdapGroupsMapping.java:66% of time Unsynchronized access at LdapGroupsMapping.java:[line 485]
Inconsistent synchronization of org.apache.hadoop.security.LdapGroupsMapping.userbaseDN; locked 66% of time Unsynchronized access at LdapGroupsMapping.java:66% of time Unsynchronized access at LdapGroupsMapping.java:[line 485]
The patch appears to include 12 new or modified test files.
_ branch-2.10 Compile Tests _
+0 🆗
mvndep
2m 13s
Maven dependency ordering for branch
+1 💚
mvninstall
15m 4s
branch-2.10 passed
+1 💚
compile
13m 39s
branch-2.10 passed
+1 💚
checkstyle
2m 18s
branch-2.10 passed
+1 💚
mvnsite
6m 30s
branch-2.10 passed
+1 💚
javadoc
5m 9s
branch-2.10 passed
+0 🆗
spotbugs
2m 3s
Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚
findbugs
11m 42s
branch-2.10 passed
_ Patch Compile Tests _
+0 🆗
mvndep
0m 23s
Maven dependency ordering for patch
+1 💚
mvninstall
4m 45s
the patch passed
+1 💚
compile
12m 53s
the patch passed
-1 ❌
javac
12m 53s
root generated 79 new + 1531 unchanged - 3 fixed = 1610 total (was 1534)
+1 💚
checkstyle
2m 17s
root: The patch generated 0 new + 983 unchanged - 8 fixed = 983 total (was 991)
+1 💚
mvnsite
6m 16s
the patch passed
+1 💚
whitespace
0m 0s
The patch has no whitespace issues.
+1 💚
javadoc
5m 19s
the patch passed
-1 ❌
findbugs
2m 46s
hadoop-common-project/hadoop-common generated 2 new + 0 unchanged - 0 fixed = 2 total (was 0)
_ Other Tests _
+1 💚
unit
10m 3s
hadoop-common in the patch passed.
-1 ❌
unit
68m 53s
hadoop-hdfs in the patch failed.
+1 💚
unit
4m 51s
hadoop-hdfs-httpfs in the patch passed.
-1 ❌
unit
18m 23s
hadoop-hdfs-rbf in the patch failed.
-1 ❌
unit
70m 52s
hadoop-yarn-server-resourcemanager in the patch failed.
+1 💚
unit
4m 37s
hadoop-mapreduce-client-hs in the patch passed.
+1 💚
asflicense
0m 58s
The patch does not generate ASF License warnings.
298m 40s
Reason
Tests
FindBugs
module:hadoop-common-project/hadoop-common
Inconsistent synchronization of org.apache.hadoop.security.LdapGroupsMapping.bindPassword; locked 75% of time Unsynchronized access at LdapGroupsMapping.java:75% of time Unsynchronized access at LdapGroupsMapping.java:[line 596]
Inconsistent synchronization of org.apache.hadoop.security.LdapGroupsMapping.bindUser; locked 50% of time Unsynchronized access at LdapGroupsMapping.java:50% of time Unsynchronized access at LdapGroupsMapping.java:[line 595]
Inconsistent synchronization of org.apache.hadoop.security.LdapGroupsMapping.bindPassword; locked 75% of time Unsynchronized access at LdapGroupsMapping.java:75% of time Unsynchronized access at LdapGroupsMapping.java:[line 596]
Was this caused by this PR or was it already there before/
Inconsistent synchronization of org.apache.hadoop.security.LdapGroupsMapping.bindPassword; locked 75% of time Unsynchronized access at LdapGroupsMapping.java:75% of time Unsynchronized access at LdapGroupsMapping.java:[line 596]
Was this caused by this PR or was it already there before/
I think this PR added public Set<String> getGroupsSet(String user) in line LdapGroupsMapping#627 that is not synchronized which in turn calls doGetGroups(). Perhaps this is why findbugs finds it a concurrency issue.
The patch appears to include 12 new or modified test files.
_ branch-2.10 Compile Tests _
+0 🆗
mvndep
2m 29s
Maven dependency ordering for branch
+1 💚
mvninstall
12m 30s
branch-2.10 passed
+1 💚
compile
13m 2s
branch-2.10 passed with JDK Azul Systems, Inc.-1.7.0_262-b10
+1 💚
compile
10m 44s
branch-2.10 passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~16.04.1-b10
+1 💚
checkstyle
2m 9s
branch-2.10 passed
+1 💚
mvnsite
6m 2s
branch-2.10 passed
+1 💚
javadoc
5m 28s
branch-2.10 passed with JDK Azul Systems, Inc.-1.7.0_262-b10
+1 💚
javadoc
4m 32s
branch-2.10 passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~16.04.1-b10
+0 🆗
spotbugs
28m 21s
Both FindBugs and SpotBugs are enabled, using SpotBugs.
-1 ❌
spotbugs
2m 1s
hadoop-common-project/hadoop-common in branch-2.10 has 2 extant spotbugs warnings.
-1 ❌
spotbugs
2m 31s
hadoop-hdfs-project/hadoop-hdfs in branch-2.10 has 1 extant spotbugs warnings.
_ Patch Compile Tests _
+0 🆗
mvndep
0m 20s
Maven dependency ordering for patch
+1 💚
mvninstall
3m 44s
the patch passed
+1 💚
compile
12m 20s
the patch passed with JDK Azul Systems, Inc.-1.7.0_262-b10
-1 ❌
javac
12m 20s
root-jdkAzulSystems,Inc.-1.7.0_262-b10 with JDK Azul Systems, Inc.-1.7.0_262-b10 generated 79 new + 1676 unchanged - 3 fixed = 1755 total (was 1679)
+1 💚
compile
10m 39s
the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~16.04.1-b10
-1 ❌
javac
10m 39s
root-jdkPrivateBuild-1.8.0_292-8u292-b10-0ubuntu116.04.1-b10 with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu116.04.1-b10 generated 79 new + 1569 unchanged - 3 fixed = 1648 total (was 1572)
+1 💚
checkstyle
2m 9s
root: The patch generated 0 new + 764 unchanged - 6 fixed = 764 total (was 770)
+1 💚
mvnsite
5m 52s
the patch passed
+1 💚
whitespace
0m 0s
The patch has no whitespace issues.
+1 💚
javadoc
5m 29s
the patch passed with JDK Azul Systems, Inc.-1.7.0_262-b10
+1 💚
javadoc
4m 32s
the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~16.04.1-b10
-1 ❌
spotbugs
2m 12s
hadoop-common-project/hadoop-common generated 2 new + 2 unchanged - 0 fixed = 4 total (was 2)
_ Other Tests _
-1 ❌
unit
8m 4s
hadoop-common in the patch failed.
-1 ❌
unit
63m 8s
hadoop-hdfs in the patch failed.
+1 💚
unit
4m 32s
hadoop-hdfs-httpfs in the patch passed.
+1 💚
unit
17m 26s
hadoop-hdfs-rbf in the patch passed.
-1 ❌
unit
79m 32s
hadoop-yarn-server-resourcemanager in the patch failed.
+1 💚
unit
3m 47s
hadoop-mapreduce-client-hs in the patch passed.
+1 💚
asflicense
0m 57s
The patch does not generate ASF License warnings.
316m 46s
Reason
Tests
FindBugs
module:hadoop-common-project/hadoop-common
Inconsistent synchronization of org.apache.hadoop.security.LdapGroupsMapping.bindPassword; locked 75% of time Unsynchronized access at LdapGroupsMapping.java:75% of time Unsynchronized access at LdapGroupsMapping.java:[line 596]
Inconsistent synchronization of org.apache.hadoop.security.LdapGroupsMapping.bindUser; locked 50% of time Unsynchronized access at LdapGroupsMapping.java:50% of time Unsynchronized access at LdapGroupsMapping.java:[line 595]
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/HADOOP-17485
Porting to Hadoop-2.10 optimization from.
HADOOP-17079. Optimize UGI#getGroups by adding UGI#getGroupsSet. f91a8ad (#2085)
CC: @linyiqun @smengcl @xiaoyuyao @jojochuang @jbrennan333