New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HADOOP-17807. Use separate src dir for platform builds #3210
Conversation
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
3f1b650
to
53d7bae
Compare
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
e60e79b
to
345bbc1
Compare
🎊 +1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
🎊 +1 overall
This message was automatically generated. |
* Currently, each platform build run on the same checkout of the source code and YETUS deletes the git branch information. This is affecting the subsequent (optional) platform builds. * Need to ensure that each platform build stage runs on its own copy of the source directory. Use relative path for artifact archival * A relative path is expected for archiving artifacts step. Add documentation * Added the necessary documentation explaining the changes done in this PR. Copy the artifacts to correct place * Currently, the report published by YETUS towards the end of the build assumes that the "out" directory is located at ${WORKSPACE}/out. * This is causing dead links in the status messages that YETUS publishes. * Thus, we copy the artifacts to this expected place whenever the build fails for optional platform and always for non-optional platforms.
345bbc1
to
04ecb63
Compare
💔 -1 overall
This message was automatically generated. |
04ecb63
to
5a67d9d
Compare
💔 -1 overall
This message was automatically generated. |
All the testing has been done above. Since this is related to CI, there's no unit test that can be written for this. |
Hi @jojochuang , |
LGTM. +1 (Non binding). Thanks for your contribution. Much needed change for adding CIs. |
The value for this is clear and we should move ahead with this. |
I'll go ahead with the merge. |
checkout of the source code and YETUS deletes
the git branch information. This is affecting
the subsequent (optional) platform builds.
runs on its own copy of the source directory.
after the code was checked out in the CI, prior to
this PR -
.
└── workdir
├── out
└── src
with this PR -
.
└── workdir
├── centos-8
│ ├── out
│ └── src
├── debian-10
│ ├── out
│ └── src
├── out
├── src
└── ubuntu-focal
├── out
└── src