HADOOP-17891. Fix compilation error under skipShade (ADDENDUM) #3441
Conversation
viirya
changed the title
|
cc @sunchao |
viirya
changed the title
|
cc @ayushtkn too |
|
(!) A patch to the testing environment has been detected. |
|
@viirya I think you should use |
|
Oops! Fixed. Thanks. |
|
(!) A patch to the testing environment has been detected. |
|
Seems okay now. patch-shadedclient.txt was passed. |
|
The -1 from shadedclient is for branch-shadedclient.txt. But why branch build uses the updated |
There was a problem hiding this comment.
The build failure is just demonstrating what was broken.
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3441/2/artifact/out/branch-shadedclient.txt
It is fixed post the patch.
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3441/2/artifact/out/patch-shadedclient.txt
The -1 from shadedclient is for branch-shadedclient.txt. But why branch build uses the updated dev-support/bin/hadoop.sh too?
Yahh, I know would be a bit annoying for you. But it is build like that...
Anyway, That won't block this from getting in. Tried Locally as well. Things work now.
Thanx @sunchao and @viirya for fixing this.
|
Thank you @ayushtkn ! |
| <groupId>org.apache.hadoop</groupId> | ||
| <artifactId>hadoop-common</artifactId> | ||
| <scope>test</scope> | ||
| <type>test-jar</type> |
There was a problem hiding this comment.
nit: actually we may merge this with line 173
There was a problem hiding this comment.
This is type test-jar. Can we merge with type jar (line 173)?
There was a problem hiding this comment.
It worked as far as I tried on #3447, while I think it would be ok to have dedicated section for both jar and test-jar side-by-side.
|
Merged to trunk. Thanks @viirya ! |
|
Thank you @sunchao @ayushtkn @iwasakims ! |
This is a follow up for #3385 to fix the compilation error under skipShade.