Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HADOOP-17978. Exclude ASF license check for pkg-resolver JSON #3583

Merged

Conversation

GauthamBanasandra
Copy link
Member

@GauthamBanasandra GauthamBanasandra commented Oct 24, 2021

Reviewed-by: Viraj Jasani vjasani@apache.org
Reviewed-by: Masatake Iwasaki iwasakims@apache.org
Reviewed-by: Akira Ajisaka aajisaka@apache.org
Reviewed-by: Gautham B A gautham.bangalore@gmail.com

Description of PR

Backporting this fix to branch 2.10

How was this patch tested?

No testing required.

For code changes:

  • Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
  • Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

tasanuma and others added 2 commits October 24, 2021 13:53
…7727. (apache#3083)

Reviewed-by: Viraj Jasani <vjasani@apache.org>
Reviewed-by: Masatake Iwasaki <iwasakims@apache.org>
Reviewed-by: Akira Ajisaka <aajisaka@apache.org>
Reviewed-by: Gautham B A <gautham.bangalore@gmail.com>
@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 13m 36s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ branch-2.10 Compile Tests _
+1 💚 mvninstall 16m 4s branch-2.10 passed
+1 💚 compile 16m 15s branch-2.10 passed with JDK Azul Systems, Inc.-1.7.0_262-b10
+1 💚 compile 11m 12s branch-2.10 passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~16.04.1-b10
+1 💚 mvnsite 11m 21s branch-2.10 passed
-1 ❌ javadoc 0m 25s root in branch-2.10 failed with JDK Azul Systems, Inc.-1.7.0_262-b10.
+1 💚 javadoc 5m 15s branch-2.10 passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~16.04.1-b10
_ Patch Compile Tests _
+1 💚 mvninstall 9m 32s the patch passed
+1 💚 compile 13m 23s the patch passed with JDK Azul Systems, Inc.-1.7.0_262-b10
+1 💚 javac 13m 23s the patch passed
+1 💚 compile 11m 16s the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~16.04.1-b10
+1 💚 javac 11m 16s the patch passed
+1 💚 mvnsite 11m 11s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 xml 0m 1s The patch has no ill-formed XML file.
-1 ❌ javadoc 0m 21s root in the patch failed with JDK Azul Systems, Inc.-1.7.0_262-b10.
+1 💚 javadoc 5m 14s the patch passed with JDK Private Build-1.8.0_292-8u292-b10-0ubuntu1~16.04.1-b10
_ Other Tests _
-1 ❌ unit 31m 49s root in the patch failed.
+1 💚 asflicense 0m 43s The patch does not generate ASF License warnings.
161m 16s
Reason Tests
Failed junit tests hadoop.log.TestLogLevel
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3583/1/artifact/out/Dockerfile
GITHUB PR #3583
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient xml
uname Linux 50abd0c2361a 4.15.0-147-generic #151-Ubuntu SMP Fri Jun 18 19:21:19 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision branch-2.10 / de120b1
Default Java Private Build-1.8.0_292-8u292-b10-0ubuntu1~16.04.1-b10
Multi-JDK versions /usr/lib/jvm/zulu-7-amd64:Azul Systems, Inc.-1.7.0_262-b10 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_292-8u292-b10-0ubuntu1~16.04.1-b10
javadoc https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3583/1/artifact/out/branch-javadoc-root-jdkAzulSystems,Inc.-1.7.0_262-b10.txt
javadoc https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3583/1/artifact/out/patch-javadoc-root-jdkAzulSystems,Inc.-1.7.0_262-b10.txt
unit https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3583/1/artifact/out/patch-unit-root.txt
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3583/1/testReport/
Max. process+thread count 1348 (vs. ulimit of 5500)
modules C: . U: .
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3583/1/console
versions git=2.7.4 maven=3.3.9
Powered by Apache Yetus 0.12.0 https://yetus.apache.org

This message was automatically generated.

@GauthamBanasandra GauthamBanasandra changed the title Fix asf license branch 2.10 HADOOP-17978. Exclude ASF license check for pkg-resolver JSON Oct 24, 2021
@GauthamBanasandra
Copy link
Member Author

GauthamBanasandra commented Oct 24, 2021

This backport is need to fix the ASF license failure seen in #3535.

@GauthamBanasandra
Copy link
Member Author

With respect to the failures seen in the YETUS run above - #3583 (comment)

test4tests - This PR doesn't need any unit tests since we're just making a trivial config change.
javadoc - This failure is unrelated to this PR.
unit - This failure is unrelated to this PR.

@goiri goiri merged commit 3dd8880 into apache:branch-2.10 Oct 25, 2021
@GauthamBanasandra GauthamBanasandra deleted the fix-asf-license-branch-2.10 branch October 26, 2021 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants