MAPREDUCE-7368. DBOutputFormat.DBRecordWriter#write must throw except… #3671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion when it fails When the exception is caught and printed (instead of propagated) the consumer has no way to tell write failed. This hides the failure and leads to problems which are difficult to debug and at the same time can cause data corruption.
|
💔 -1 overall
This message was automatically generated. |
ayushtkn
reviewed
Dec 4, 2021
Comment on lines
124
to
125
| } catch (SQLException e) { | ||
| e.printStackTrace(); | ||
| throw new RuntimeException("Failed to execute SQL statement for key " + key, e); |
There was a problem hiding this comment.
In other places. It is converting the SQLException to IOE.
catch (SQLException ex) { throw new IOException(ex.getMessage());
Can we keep the same behaviour, will that also solve the problem.
There was a problem hiding this comment.
Good point. I think it makes sense to keep things uniform so I changed it to IOException in 1e67cec
|
💔 -1 overall
This message was automatically generated. |
HarshitGupta11
pushed a commit
to HarshitGupta11/hadoop
that referenced
this pull request
Nov 28, 2022
…ion when it fails. (apache#3671). Contributed by Stamatis Zampetakis. Signed-off-by: Ayush Saxena <ayushsaxena@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
When the exception is caught and printed (instead of propagated) the consumer has no way to tell write failed. This hides the failure and leads to problems which are difficult to debug and at the same time can cause data corruption.
More details in the JIRA MAPREDUCE-7368.
How was this patch tested?
Writing a well-contained test is not easy at the same time the change is straightforward so it may not be necessary.
For code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles?