-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HADOOP-18029: Update CompressionCodecFactory to handle uppercase file extensions #3739
Merged
giovannifumarola
merged 5 commits into
apache:trunk
from
Desmeister:compressionExtensionCase
Dec 1, 2021
Merged
HADOOP-18029: Update CompressionCodecFactory to handle uppercase file extensions #3739
giovannifumarola
merged 5 commits into
apache:trunk
from
Desmeister:compressionExtensionCase
Dec 1, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goiri
reviewed
Dec 1, 2021
...oject/hadoop-common/src/main/java/org/apache/hadoop/io/compress/CompressionCodecFactory.java
Outdated
Show resolved
Hide resolved
...oject/hadoop-common/src/main/java/org/apache/hadoop/io/compress/CompressionCodecFactory.java
Outdated
Show resolved
Hide resolved
...mmon-project/hadoop-common/src/test/java/org/apache/hadoop/io/compress/TestCodecFactory.java
Show resolved
Hide resolved
...mmon-project/hadoop-common/src/test/java/org/apache/hadoop/io/compress/TestCodecFactory.java
Show resolved
Hide resolved
🎊 +1 overall
This message was automatically generated. |
goiri
approved these changes
Dec 1, 2021
🎊 +1 overall
This message was automatically generated. |
@Desmeister can you fix the checkstyle warning? |
@Desmeister, I was referring to the checkstyle broken added by your changes but as you fixed the whole file already; let's go for it. |
🎊 +1 overall
This message was automatically generated. |
Thanks Desmond. Committed. |
HarshitGupta11
pushed a commit
to HarshitGupta11/hadoop
that referenced
this pull request
Nov 28, 2022
… extensions (apache#3739) Co-authored-by: Desmond Sisson <sissonde@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
I've updated the CompressionCodecFactory to be able to handle filenames with capitalized compression extensions. Two of the three existing internal maps used to store codecs have existing lowercase casts, but it is absent from the call inside getCodec() used for comparing path names. I updated the corresponding unit test in TestCodecFactory, to include intended use cases, and confirmed the test passes with the change.
Minor Fixes
How was this patch tested?
I confirmed the updated TestCodecFactory:testFinding() test passes, and reran the test suite of hadoop-common.
For code changes:
LICENSE
,LICENSE-binary
,NOTICE-binary
files?