HADOOP-18131. Upgrade maven enforcer plugin and relevant dependencies #4000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
shaded clients build is successful locally: |
|
@aajisaka @jojochuang could you please review this PR? |
virajjasani
commented
Feb 20, 2022
dev-support/Jenkinsfile
Outdated
| @@ -47,7 +47,7 @@ pipeline { | |||
|
|
|||
| options { | |||
| buildDiscarder(logRotator(numToKeepStr: '5')) | |||
| timeout (time: 24, unit: 'HOURS') | |||
| timeout (time: 30, unit: 'HOURS') | |||
There was a problem hiding this comment.
Because 24 hr is no longer sufficient for full QA run. Initial 5 builds timed out after 24 hr, hence this change.
There was a problem hiding this comment.
Could you separate jira to extend the timeout to backport it into lower branches easily?
There was a problem hiding this comment.
Done. Reverted the build timeout change. Created HADOOP-18142 to track extending timeout. Now that this change is reverted, we might not be able to get full QA results.
Thanks
There was a problem hiding this comment.
I have again put this change back until we get reliable QA results again. I will revert this before merge and after getting +1 for the rest of the changes.
Thanks
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
We have full QA results from Jenkins for this PR. |
This reverts commit 387e01f.
|
💔 -1 overall
This message was automatically generated. |
|
Hi @virajjasani, thank you for the upgrade. For snappy-java, how about excluding the osgi.core dependency in the dependencyManagement section of hadoop-project/pom.xml? Perhaps there are more libraries that can be excluded in the dependencyManagement section. |
|
Thanks @aajisaka, yes snappy-java as well as jersey-core both can have osgi.core excluded right in the hadoop-project pom. I will test and commit the changes. |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
💔 -1 overall
This message was automatically generated. |
aajisaka
approved these changes
Mar 3, 2022
There was a problem hiding this comment.
+1, I ran the failed tests on my local. Almost all the test passed.
- TestJHSSecurity: passed
- TestRouterDistCpProcedure: passed
- TestSeveralNameNodes: passed
- TestYarnClient: passed
- TestCapacityScheduler: passed
- TestFairSchedulerQueueACLs: passed
- TestCapacitySchedulerQueueACLs: passed
- TestApplicationACLs: passed
- TestClientRMService: passed
- TestApplicationPriorityACLs: passed
- TestDSTimelineV10: passed
- TestYarnConfigurationFields: not related -> YARN-11081
This reverts commit ec1c6ce.
|
Is it good to merge this PR? |
|
I am +1 too |
|
Thanks for the nice PR, @virajjasani. Thanks for your reviews, @aajisaka and @jojochuang. |
1 task
HarshitGupta11
pushed a commit
to HarshitGupta11/hadoop
that referenced
this pull request
Nov 28, 2022
…apache#4000) Reviewed-by: Akira Ajisaka <aajisaka@apache.org> Reviewed-by: Wei-Chiu Chuang <weichiu@apache.org> Signed-off-by: Takanobu Asanuma <tasanuma@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Maven enforcer plugin's latest version 3.0.0 has some noticeable improvements (e.g. MENFORCER-350, MENFORCER-388, MENFORCER-353) and fixes for us to incorporate. Besides, some of the relevant enforcer dependencies (e.g. extra enforcer rules and restrict import enforcer) too have good improvements.
We should upgrade maven enforcer plugin and the relevant dependencies.
How was this patch tested?
Locally
For code changes: