New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HDFS-16476.Increase the number of metrics used to record PendingRecoveryBlocks. #4010
base: trunk
Are you sure you want to change the base?
Conversation
💔 -1 overall
This message was automatically generated. |
There are some ci/cd related failures here that don't seem to be related. Regarding the display of logarithms, I think the block recovery work is something between NameNode and DataNode, so in the RBF module, I implemented a default value. E.g: Would you guys help to review this PR, @ayushtkn @virajjasani . |
For all such cases we have got the values from all namenodes at Router and then summed up for the metrics, So, as at the Router we can have a global look. We should do the same here as well |
OK, I'll try to perfect it as much as possible. |
💔 -1 overall
This message was automatically generated. |
d134ff5
to
b6518b9
Compare
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
There are some checkstyle related warnings here, but it doesn't seem to be related to the update I submitted. |
Here are some tests done on an online cluster. Open the dfsrouter jmx address, for example: dfsrouter:50071/jmx. The metrics related to PendingRecoveryBlocks will be fully recorded here. Can you help review this pr again, @ayushtkn . |
Description of PR
Now we don't know how many blocks are happening or are about to recover, the purpose of this pr is to record them through metrics.
Details: HDFS-16476
How was this patch tested?
When some blocks are recovering or are about to recover, you can view the number through metrics.