HDFS-16458. [SPS]: Fix bug for unit test of reconfiguring SPS mode #4041
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: HDFS-16458.
I resubmitted a PR, because the previous PR #3998 forgot to set the
issue ID
.TestNameNodeReconfigure#verifySPSEnabled was compared with itself(
isSPSRunning
) at assertEquals.In addition, after an
internal SPS
has been removed,spsService daemon
will not start within StoragePolicySatisfyManager. I think the relevant code can be removed to simplify the code.IMO, after reconfig SPS mode, we just need to confirm whether the mode is correct and whether spsManager is NULL.