Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HADOOP-18144: getTrashRoot in ViewFileSystem should return a path in ViewFS #4123

Merged
merged 1 commit into from
Mar 31, 2022

Conversation

xinglin
Copy link
Contributor

@xinglin xinglin commented Mar 30, 2022

This is a cherry-pick commit from trunk to branch-3.3 for the viewFS getTrashRoot work.

Signed-off-by: Owen O'Malley oomalley@linkedin.com
(cherry picked from commit 8b8158f)

…ViewFS.

To get the new behavior, define fs.viewfs.trash.force-inside-mount-point to be true.

If the trash root for path p is in the same mount point as path p,
and one of:
* The mount point isn't at the top of the target fs.
* The resolved path of path is root (eg it is the fallback FS).
* The trash root isn't in user's target fs home directory.
get the corresponding viewFS path for the trash root and return it.
Otherwise, use <mnt>/.Trash/<user>.

Signed-off-by: Owen O'Malley <oomalley@linkedin.com>
(cherry picked from commit 8b8158f)
@xinglin
Copy link
Contributor Author

xinglin commented Mar 30, 2022

Hi @omalley,

Here is the backport pull request. Appreciated if you could take a look!

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 10m 1s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
+1 💚 test4tests 0m 0s The patch appears to include 4 new or modified test files.
_ branch-3.3 Compile Tests _
+0 🆗 mvndep 3m 24s Maven dependency ordering for branch
+1 💚 mvninstall 31m 18s branch-3.3 passed
+1 💚 compile 18m 12s branch-3.3 passed
+1 💚 checkstyle 2m 50s branch-3.3 passed
+1 💚 mvnsite 3m 7s branch-3.3 passed
+1 💚 javadoc 3m 8s branch-3.3 passed
+1 💚 spotbugs 6m 31s branch-3.3 passed
+1 💚 shadedclient 30m 12s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 0m 55s Maven dependency ordering for patch
+1 💚 mvninstall 2m 6s the patch passed
+1 💚 compile 17m 21s the patch passed
+1 💚 javac 17m 21s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 checkstyle 2m 50s the patch passed
+1 💚 mvnsite 2m 58s the patch passed
+1 💚 javadoc 3m 7s the patch passed
+1 💚 spotbugs 6m 5s the patch passed
+1 💚 shadedclient 27m 41s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 17m 11s hadoop-common in the patch passed.
-1 ❌ unit 207m 44s /patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt hadoop-hdfs in the patch passed.
+1 💚 asflicense 0m 57s The patch does not generate ASF License warnings.
394m 40s
Reason Tests
Failed junit tests hadoop.hdfs.server.namenode.ha.TestFailureToReadEdits
hadoop.hdfs.tools.offlineImageViewer.TestOfflineImageViewer
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4123/1/artifact/out/Dockerfile
GITHUB PR #4123
JIRA Issue HADOOP-18144
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell
uname Linux 5d782d25f6d6 4.15.0-163-generic #171-Ubuntu SMP Fri Nov 5 11:55:11 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision branch-3.3 / 442be08
Default Java Private Build-1.8.0_312-8u312-b07-0ubuntu1~18.04-b07
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4123/1/testReport/
Max. process+thread count 3143 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4123/1/console
versions git=2.17.1 maven=3.6.0 spotbugs=4.2.2
Powered by Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

Copy link
Contributor

@omalley omalley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@omalley omalley merged commit ecafd38 into apache:branch-3.3 Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants