HDFS-16568. dfsadmin -reconfig option to start/query reconfig on all live datanodes #4264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎊 +1 overall
This message was automatically generated. |
|
@tomscut @jojochuang could you please take a look? |
tomscut
reviewed
May 6, 2022
| } | ||
| }); | ||
| } | ||
| while ((successCount.get() + failCount.get()) < nodes.length) { |
There was a problem hiding this comment.
This feature makes sense to me. It looks good overall.
Maybe it's better to use CountDownLatch here.
There was a problem hiding this comment.
Agree, countDownLatch would be better but since we are also keeping count of both success and failure, and using these counts to return final status (0 or 1), it is difficult to allocate count down number initially. For instance, if we use two latches - successCountDownLatch and failCountDownLatch, we can't know what initial count to initiate both latches with. Hence, if we still want to use CountDownLatch, we will have to use all 3 of them:
AtomicInteger successCount = new AtomicInteger();
AtomicInteger failCount = new AtomicInteger();
CountDownLatch countDownLatch = new CountDownLatch(nodes.length); // total count as nodes array length
Hence, rather than using additional CountDownLatch, maybe we are good with only two AtomicIntegers? WDYT?
There was a problem hiding this comment.
Thanks @virajjasani for your explanation. Sounds good.
tomscut
reviewed
May 6, 2022
| err.println("Only datanode type supports reconfiguration in bulk."); | ||
| return 1; | ||
| } | ||
| ExecutorService executorService = Executors.newFixedThreadPool(5); |
There was a problem hiding this comment.
The number of threads is fixed at 5. Can we pass it in as an argument on the command line? Just a little suggestion.
There was a problem hiding this comment.
I thought of doing the same initially, but then I realized that allowing users to provide threadpool size might be bit complicated for admin/user (i.e. bit more headache for user) as they would have to learn about where this size is going to be used internally, hence I kept it as 5 as it seemed reasonable for even bigger clusters. Does this sound good?
If you have strong preference, will be happy to do it :)
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
Hi @virajjasani , please take a look at the failed unit test. Thanks. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
Taken care of in the latest commit, thanks @tomscut |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
The failed unit tests seem unrelated to the change. +1 from my side. |
|
💔 -1 overall
This message was automatically generated. |
|
Hi @cndaimin , could you please help take a look at this failed unit test |
tomscut
approved these changes
May 9, 2022
|
Hi @jojochuang , could you please also take a look at this. Thank you. |
Yes, it's my mistake, I will submit a PR to fix it immediately. Sorry for that. |
|
@cndaimin fixed the failed unit test on HDFS-16573. I retriggered the jenkins. |
|
🎊 +1 overall
This message was automatically generated. |
|
Thanks @virajjasani for your contribution! |
tomscut
pushed a commit
to tomscut/hadoop
that referenced
this pull request
May 11, 2022
…live datanodes (apache#4264) Signed-off-by: Tao Li <tomscut@apache.org>
HarshitGupta11
pushed a commit
to HarshitGupta11/hadoop
that referenced
this pull request
Nov 28, 2022
…live datanodes (apache#4264) Signed-off-by: Tao Li <tomscut@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
DFSAdmin provides option to initiate or query the status of reconfiguration operation on only specific host based on host:port provided by user. It would be good to provide an ability to initiate such operations in bulk, on all live datanodes.
How was this patch tested?
Dev cluster and UT.
Sample outputs:
For code changes: