HDFS-16581. Print node status when executing printTopology #4321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
Here are some examples of online tests. |
|
There are some tests that fail in CI/CD. E.g: It looks like these failures have little to do with the code I submitted. |
|
🎊 +1 overall
This message was automatically generated. |
jianghuazhu
changed the title
tomscut
approved these changes
May 28, 2022
There was a problem hiding this comment.
The change looks good to me.
I am a little worried that this will change the output structure of printTopology. I wonder if this will be an incompatible change. Do I need to add a releaseNote? @tasanuma @virajjasani Could you please give some suggestions? Thanks.
|
Thanks @tomscut . |
virajjasani
reviewed
Jun 12, 2022
There was a problem hiding this comment.
Left few minor nits, overall change looks good. Thanks @jianghuazhu
Comment on lines
1654
to
1655
| HashMap<String, HashMap<String, String>> tree = new HashMap<String, | ||
| HashMap<String, String>>(); |
There was a problem hiding this comment.
nit: could you please replace this with?
Map<String, HashMap<String, String>> map = new HashMap<>();
There was a problem hiding this comment.
Sorry, this is my mistake, I will update later.
|
|
||
| tree.get(location).add(name); | ||
| if(!tree.containsKey(location)) { | ||
| tree.put(location, new HashMap<String, String>()); |
There was a problem hiding this comment.
same here, new HashMap<>() is sufficient :)
| ArrayList<String> racks = new ArrayList<String>(tree.keySet()); | ||
| Collections.sort(racks); | ||
| // Sort the racks (and nodes) alphabetically, display in order | ||
| ArrayList<String> racks = new ArrayList<String>(tree.keySet()); |
There was a problem hiding this comment.
nit: List<String> racks = new ArrayList<>(tree.keySet())
@tomscut sounds good, we can keep this to trunk and add release note as well reg the output format change, thanks! |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
Here are some failed unit tests. include: |
virajjasani
approved these changes
Jun 13, 2022
|
Thanks @virajjasani . |
tomscut
changed the title
tomscut
pushed a commit
that referenced
this pull request
Jun 16, 2022
Reviewed-by: Viraj Jasani <vjasani@apache.org> Signed-off-by: Tao Li <tomscut@apache.org>
|
Thanks @jianghuazhu for your contribution. Thanks @virajjasani for your review. |
HarshitGupta11
pushed a commit
to HarshitGupta11/hadoop
that referenced
this pull request
Nov 28, 2022
Reviewed-by: Viraj Jasani <vjasani@apache.org> Signed-off-by: Tao Li <tomscut@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Right now we can't directly see the status of some DataNodes, it would be helpful to see this information through the dfsadmin tool.
Details: HDFS-16581
How was this patch tested?
Need to test, when nodes are in DECOMMISSION_INPROGRESS, DECOMMISSION_INPROGRESS or alive state, we should correctly identify them.