YARN-6539. Create SecureLogin inside Router. #4354

zhengchenyu · 2022-05-25T06:09:14Z

Description of PR

https://issues.apache.org/jira/browse/YARN-6539

This PR is contributed by Xie YiFan, I transform from patch to PR, and fix some ut then add yarn-default.xml and license.

It is precondition so that we could use yarn federation in security mode.

How was this patch tested?

uni-test and test in our cluster manually.

For code changes:

support security for router

hadoop-yetus · 2022-05-25T09:29:11Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 43s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 1 new or modified test files.
			_ trunk Compile Tests _
+0 🆗	mvndep	14m 47s		Maven dependency ordering for branch
+1 💚	mvninstall	24m 46s		trunk passed
+1 💚	compile	10m 1s		trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	compile	8m 54s		trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	checkstyle	2m 21s		trunk passed
+1 💚	mvnsite	5m 24s		trunk passed
+1 💚	javadoc	5m 44s		trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	javadoc	5m 25s		trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	8m 51s		trunk passed
+1 💚	shadedclient	22m 38s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 35s		Maven dependency ordering for patch
+1 💚	mvninstall	2m 43s		the patch passed
+1 💚	compile	9m 14s		the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	javac	9m 14s		the patch passed
+1 💚	compile	8m 58s		the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	javac	8m 58s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
-0 ⚠️	checkstyle	2m 4s	/results-checkstyle-hadoop-yarn-project_hadoop-yarn.txt	hadoop-yarn-project/hadoop-yarn: The patch generated 3 new + 167 unchanged - 0 fixed = 170 total (was 167)
+1 💚	mvnsite	5m 8s		the patch passed
+1 💚	xml	0m 3s		The patch has no ill-formed XML file.
+1 💚	javadoc	4m 49s		the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	javadoc	4m 43s		the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	8m 35s		the patch passed
+1 💚	shadedclient	21m 44s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	1m 44s		hadoop-yarn-api in the patch passed.
+1 💚	unit	5m 25s		hadoop-yarn-common in the patch passed.
+1 💚	unit	3m 34s		hadoop-yarn-server-common in the patch passed.
+1 💚	unit	3m 30s		hadoop-yarn-server-router in the patch passed.
+1 💚	asflicense	1m 27s		The patch does not generate ASF License warnings.
		198m 38s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4354/1/artifact/out/Dockerfile
GITHUB PR	#4354
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell xml
uname	Linux eb9b5e95e349 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / e7ba5863ec99448ac3673149fc8d40ba8be639f0
Default Java	Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4354/1/testReport/
Max. process+thread count	809 (vs. ulimit of 5500)
modules	C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router U: hadoop-yarn-project/hadoop-yarn
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4354/1/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

zhengchenyu · 2022-06-01T07:49:01Z

@BilwaST @goiri Can you help me review this PR? this is an old issue. UT about security yarn federation cluster is blocked by this PR.

...rver-router/src/test/java/org/apache/hadoop/yarn/server/router/security/TestSecureLogin.java

hadoop-yetus · 2022-06-02T06:00:08Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 48s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 1s		codespell was not available.
+0 🆗	detsecrets	0m 1s		detect-secrets was not available.
+0 🆗	xmllint	0m 1s		xmllint was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 1 new or modified test files.
			_ trunk Compile Tests _
+0 🆗	mvndep	14m 24s		Maven dependency ordering for branch
+1 💚	mvninstall	27m 43s		trunk passed
+1 💚	compile	10m 34s		trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	compile	9m 1s		trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	checkstyle	2m 8s		trunk passed
+1 💚	mvnsite	4m 40s		trunk passed
+1 💚	javadoc	4m 25s		trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	javadoc	4m 9s		trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	7m 43s		trunk passed
+1 💚	shadedclient	23m 59s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 26s		Maven dependency ordering for patch
+1 💚	mvninstall	2m 28s		the patch passed
+1 💚	compile	9m 46s		the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	javac	9m 46s		the patch passed
+1 💚	compile	9m 1s		the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	javac	9m 1s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	1m 59s		the patch passed
+1 💚	mvnsite	4m 8s		the patch passed
+1 💚	javadoc	3m 53s		the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	javadoc	3m 43s		the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	7m 53s		the patch passed
+1 💚	shadedclient	24m 15s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	1m 25s		hadoop-yarn-api in the patch passed.
+1 💚	unit	5m 5s		hadoop-yarn-common in the patch passed.
+1 💚	unit	3m 7s		hadoop-yarn-server-common in the patch passed.
+1 💚	unit	3m 11s		hadoop-yarn-server-router in the patch passed.
+1 💚	asflicense	1m 9s		The patch does not generate ASF License warnings.
		194m 57s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4354/2/artifact/out/Dockerfile
GITHUB PR	#4354
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets xmllint
uname	Linux a898e276b89b 4.15.0-175-generic #184-Ubuntu SMP Thu Mar 24 17:48:36 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / 26e686e4fe4af25b9a53c72d04c9009da5cae81c
Default Java	Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4354/2/testReport/
Max. process+thread count	764 (vs. ulimit of 5500)
modules	C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router U: hadoop-yarn-project/hadoop-yarn
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4354/2/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

zhengchenyu · 2022-06-02T06:47:22Z

@goiri I have already fix it. Can you help me review it again and check whether could merge to truck or not? Thanks again.

...ain/java/org/apache/hadoop/yarn/server/router/clientrm/AbstractClientRequestInterceptor.java

goiri · 2022-06-03T00:36:47Z

...rver-router/src/test/java/org/apache/hadoop/yarn/server/router/security/TestSecureLogin.java

+      testMiniKDC.start();
+      testMiniKDC.createPrincipal(routerKeytabFile, "yarn/localhost");
+    } catch (Exception e) {
+      assertTrue("Couldn't setup MiniKDC", false);


Is this trying to fail if there is a failure?
Just do:

fail("Couldn't setup MiniKDC")

...rver-router/src/test/java/org/apache/hadoop/yarn/server/router/security/TestSecureLogin.java

goiri · 2022-06-03T00:37:31Z

...rver-router/src/test/java/org/apache/hadoop/yarn/server/router/security/TestSecureLogin.java

+    UserGroupInformation.setConfiguration(conf);
+    router = new Router();
+    router.init(conf);
+    router.start();


hadoop-yetus · 2022-06-05T16:20:16Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 52s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+0 🆗	xmllint	0m 0s		xmllint was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 1 new or modified test files.
			_ trunk Compile Tests _
+0 🆗	mvndep	74m 17s		Maven dependency ordering for branch
+1 💚	mvninstall	27m 50s		trunk passed
+1 💚	compile	10m 28s		trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	compile	9m 7s		trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	checkstyle	2m 9s		trunk passed
+1 💚	mvnsite	4m 39s		trunk passed
+1 💚	javadoc	4m 28s		trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	javadoc	4m 10s		trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	8m 42s		trunk passed
+1 💚	shadedclient	26m 14s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 26s		Maven dependency ordering for patch
+1 💚	mvninstall	2m 35s		the patch passed
+1 💚	compile	10m 12s		the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	javac	10m 12s		the patch passed
+1 💚	compile	8m 57s		the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	javac	8m 57s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	1m 57s		the patch passed
+1 💚	mvnsite	4m 8s		the patch passed
+1 💚	javadoc	3m 52s		the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	javadoc	3m 41s		the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	7m 52s		the patch passed
+1 💚	shadedclient	24m 36s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	1m 25s		hadoop-yarn-api in the patch passed.
+1 💚	unit	5m 5s		hadoop-yarn-common in the patch passed.
+1 💚	unit	3m 7s		hadoop-yarn-server-common in the patch passed.
+1 💚	unit	3m 30s		hadoop-yarn-server-router in the patch passed.
+1 💚	asflicense	1m 9s		The patch does not generate ASF License warnings.
		259m 19s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4354/3/artifact/out/Dockerfile
GITHUB PR	#4354
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets xmllint
uname	Linux 02aee47e451f 4.15.0-175-generic #184-Ubuntu SMP Thu Mar 24 17:48:36 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / 3b72615f3bc11e5de2ef17eddf1ad1b9ab452800
Default Java	Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4354/3/testReport/
Max. process+thread count	1217 (vs. ulimit of 5500)
modules	C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router U: hadoop-yarn-project/hadoop-yarn
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4354/3/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2022-06-06T04:42:23Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 49s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+0 🆗	xmllint	0m 0s		xmllint was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 1 new or modified test files.
			_ trunk Compile Tests _
+0 🆗	mvndep	14m 48s		Maven dependency ordering for branch
+1 💚	mvninstall	28m 4s		trunk passed
+1 💚	compile	10m 26s		trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	compile	9m 6s		trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	checkstyle	2m 8s		trunk passed
+1 💚	mvnsite	4m 36s		trunk passed
+1 💚	javadoc	4m 28s		trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	javadoc	4m 11s		trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	7m 46s		trunk passed
+1 💚	shadedclient	24m 22s		branch has no errors when building and testing our client artifacts.
-0 ⚠️	patch	24m 47s		Used diff version of patch file. Binary files and potentially other changes not applied. Please rebase and squash commits if necessary.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 27s		Maven dependency ordering for patch
+1 💚	mvninstall	2m 34s		the patch passed
+1 💚	compile	9m 52s		the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	javac	9m 52s		the patch passed
+1 💚	compile	9m 17s		the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	javac	9m 17s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	2m 5s		the patch passed
+1 💚	mvnsite	4m 24s		the patch passed
+1 💚	javadoc	3m 58s		the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	javadoc	3m 22s		the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	8m 5s		the patch passed
+1 💚	shadedclient	24m 54s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	1m 17s		hadoop-yarn-api in the patch passed.
+1 💚	unit	5m 2s		hadoop-yarn-common in the patch passed.
+1 💚	unit	3m 0s		hadoop-yarn-server-common in the patch passed.
+1 💚	unit	3m 26s		hadoop-yarn-server-router in the patch passed.
+1 💚	asflicense	1m 7s		The patch does not generate ASF License warnings.
		197m 14s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4354/4/artifact/out/Dockerfile
GITHUB PR	#4354
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets xmllint
uname	Linux e08a69a10d42 4.15.0-175-generic #184-Ubuntu SMP Thu Mar 24 17:48:36 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / c0d75cc791718483bb1f36455a7cf78992ed7a6b
Default Java	Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4354/4/testReport/
Max. process+thread count	1179 (vs. ulimit of 5500)
modules	C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router U: hadoop-yarn-project/hadoop-yarn
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4354/4/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2022-06-06T04:53:59Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 40s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 1s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+0 🆗	xmllint	0m 0s		xmllint was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 1 new or modified test files.
			_ trunk Compile Tests _
+0 🆗	mvndep	14m 57s		Maven dependency ordering for branch
+1 💚	mvninstall	26m 16s		trunk passed
+1 💚	compile	10m 57s		trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	compile	9m 31s		trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	checkstyle	2m 16s		trunk passed
+1 💚	mvnsite	5m 31s		trunk passed
+1 💚	javadoc	5m 26s		trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	javadoc	5m 15s		trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	8m 47s		trunk passed
+1 💚	shadedclient	21m 26s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 32s		Maven dependency ordering for patch
+1 💚	mvninstall	2m 42s		the patch passed
+1 💚	compile	9m 50s		the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	javac	9m 50s		the patch passed
+1 💚	compile	9m 22s		the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	javac	9m 22s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	1m 59s		the patch passed
+1 💚	mvnsite	4m 36s		the patch passed
+1 💚	javadoc	4m 26s		the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	javadoc	4m 19s		the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	8m 32s		the patch passed
+1 💚	shadedclient	21m 8s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	1m 36s		hadoop-yarn-api in the patch passed.
+1 💚	unit	5m 25s		hadoop-yarn-common in the patch passed.
+1 💚	unit	3m 24s		hadoop-yarn-server-common in the patch passed.
+1 💚	unit	3m 39s		hadoop-yarn-server-router in the patch passed.
+1 💚	asflicense	1m 19s		The patch does not generate ASF License warnings.
		198m 35s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4354/6/artifact/out/Dockerfile
GITHUB PR	#4354
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets xmllint
uname	Linux 6369401a82dd 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `60182b4`
Default Java	Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4354/6/testReport/
Max. process+thread count	1245 (vs. ulimit of 5500)
modules	C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router U: hadoop-yarn-project/hadoop-yarn
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4354/6/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2022-06-06T04:54:36Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 59s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 1s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+0 🆗	xmllint	0m 0s		xmllint was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 1 new or modified test files.
			_ trunk Compile Tests _
+0 🆗	mvndep	14m 42s		Maven dependency ordering for branch
+1 💚	mvninstall	26m 29s		trunk passed
+1 💚	compile	11m 1s		trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	compile	9m 31s		trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	checkstyle	2m 16s		trunk passed
+1 💚	mvnsite	5m 30s		trunk passed
+1 💚	javadoc	5m 25s		trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	javadoc	5m 11s		trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	8m 54s		trunk passed
+1 💚	shadedclient	21m 39s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 31s		Maven dependency ordering for patch
+1 💚	mvninstall	2m 41s		the patch passed
+1 💚	compile	10m 0s		the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	javac	10m 0s		the patch passed
+1 💚	compile	9m 24s		the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	javac	9m 24s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	1m 59s		the patch passed
+1 💚	mvnsite	4m 38s		the patch passed
+1 💚	javadoc	4m 29s		the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	javadoc	4m 15s		the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	8m 31s		the patch passed
+1 💚	shadedclient	21m 24s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	1m 34s		hadoop-yarn-api in the patch passed.
+1 💚	unit	5m 25s		hadoop-yarn-common in the patch passed.
+1 💚	unit	3m 22s		hadoop-yarn-server-common in the patch passed.
+1 💚	unit	3m 33s		hadoop-yarn-server-router in the patch passed.
+1 💚	asflicense	1m 15s		The patch does not generate ASF License warnings.
		199m 34s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4354/5/artifact/out/Dockerfile
GITHUB PR	#4354
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets xmllint
uname	Linux b6ac5795e493 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `60182b4`
Default Java	Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4354/5/testReport/
Max. process+thread count	1189 (vs. ulimit of 5500)
modules	C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router U: hadoop-yarn-project/hadoop-yarn
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4354/5/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

zhengchenyu · 2022-06-06T07:58:00Z

@goiri
I fix it, and rebase it. And I add some test which will verify ugi. Can you help review this PR? Thanks again.

slfan1989 · 2022-06-06T16:21:51Z

@zhengchenyu Can this pr guarantee that the router will run for a long time? Is ticket renewa considered?

...rver-router/src/test/java/org/apache/hadoop/yarn/server/router/security/TestSecureLogin.java

goiri · 2022-06-06T16:44:11Z

...rver-router/src/test/java/org/apache/hadoop/yarn/server/router/security/TestSecureLogin.java

+      router.start();
+      assertEquals(UserGroupInformation.getLoginUser()
+          .getAuthenticationMethod(), AuthenticationMethod.KERBEROS);
+      assertEquals(UserGroupInformation.getLoginUser().getUserName(),


Usually expected goes first.

...rver-router/src/test/java/org/apache/hadoop/yarn/server/router/security/TestSecureLogin.java

goiri · 2022-06-06T16:45:04Z

...rver-router/src/test/java/org/apache/hadoop/yarn/server/router/security/TestSecureLogin.java

+  @Test
+  public void testRouterSecureLogin() {
+    try {
+      conf = new YarnConfiguration();


Define conf in the method, no need to make it a field.

zhengchenyu · 2022-06-09T04:01:37Z

@zhengchenyu Can this pr guarantee that the router will run for a long time? Is ticket renewa considered?

@slfan1989 The purpose of SecureLogin is that we can't fake user to start router in startup stage.

hadoop-yetus · 2022-06-14T11:30:46Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 44s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 1s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+0 🆗	xmllint	0m 0s		xmllint was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 1 new or modified test files.
			_ trunk Compile Tests _
+0 🆗	mvndep	14m 21s		Maven dependency ordering for branch
+1 💚	mvninstall	24m 44s		trunk passed
+1 💚	compile	9m 53s		trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	compile	8m 57s		trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	checkstyle	2m 22s		trunk passed
+1 💚	mvnsite	5m 45s		trunk passed
+1 💚	javadoc	5m 43s		trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	javadoc	5m 23s		trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	8m 42s		trunk passed
+1 💚	shadedclient	22m 2s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 31s		Maven dependency ordering for patch
+1 💚	mvninstall	2m 44s		the patch passed
+1 💚	compile	9m 6s		the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	javac	9m 6s		the patch passed
+1 💚	compile	8m 43s		the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	javac	8m 43s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	2m 6s		the patch passed
+1 💚	mvnsite	5m 7s		the patch passed
+1 💚	javadoc	4m 52s		the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	javadoc	4m 41s		the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	8m 31s		the patch passed
+1 💚	shadedclient	21m 44s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	1m 39s		hadoop-yarn-api in the patch passed.
+1 💚	unit	5m 26s		hadoop-yarn-common in the patch passed.
+1 💚	unit	3m 32s		hadoop-yarn-server-common in the patch passed.
+1 💚	unit	3m 50s		hadoop-yarn-server-router in the patch passed.
+1 💚	asflicense	1m 23s		The patch does not generate ASF License warnings.
		197m 13s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4354/7/artifact/out/Dockerfile
GITHUB PR	#4354
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets xmllint
uname	Linux 884e700af391 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `df4fce3`
Default Java	Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4354/7/testReport/
Max. process+thread count	1265 (vs. ulimit of 5500)
modules	C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router U: hadoop-yarn-project/hadoop-yarn
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4354/7/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2022-06-16T06:27:52Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 42s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+0 🆗	xmllint	0m 0s		xmllint was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 1 new or modified test files.
			_ trunk Compile Tests _
+0 🆗	mvndep	15m 3s		Maven dependency ordering for branch
+1 💚	mvninstall	25m 31s		trunk passed
+1 💚	compile	9m 55s		trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	compile	8m 58s		trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	checkstyle	2m 22s		trunk passed
+1 💚	mvnsite	5m 37s		trunk passed
+1 💚	javadoc	5m 34s		trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	javadoc	5m 24s		trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	8m 40s		trunk passed
+1 💚	shadedclient	22m 2s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 34s		Maven dependency ordering for patch
+1 💚	mvninstall	2m 44s		the patch passed
+1 💚	compile	9m 10s		the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	javac	9m 10s		the patch passed
+1 💚	compile	8m 50s		the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	javac	8m 50s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	2m 6s		the patch passed
+1 💚	mvnsite	5m 7s		the patch passed
+1 💚	javadoc	4m 51s		the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	javadoc	4m 43s		the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	8m 33s		the patch passed
+1 💚	shadedclient	21m 43s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	1m 40s		hadoop-yarn-api in the patch passed.
+1 💚	unit	5m 29s		hadoop-yarn-common in the patch passed.
+1 💚	unit	3m 31s		hadoop-yarn-server-common in the patch passed.
+1 💚	unit	3m 41s		hadoop-yarn-server-router in the patch passed.
+1 💚	asflicense	1m 37s		The patch does not generate ASF License warnings.
		199m 0s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4354/9/artifact/out/Dockerfile
GITHUB PR	#4354
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets xmllint
uname	Linux 7f51d2292982 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `a2a2c6b`
Default Java	Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4354/9/testReport/
Max. process+thread count	1248 (vs. ulimit of 5500)
modules	C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router U: hadoop-yarn-project/hadoop-yarn
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4354/9/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

slfan1989 · 2022-06-17T01:39:59Z

LGTM +1

zhengchenyu · 2022-06-27T06:39:28Z

@goiri @steveloughran How about this PR merge to trunk?

steveloughran · 2022-06-27T09:49:51Z

@goiri @steveloughran How about this PR merge to trunk?

i don't go near YARN. better that way for all.

asking me to review things there is counterproductive, because at best all that will happen is that I will request changes of the test code, so adding extra homework. once you've done that you will still need a YARN expert to review the production code

steveloughran

i don't review hdfs or yarn code. looked at the tests

...rver-router/src/test/java/org/apache/hadoop/yarn/server/router/security/TestSecureLogin.java

zhengchenyu · 2022-06-29T09:14:44Z

@goiri @steveloughran How about this PR merge to trunk?

i don't go near YARN. better that way for all.

asking me to review things there is counterproductive, because at best all that will happen is that I will request changes of the test code, so adding extra homework. once you've done that you will still need a YARN expert to review the production code

Okay, I know. Thank you all the same for review!

...rver-router/src/test/java/org/apache/hadoop/yarn/server/router/security/TestSecureLogin.java

hadoop-yetus · 2022-06-30T07:45:53Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 52s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 1s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+0 🆗	xmllint	0m 0s		xmllint was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 1 new or modified test files.
			_ trunk Compile Tests _
+0 🆗	mvndep	14m 43s		Maven dependency ordering for branch
+1 💚	mvninstall	29m 54s		trunk passed
+1 💚	compile	10m 39s		trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	compile	9m 7s		trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	checkstyle	2m 13s		trunk passed
+1 💚	mvnsite	4m 38s		trunk passed
+1 💚	javadoc	4m 30s		trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	javadoc	4m 12s		trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	7m 46s		trunk passed
+1 💚	shadedclient	24m 7s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 26s		Maven dependency ordering for patch
+1 💚	mvninstall	2m 27s		the patch passed
+1 💚	compile	9m 49s		the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	javac	9m 49s		the patch passed
+1 💚	compile	8m 59s		the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	javac	8m 59s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	1m 58s		the patch passed
+1 💚	mvnsite	4m 10s		the patch passed
+1 💚	javadoc	3m 53s		the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	javadoc	3m 42s		the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	7m 58s		the patch passed
+1 💚	shadedclient	24m 2s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	1m 25s		hadoop-yarn-api in the patch passed.
+1 💚	unit	5m 8s		hadoop-yarn-common in the patch passed.
+1 💚	unit	3m 9s		hadoop-yarn-server-common in the patch passed.
+1 💚	unit	3m 29s		hadoop-yarn-server-router in the patch passed.
+1 💚	asflicense	1m 9s		The patch does not generate ASF License warnings.
		198m 46s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4354/10/artifact/out/Dockerfile
GITHUB PR	#4354
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets xmllint
uname	Linux 4ee1ffb84115 4.15.0-175-generic #184-Ubuntu SMP Thu Mar 24 17:48:36 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `34b7dd2`
Default Java	Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4354/10/testReport/
Max. process+thread count	1242 (vs. ulimit of 5500)
modules	C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router U: hadoop-yarn-project/hadoop-yarn
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4354/10/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2022-07-01T05:51:26Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 42s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 1s		codespell was not available.
+0 🆗	detsecrets	0m 1s		detect-secrets was not available.
+0 🆗	xmllint	0m 1s		xmllint was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 1 new or modified test files.
			_ trunk Compile Tests _
+0 🆗	mvndep	15m 59s		Maven dependency ordering for branch
+1 💚	mvninstall	25m 28s		trunk passed
+1 💚	compile	10m 1s		trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	compile	8m 56s		trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	checkstyle	2m 19s		trunk passed
+1 💚	mvnsite	5m 51s		trunk passed
+1 💚	javadoc	5m 30s		trunk passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	javadoc	5m 24s		trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	8m 42s		trunk passed
+1 💚	shadedclient	22m 2s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 35s		Maven dependency ordering for patch
+1 💚	mvninstall	2m 45s		the patch passed
+1 💚	compile	9m 5s		the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	javac	9m 5s		the patch passed
+1 💚	compile	8m 48s		the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	javac	8m 48s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	1m 59s		the patch passed
+1 💚	mvnsite	5m 8s		the patch passed
+1 💚	javadoc	4m 51s		the patch passed with JDK Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1
+1 💚	javadoc	4m 43s		the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	8m 35s		the patch passed
+1 💚	shadedclient	21m 31s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	1m 44s		hadoop-yarn-api in the patch passed.
+1 💚	unit	5m 31s		hadoop-yarn-common in the patch passed.
+1 💚	unit	3m 31s		hadoop-yarn-server-common in the patch passed.
+1 💚	unit	3m 41s		hadoop-yarn-server-router in the patch passed.
+1 💚	asflicense	1m 26s		The patch does not generate ASF License warnings.
		199m 27s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4354/11/artifact/out/Dockerfile
GITHUB PR	#4354
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets xmllint
uname	Linux ea707d3bd636 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `b88d3df`
Default Java	Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Private Build-11.0.15+10-Ubuntu-0ubuntu0.20.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4354/11/testReport/
Max. process+thread count	1200 (vs. ulimit of 5500)
modules	C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router U: hadoop-yarn-project/hadoop-yarn
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4354/11/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

zhengchenyu mentioned this pull request May 25, 2022

YARN-11148. In federation and security mode, nm recover may fail. #4308

Merged

goiri reviewed Jun 1, 2022

View reviewed changes

...rver-router/src/test/java/org/apache/hadoop/yarn/server/router/security/TestSecureLogin.java Outdated Show resolved Hide resolved

...rver-router/src/test/java/org/apache/hadoop/yarn/server/router/security/TestSecureLogin.java Outdated Show resolved Hide resolved

goiri reviewed Jun 3, 2022

View reviewed changes

zhengchenyu closed this Jun 6, 2022

zhengchenyu deleted the YARN-6539 branch June 6, 2022 01:25

zhengchenyu reopened this Jun 6, 2022

zhengchenyu force-pushed the YARN-6539 branch from c0d75cc to 60182b4 Compare June 6, 2022 01:33

goiri reviewed Jun 6, 2022

View reviewed changes

zhengchenyu closed this Jun 16, 2022

YARN-6539. Create SecureLogin inside Router.

a2a2c6b

zhengchenyu reopened this Jun 16, 2022

zhengchenyu force-pushed the YARN-6539 branch from df4fce3 to a2a2c6b Compare June 16, 2022 03:07

goiri approved these changes Jun 16, 2022

View reviewed changes

steveloughran requested changes Jun 27, 2022

View reviewed changes

fix ut

34b7dd2

goiri reviewed Jun 29, 2022

View reviewed changes

...rver-router/src/test/java/org/apache/hadoop/yarn/server/router/security/TestSecureLogin.java Show resolved Hide resolved

fix code style

b88d3df

zhengchenyu closed this Aug 25, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

YARN-6539. Create SecureLogin inside Router. #4354

YARN-6539. Create SecureLogin inside Router. #4354

zhengchenyu commented May 25, 2022 •

edited

hadoop-yetus commented May 25, 2022

zhengchenyu commented Jun 1, 2022

hadoop-yetus commented Jun 2, 2022

zhengchenyu commented Jun 2, 2022

goiri Jun 3, 2022

goiri Jun 3, 2022

hadoop-yetus commented Jun 5, 2022

hadoop-yetus commented Jun 6, 2022

hadoop-yetus commented Jun 6, 2022

hadoop-yetus commented Jun 6, 2022

zhengchenyu commented Jun 6, 2022

slfan1989 commented Jun 6, 2022

goiri Jun 6, 2022

goiri Jun 6, 2022

zhengchenyu commented Jun 9, 2022 •

edited

hadoop-yetus commented Jun 14, 2022

hadoop-yetus commented Jun 16, 2022

slfan1989 commented Jun 17, 2022

zhengchenyu commented Jun 27, 2022

steveloughran commented Jun 27, 2022

steveloughran left a comment

zhengchenyu commented Jun 29, 2022

hadoop-yetus commented Jun 30, 2022

hadoop-yetus commented Jul 1, 2022

YARN-6539. Create SecureLogin inside Router. #4354

YARN-6539. Create SecureLogin inside Router. #4354

Conversation

zhengchenyu commented May 25, 2022 • edited

Description of PR

How was this patch tested?

For code changes:

hadoop-yetus commented May 25, 2022

zhengchenyu commented Jun 1, 2022

hadoop-yetus commented Jun 2, 2022

zhengchenyu commented Jun 2, 2022

goiri Jun 3, 2022

Choose a reason for hiding this comment

goiri Jun 3, 2022

Choose a reason for hiding this comment

hadoop-yetus commented Jun 5, 2022

hadoop-yetus commented Jun 6, 2022

hadoop-yetus commented Jun 6, 2022

hadoop-yetus commented Jun 6, 2022

zhengchenyu commented Jun 6, 2022

slfan1989 commented Jun 6, 2022

goiri Jun 6, 2022

Choose a reason for hiding this comment

goiri Jun 6, 2022

Choose a reason for hiding this comment

zhengchenyu commented Jun 9, 2022 • edited

hadoop-yetus commented Jun 14, 2022

hadoop-yetus commented Jun 16, 2022

slfan1989 commented Jun 17, 2022

zhengchenyu commented Jun 27, 2022

steveloughran commented Jun 27, 2022

steveloughran left a comment

Choose a reason for hiding this comment

zhengchenyu commented Jun 29, 2022

hadoop-yetus commented Jun 30, 2022

hadoop-yetus commented Jul 1, 2022

zhengchenyu commented May 25, 2022 •

edited

zhengchenyu commented Jun 9, 2022 •

edited