Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HADOOP-18073. Push latest changes from trunk to feature branch. #4944

Conversation

ahmarsuhail
Copy link
Contributor

Description of PR

This PR rebases the feature branch onto trunk.

How was this patch tested?

Not required

ayushtkn and others added 30 commits August 5, 2022 08:34
…ation. (apache#4686). Contributed by Ayush Saxena.

Reviewed-by: Mingliang Liu <liuml07@apache.org>
Add the r3.3.4 changelog, release notes and jdiff xml files.
…pache#4702)


Reduces size of data read to 1 MB

Contributed by Ahmar Suhail
Co-authored-by: Ashutosh Gupta <ashugpt@amazon.com>
Signed-off-by: Akira Ajisaka <aajisaka@apache.org>
…onhistoryservice (apache#4603)

Co-authored-by: Ashutosh Gupta <ashugpt@amazon.com>
Signed-off-by: Akira Ajisaka <aajisaka@apache.org>
The name of the option to enable/disable thread level statistics is
"fs.iostatistics.thread.level.enabled";

There is also an enabled() probe in IOStatisticsContext which can
be used to see if the thread level statistics is active.

Contributed by Viraj Jasani
… Contributed by ZanderXu.

Reviewed-by: Inigo Goiri <inigoiri@apache.org>
Reviewed-by: He Xiaoqiao <hexiaoqiao@apache.org>
Signed-off-by: Ayush Saxena <ayushsaxena@apache.org>
…ed methods. (apache#4403). Contributed by fanshilun.

Signed-off-by: Ayush Saxena <ayushsaxena@apache.org>
…m stats. (apache#4704)

part of HADOOP-18103.

Contributed By: Mukund Thakur
… error (apache#4680)

When the MiniDFSClsuter detects that an exception caused an exit, it should include that exception as the cause for the AssertionError that it throws. The current AssertError simply reports the message "Test resulted in an unexpected exit" and provides a stack trace to the location of the check for an exit exception. This patch adds the original exception as the cause of the AssertError.
… in RouterRpcServer.class (apache#4716). Contributed by ZanderXu.

Signed-off-by: Ayush Saxena <ayushsaxena@apache.org>
…util.Shell (apache#4718). Contributed by Paul King.

Signed-off-by: Ayush Saxena <ayushsaxena@apache.org>
jobId.toString() to only be called when the ID isn't null.

this doesn't surface in MR, but spark seems to manage it

Change-Id: I06692ef30a4af510c660d7222292932a8d4b5147
slfan1989 and others added 27 commits September 19, 2022 13:14
…tests with prefetching (apache#4914)


Contributed by Viraj Jasani
…pload Failed After YARN-11241. (apache#4893). Contributed by fanshilun.

Signed-off-by: Ayush Saxena <ayushsaxena@apache.org>
…bleException (apache#4802). Contributed by Ashutosh Gupta.

Signed-off-by: Ayush Saxena <ayushsaxena@apache.org>
…e#3691). Contributed by guophilipse.

Signed-off-by: Ayush Saxena <ayushsaxena@apache.org>
…tem environment (apache#4884)

Co-authored-by: Ashutosh Gupta <ashugpt@amazon.com>
follow-on patch to HADOOP-18186. 

Contributed by: Viraj Jasani
…t to 1.9 (apache#4578)

Reviewed-by: Ashutosh Gupta <ashugpt@amazon.com>
Signed-off-by: Takanobu Asanuma <tasanuma@apache.org>
…4909)


This problem surfaced in impala integration tests
   IMPALA-11592. TestLocalCatalogRetries.test_fetch_metadata_retry fails in S3 build
after the change
  HADOOP-17461. Add thread-level IOStatistics Context
The actual GC race condition came with
 HADOOP-18091. S3A auditing leaks memory through ThreadLocal references

The fix for this is, if our hypothesis is correct, in WeakReferenceMap.create()
where a strong reference to the new value is kept in a local variable
*and referred to later* so that the JVM will not GC it.

Along with the fix, extra assertions ensure that if the problem is not fixed,
applications will fail faster/more meaningfully. 

Contributed by Steve Loughran.
…ash.moveToAppropriateTrash (apache#4869)

* HADOOP-18444 Add Support for localized trash for ViewFileSystem in Trash.moveToAppropriateTrash

Signed-off-by: Xing Lin <xinglin@linkedin.com>
…ervice-hbase-client (apache#4773)

Co-authored-by: Ashutosh Gupta <ashugpt@amazon.com>
Signed-off-by: Akira Ajisaka <aajisaka@apache.org>
…ervice-hbase-common (apache#4774)

Co-authored-by: Ashutosh Gupta <ashugpt@amazon.com>
Signed-off-by: Akira Ajisaka <aajisaka@apache.org>
Co-authored-by: Ashutosh Gupta <ashugpt@amazon.com>
Reviewed-by: Inigo Goiri <inigoiri@apache.org>
Signed-off-by: Akira Ajisaka <aajisaka@apache.org>
… S3AFileSystem field (apache#4926)


Follow-on to HADOOP-18455.

Contributed by Viraj Jasani
…ing XML received from an untrusted source (apache#4886)

Co-authored-by: Ashutosh Gupta <ashugpt@amazon.com>
Signed-off-by: Akira Ajisaka <aajisaka@apache.org>
part of HADOOP-18103.

Also introducing a config fs.s3a.vectored.active.ranged.reads
to configure the maximum number of number of range reads a
single input stream can have active (downloading, or queued)
to the central FileSystem instance's pool of queued operations.
This stops a single stream overloading the shared thread pool.

Contributed by: Mukund Thakur
@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 0m 55s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 15s No case conflicting files found.
+0 🆗 codespell 0m 15s codespell was not available.
+0 🆗 detsecrets 0m 15s detect-secrets was not available.
+0 🆗 yamllint 0m 15s yamllint was not available.
+0 🆗 xmllint 0m 1s xmllint was not available.
+0 🆗 buf 0m 1s buf was not available.
+0 🆗 buf 0m 1s buf was not available.
+0 🆗 markdownlint 0m 1s markdownlint was not available.
+0 🆗 jshint 0m 1s jshint was not available.
+0 🆗 shelldocs 0m 1s Shelldocs was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ pathlen 0m 0s /results-pathlen.txt The patch appears to contain 2 files with names longer than 240
+1 💚 test4tests 0m 0s The patch appears to include 232 new or modified test files.
_ feature-HADOOP-18073-s3a-sdk-upgrade Compile Tests _
+0 🆗 mvndep 15m 59s Maven dependency ordering for branch
+1 💚 mvninstall 25m 36s feature-HADOOP-18073-s3a-sdk-upgrade passed
+1 💚 compile 23m 17s feature-HADOOP-18073-s3a-sdk-upgrade passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 💚 compile 20m 42s feature-HADOOP-18073-s3a-sdk-upgrade passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 💚 checkstyle 5m 2s feature-HADOOP-18073-s3a-sdk-upgrade passed
+1 💚 mvnsite 19m 10s feature-HADOOP-18073-s3a-sdk-upgrade passed
+1 💚 javadoc 8m 14s feature-HADOOP-18073-s3a-sdk-upgrade passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 💚 javadoc 7m 19s feature-HADOOP-18073-s3a-sdk-upgrade passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+0 🆗 spotbugs 0m 30s branch/hadoop-project no spotbugs output file (spotbugsXml.xml)
+0 🆗 spotbugs 0m 29s branch/hadoop-project-dist no spotbugs output file (spotbugsXml.xml)
+0 🆗 spotbugs 0m 34s branch/hadoop-hdfs-project/hadoop-hdfs-native-client no spotbugs output file (spotbugsXml.xml)
+0 🆗 spotbugs 0m 35s branch/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site no spotbugs output file (spotbugsXml.xml)
+0 🆗 spotbugs 0m 34s branch/hadoop-client-modules/hadoop-client-api no spotbugs output file (spotbugsXml.xml)
+0 🆗 spotbugs 0m 35s branch/hadoop-client-modules/hadoop-client-runtime no spotbugs output file (spotbugsXml.xml)
+0 🆗 spotbugs 0m 43s branch/hadoop-client-modules/hadoop-client-minicluster no spotbugs output file (spotbugsXml.xml)
+1 💚 shadedclient 57m 18s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+0 🆗 mvndep 1m 0s Maven dependency ordering for patch
-1 ❌ mvninstall 1m 17s /patch-mvninstall-hadoop-hdfs-project_hadoop-hdfs.txt hadoop-hdfs in the patch failed.
-1 ❌ mvninstall 6m 13s /patch-mvninstall-root.txt root in the patch failed.
-1 ❌ compile 3m 50s /patch-compile-root-jdkUbuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04.txt root in the patch failed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04.
-1 ❌ cc 3m 50s /patch-compile-root-jdkUbuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04.txt root in the patch failed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04.
-1 ❌ javac 3m 50s /patch-compile-root-jdkUbuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04.txt root in the patch failed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04.
-1 ❌ compile 3m 20s /patch-compile-root-jdkPrivateBuild-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07.txt root in the patch failed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07.
-1 ❌ cc 3m 20s /patch-compile-root-jdkPrivateBuild-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07.txt root in the patch failed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07.
-1 ❌ javac 3m 20s /patch-compile-root-jdkPrivateBuild-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07.txt root in the patch failed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07.
-1 ❌ blanks 0m 1s /blanks-eol.txt The patch has 3018 line(s) that end in blanks. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
-1 ❌ blanks 0m 1s /blanks-tabs.txt The patch 5 line(s) with tabs.
-0 ⚠️ checkstyle 4m 21s /results-checkstyle-root.txt root: The patch generated 52 new + 3998 unchanged - 480 fixed = 4050 total (was 4478)
-1 ❌ mvnsite 9m 24s /patch-mvnsite-root.txt root in the patch failed.
+1 💚 shellcheck 0m 0s No new issues.
+1 💚 javadoc 7m 55s the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 💚 javadoc 7m 25s the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+0 🆗 spotbugs 0m 29s hadoop-project has no data from spotbugs
+0 🆗 spotbugs 0m 33s hadoop-project-dist has no data from spotbugs
-1 ❌ spotbugs 1m 31s /patch-spotbugs-hadoop-hdfs-project_hadoop-hdfs.txt hadoop-hdfs in the patch failed.
+0 🆗 spotbugs 0m 36s hadoop-hdfs-project/hadoop-hdfs-native-client has no data from spotbugs
+0 🆗 spotbugs 0m 33s hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site has no data from spotbugs
+0 🆗 spotbugs 0m 33s hadoop-client-modules/hadoop-client-api has no data from spotbugs
+0 🆗 spotbugs 0m 44s hadoop-client-modules/hadoop-client-runtime has no data from spotbugs
+0 🆗 spotbugs 0m 39s hadoop-client-modules/hadoop-client-minicluster has no data from spotbugs
-1 ❌ spotbugs 6m 56s /patch-spotbugs-root.txt root in the patch failed.
-1 ❌ shadedclient 8m 16s patch has errors when building and testing our client artifacts.
_ Other Tests _
-1 ❌ unit 72m 1s /patch-unit-root.txt root in the patch failed.
+1 💚 asflicense 1m 16s The patch does not generate ASF License warnings.
484m 38s
Subsystem Report/Notes
Docker ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4944/1/artifact/out/Dockerfile
GITHUB PR #4944
Optional Tests dupname asflicense codespell detsecrets yamllint compile javac javadoc mvninstall mvnsite unit shadedclient xmllint spotbugs checkstyle cc buflint bufcompat markdownlint jshint shellcheck shelldocs
uname Linux b382e844d31c 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision feature-HADOOP-18073-s3a-sdk-upgrade / 735e35d
Default Java Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
Multi-JDK versions /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4944/1/testReport/
Max. process+thread count 2774 (vs. ulimit of 5500)
modules C: hadoop-project hadoop-project-dist hadoop-maven-plugins hadoop-common-project/hadoop-common hadoop-common-project/hadoop-nfs hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-native-client hadoop-yarn-project/hadoop-yarn hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app hadoop-hdfs-project/hadoop-hdfs-rbf hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-sharedcachemanager hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timeline-pluginstorage hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice-hbase/hadoop-yarn-server-timelineservice-hbase-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice-hbase/hadoop-yarn-server-timelineservice-hbase-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-services/hadoop-yarn-services-core hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-catalog/hadoop-yarn-applications-catalog-webapp hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site hadoop-yarn-project/hadoop-yarn/hadoop-yarn-csi hadoop-mapreduce-project hadoop-tools/hadoop-aws hadoop-tools/hadoop-azure hadoop-client-modules/hadoop-client-api hadoop-client-modules/hadoop-client-runtime hadoop-client-modules/hadoop-client-minicluster . U: .
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4944/1/console
versions git=2.25.1 maven=3.6.3 spotbugs=4.2.2 shellcheck=0.7.0
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

@asfgit asfgit merged commit 735e35d into apache:feature-HADOOP-18073-s3a-sdk-upgrade Sep 29, 2022
@steveloughran
Copy link
Contributor

ok, this is now the feature branch. i did this with the help of the github app

git branch -D feature-HADOOP-18073-s3a-sdk-upgrade
gh pr checkout 4944
git push --force apache

closing this; if there are problems complain

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet