YARN-11305. Fix TestLogAggregationService#testLocalFileDeletionAfterUpload Failed After YARN-11241(#4703). #4893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pload Failed After YARN-11241(apache#4703).
|
@ashutoshcipher @aajisaka |
ashutoshcipher
approved these changes
Sep 15, 2022
There was a problem hiding this comment.
Makes sense. FYI - This failure is observed with parallel mode enabled, hence was uncaught in YARN-11241(#4703)
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
ayushtkn
reviewed
Sep 16, 2022
There was a problem hiding this comment.
dropped a minor comment, link YARN-11241 in the Jira as the cause as well, no one is going to check git logs while backporting YARN-11241 or any such jira and he will potentially miss this
| Thread.sleep(100); | ||
| Thread.sleep(1000); |
There was a problem hiding this comment.
Is there some scope to change this hard-coded sleep with GenericTestUtils.waitFor?
There was a problem hiding this comment.
Thank you very much for your help reviewing the code, I will use GenericTestUtils.waitFor for code refactoring.
| verifyLocalFileDeletion(logAggregationService); | ||
| verifyLocalFileDeletion(logAggregationService, 4321L); |
There was a problem hiding this comment.
Is there some logic behind these numbers? If not I think we should generate random numbers instead, else someone adding a new tests, unaware of these numbers will landup into the same mess. But I am ok to do the present way if others feel this is better approach
There was a problem hiding this comment.
Thanks for the suggestion, I also think it would be better to use random numbers.
|
@ayushtkn Please help to review the code again, thank you very much! |
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
|
@ayushtkn Please help to review the code again, thank you very much! |
|
@ashutoshcipher @ayushtkn Thank you very much for helping to review the code! |
HarshitGupta11
pushed a commit
to HarshitGupta11/hadoop
that referenced
this pull request
Nov 28, 2022
…pload Failed After YARN-11241. (apache#4893). Contributed by fanshilun. Signed-off-by: Ayush Saxena <ayushsaxena@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
YARN-11305. Fix TestLogAggregationService#testLocalFileDeletionAfterUpload Failed After YARN-11241(#4703).
ERROR Message:
testReport:
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4846/23/testReport/
Yarn's unit tests, with parallel mode enabled
Because the automatically generated application_id is the same, testLocalFileDeletionAfterUpload is affected by testLocalFileRemainsAfterUploadOnCleanupDisable
testLocalFileDeletionAfterUpload needs to check that the log of an application is deleted, and testLocalFileRemainsAfterUploadOnCleanupDisable regenerates the log of the same application.