HADOOP-18471. Fixed ArrayIndexOutOfBoundsException in class DefaultStringifier #4957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎊 +1 overall
This message was automatically generated. |
ZanderXu
reviewed
Oct 1, 2022
|
🎊 +1 overall
This message was automatically generated. |
steveloughran
requested changes
Oct 3, 2022
There was a problem hiding this comment.
commented. i'd expect the original code to raise the same exception on the [0] index reference; the new test run against the old code should verify that.
regarding the new test, use our `intercept()' method, e.g.
intercept(IndexOutOfBoundsException.class, () ->
DefaultStringifier.storeArray(conf, new Integer[] {}, keyName));
| @@ -107,6 +108,12 @@ public void testStoreLoadArray() throws IOException { | |||
| Integer[] array = new Integer[] {1,2,3,4,5}; | |||
|
|
|||
|
|
|||
| try { | |||
There was a problem hiding this comment.
use our LambdaTestUtils.intercept() here; it's a reimplementation of scalatest's and straightforward to use it.
There was a problem hiding this comment.
we have updated the code, please review.
| @@ -158,6 +158,9 @@ public static <K> K load(Configuration conf, String keyName, | |||
| public static <K> void storeArray(Configuration conf, K[] items, | |||
| String keyName) throws IOException { | |||
|
|
|||
| if (items.length == 0) { | |||
| throw new IndexOutOfBoundsException(); | |||
| } | |||
| DefaultStringifier<K> stringifier = new DefaultStringifier<K>(conf, | |||
| GenericsUtil.getClass(items[0])); | |||
There was a problem hiding this comment.
won't this trigger the same exception automatically? what does the test do before the new lines are added
There was a problem hiding this comment.
Thanks @steveloughran for the review.
Yes, the original code would trigger ArrayIndexOutOfBoundsException automatically, and the new test passes without the new lines.
But we found the same exception has been handled in other places in the same module and hence, propose to handle it.
|
🎊 +1 overall
This message was automatically generated. |
steveloughran
approved these changes
Oct 20, 2022
| @@ -158,6 +158,9 @@ public static <K> K load(Configuration conf, String keyName, | |||
| public static <K> void storeArray(Configuration conf, K[] items, | |||
| String keyName) throws IOException { | |||
|
|
|||
| if (items.length == 0) { | |||
| throw new IndexOutOfBoundsException(); | |||
| } | |||
| DefaultStringifier<K> stringifier = new DefaultStringifier<K>(conf, | |||
| GenericsUtil.getClass(items[0])); | |||
asfgit
pushed a commit
that referenced
this pull request
Oct 20, 2022
…ier (#4957) Contributed by FuzzingTeam
|
thanks, in trunk and branch-3.3 |
HarshitGupta11
pushed a commit
to HarshitGupta11/hadoop
that referenced
this pull request
Nov 28, 2022
…ier (apache#4957) Contributed by FuzzingTeam
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
JIRA: HADOOP-18471
How was this patch tested?
Modified an existing unit test
testStoreLoadArrayof test classTestDefaultStringifierto verify.For code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles?