YARN-11345. [Federation] Refactoring Yarn Router's Application Web Page. #5030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎊 +1 overall
This message was automatically generated. |
|
@goiri Can you help review the code? Thank you very much! |
|
🎊 +1 overall
This message was automatically generated. |
|
@goiri Can you help review this pr? Thank you very much! |
goiri
approved these changes
Oct 19, 2022
| appsTableData.append("\"],\n"); | ||
|
|
||
| } catch (Exception e) { | ||
| LOG.info( |
| "Cannot add application {}: {}", app.getAppId(), e.getMessage()); | ||
| } | ||
| } | ||
| if (appsTableData.charAt(appsTableData.length() - 2) == ',') { |
There was a problem hiding this comment.
As we are refactoring, this is a little hacky.
At least it could be more readable.
There was a problem hiding this comment.
I will modify the code.
|
🎊 +1 overall
This message was automatically generated. |
goiri
approved these changes
Oct 20, 2022
| } | ||
| } | ||
|
|
||
| // The purpose of this part of the code is to remove redundant commas. |
There was a problem hiding this comment.
We know how many apps there will be, we should only add it if not the last:
if (appsInfo != null) {
Collection<AppInfo> apps = appsInfo.getApps();
if (CollectionUtils.isNotEmpty(apps)) {
int numApps = apps.size();
for (AppInfo app: apps) {
...
if (i < numApps - 1) {
appsTableData.append(",");
}
}
}
}
There was a problem hiding this comment.
Thanks for your suggestion, I will refactor this part of the code.
|
🎊 +1 overall
This message was automatically generated. |
goiri
approved these changes
Oct 20, 2022
| Collection<AppInfo> apps = appsInfo.getApps(); | ||
| if (CollectionUtils.isNotEmpty(apps)) { | ||
| int numApps = apps.size(); | ||
| int i = 0; |
There was a problem hiding this comment.
I put i++ after try...catch and the loop can end even if the application has errors.
slfan1989
commented
Oct 20, 2022
| } catch (Exception e) { | ||
| LOG.info("Cannot add application {}: {}", app.getAppId(), e.getMessage()); | ||
| } | ||
| i++; |
There was a problem hiding this comment.
i++ is placed after try...catch.
There was a problem hiding this comment.
Thanks for your suggestion, I will refactor this part of the code to make it more readable.
There was a problem hiding this comment.
I read this part of the code carefully, the original code is reasonable, we should remove the extra comma outside the loop because we can't tell where the last comma is
For example:
We have 4 apps, A, B, C, D, and we expect the result to be [A, B, C, D], but when traversing the app list, the last app D fails, and we end up with [A ,B,C,], the last app D fails, we can't handle this situation inside the loop.
But the readability of the original logic is not good, I refactored this part of the code.
|
🎊 +1 overall
This message was automatically generated. |
goiri
approved these changes
Oct 21, 2022
|
🎊 +1 overall
This message was automatically generated. |
|
@goiri Can you help to merge this pr into trunk branch? Thank you very much! I will follow up with YARN-11354 [Federation] Add Yarn Router's NodeLabel Web Page. |
goiri
approved these changes
Oct 24, 2022
|
@goiri Thank you very much for helping to review the code! |
HarshitGupta11
pushed a commit
to HarshitGupta11/hadoop
that referenced
this pull request
Nov 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: YARN-11345. [Federation] Refactoring Yarn Router's Application Web Page.
Improve the Application page of Yarn Router, try to be the same as the Yarn RM app page.
Router App page style before modification:
Router App page style after modification:
From the router's point of view, we can see the app running of the entire Federation
From the subcluster point of view, we can see the app running of the subcluster
For SubCluster, support query by app status
If we don't enable Federation
