-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HDFS-16840. Enhance the usage description about oiv in HDFSCommands.md and OfflineImageViewerPB #5129
Conversation
💔 -1 overall
This message was automatically generated. |
The failed unit test seems unrelated to the change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @haiyang1987 for your report. Leave some minor comments.
...hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/OfflineImageViewerPB.java
Show resolved
Hide resolved
💔 -1 overall
This message was automatically generated. |
@@ -81,6 +81,8 @@ public class OfflineImageViewerPB { | |||
+ " changed via the -delimiter argument.\n" | |||
+ " -sp print storage policy, used by delimiter only.\n" | |||
+ " -ec print erasure coding policy, used by delimiter only.\n" | |||
+ " -m,--multiThread defines multiThread to process sub-sections, \n" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are there some duplicated options here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, i will remove --multiThread
...hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/OfflineImageViewerPB.java
Outdated
Show resolved
Hide resolved
💔 -1 overall
This message was automatically generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Thanks @haiyang1987 for your contribution! Thanks @tasanuma and @ZanderXu for your review! |
…d and OfflineImageViewerPB (apache#5129) Reviewed-by: Takanobu Asanuma <tasanuma@apache.org> Reviewed-by: ZanderXu <zanderxu@apache.org> Signed-off-by: Tao Li <tomscut@apache.org>
Description of PR
HDFS-16840
Enhance the usage description about oiv in HDFSCommands.md and OfflineImageViewerPB
the usage description support print out storage and erasure coding policy id, -maxSize, -step, -format and -addr
maybe can add relevant information in HDFSCommands.md to describe how to use it.