YARN-11385. Fix hadoop-yarn-server-common module Java Doc Errors. #5182

slfan1989 · 2022-12-03T07:45:04Z

JIRA: YARN-11385. Fix hadoop-yarn-server-common module Java Doc Errors.

In the process of completing YARN-11350(#5131), the java doc error is displayed in the compilation report, and I will fix the java doc error of the hadoop-yarn-server-common module.

The compilation report is as follows:
https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5131/15/artifact/out/patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common-jdkUbuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04.txt.

hadoop-yetus · 2022-12-03T09:28:50Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 36s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 1s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s		The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
			_ trunk Compile Tests _
+1 💚	mvninstall	39m 6s		trunk passed
+1 💚	compile	1m 1s		trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 💚	compile	0m 56s		trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 💚	checkstyle	0m 45s		trunk passed
+1 💚	mvnsite	1m 0s		trunk passed
+1 💚	javadoc	1m 1s		trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 💚	javadoc	0m 48s		trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	1m 51s		trunk passed
+1 💚	shadedclient	23m 6s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 40s		the patch passed
+1 💚	compile	0m 45s		the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 💚	javac	0m 45s		the patch passed
+1 💚	compile	0m 38s		the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 💚	javac	0m 38s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	0m 27s		hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common: The patch generated 0 new + 18 unchanged - 12 fixed = 18 total (was 30)
+1 💚	mvnsite	0m 42s		the patch passed
+1 💚	javadoc	0m 36s		hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common-jdkUbuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 generated 0 new + 0 unchanged - 47 fixed = 0 total (was 47)
+1 💚	javadoc	0m 37s		hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common-jdkPrivateBuild-1.8.0_342-8u342-b07-0ubuntu1~~20.04-b07 with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~~20.04-b07 generated 0 new + 0 unchanged - 47 fixed = 0 total (was 47)
+1 💚	spotbugs	1m 33s		the patch passed
+1 💚	shadedclient	21m 12s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	3m 18s		hadoop-yarn-server-common in the patch passed.
+1 💚	asflicense	0m 49s		The patch does not generate ASF License warnings.
		102m 23s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5182/1/artifact/out/Dockerfile
GITHUB PR	#5182
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname	Linux 1cf662398315 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `ed6801b`
Default Java	Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5182/1/testReport/
Max. process+thread count	675 (vs. ulimit of 5500)
modules	C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5182/1/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

...-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/lib/package-info.java

hadoop-yetus · 2022-12-05T18:59:46Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 43s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 1s		codespell was not available.
+0 🆗	detsecrets	0m 1s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s		The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
			_ trunk Compile Tests _
+1 💚	mvninstall	39m 24s		trunk passed
+1 💚	compile	0m 50s		trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 💚	compile	0m 48s		trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 💚	checkstyle	0m 42s		trunk passed
+1 💚	mvnsite	0m 56s		trunk passed
+1 💚	javadoc	0m 55s		trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 💚	javadoc	0m 45s		trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	1m 41s		trunk passed
+1 💚	shadedclient	21m 4s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 40s		the patch passed
+1 💚	compile	0m 39s		the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 💚	javac	0m 39s		the patch passed
+1 💚	compile	0m 35s		the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 💚	javac	0m 35s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	0m 21s		hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common: The patch generated 0 new + 18 unchanged - 12 fixed = 18 total (was 30)
+1 💚	mvnsite	0m 37s		the patch passed
+1 💚	javadoc	0m 37s		hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common-jdkUbuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 generated 0 new + 0 unchanged - 47 fixed = 0 total (was 47)
+1 💚	javadoc	0m 32s		hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-common-jdkPrivateBuild-1.8.0_342-8u342-b07-0ubuntu1~~20.04-b07 with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~~20.04-b07 generated 0 new + 0 unchanged - 47 fixed = 0 total (was 47)
+1 💚	spotbugs	1m 27s		the patch passed
+1 💚	shadedclient	21m 20s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	3m 8s		hadoop-yarn-server-common in the patch passed.
+1 💚	asflicense	0m 46s		The patch does not generate ASF License warnings.
		99m 15s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5182/2/artifact/out/Dockerfile
GITHUB PR	#5182
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname	Linux 8b81fba7fa03 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `12a7e9a`
Default Java	Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5182/2/testReport/
Max. process+thread count	559 (vs. ulimit of 5500)
modules	C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5182/2/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

slfan1989 · 2022-12-06T12:40:10Z

@cnauroth Can you help to review this PR again? Thank you very much!

@goiri Thank you very much for helping to review the code!

slfan1989 · 2022-12-07T23:40:34Z

@cnauroth Thank you very much for your help in reviewing the code! This part of the java doc error will affect the compilation of other PRs(#5131). Can you help to review it again?

slfan1989 · 2022-12-09T15:51:58Z

@goiri Can you help to merge this pr into the trunk branch? Thank you very much! I have modified the Java doc as suggested by cnauroth. After this pr is finished, I will recompile #5131.

goiri · 2022-12-10T23:03:01Z

The pending change from @cnauroth is solved.
I'll override the vote and merge.

slfan1989 · 2022-12-11T00:32:45Z

@goiri Thank you very much for helping to review the code! @cnauroth Thank you for your suggestion!

…ache#5182)

YARN-11385. Fix hadoop-yarn-server-common module Java Doc Errors.

ed6801b

slfan1989 mentioned this pull request Dec 5, 2022

YARN-11350. [Federation] Router Support DelegationToken With ZK. #5131

Merged

cnauroth requested changes Dec 5, 2022

View reviewed changes

...-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/lib/package-info.java Outdated Show resolved Hide resolved

YARN-11385. Fix CheckStyle.

12a7e9a

slfan1989 requested a review from cnauroth December 5, 2022 17:20

goiri approved these changes Dec 5, 2022

View reviewed changes

goiri approved these changes Dec 10, 2022

View reviewed changes

goiri merged commit a71aaef into apache:trunk Dec 10, 2022

slfan1989 mentioned this pull request Dec 12, 2022

HADOOP-18577. log/probes of HADOOP-18546 presence. #5205

Merged

4 tasks

slfan1989 added a commit to slfan1989/hadoop that referenced this pull request Dec 20, 2022

YARN-11385. Fix hadoop-yarn-server-common module Java Doc Errors. (ap…

8e24911

…ache#5182)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

YARN-11385. Fix hadoop-yarn-server-common module Java Doc Errors. #5182

YARN-11385. Fix hadoop-yarn-server-common module Java Doc Errors. #5182

slfan1989 commented Dec 3, 2022 •

edited

Loading

hadoop-yetus commented Dec 3, 2022

hadoop-yetus commented Dec 5, 2022

slfan1989 commented Dec 6, 2022

slfan1989 commented Dec 7, 2022

slfan1989 commented Dec 9, 2022

goiri commented Dec 10, 2022

slfan1989 commented Dec 11, 2022

YARN-11385. Fix hadoop-yarn-server-common module Java Doc Errors. #5182

YARN-11385. Fix hadoop-yarn-server-common module Java Doc Errors. #5182

Conversation

slfan1989 commented Dec 3, 2022 • edited Loading

hadoop-yetus commented Dec 3, 2022

hadoop-yetus commented Dec 5, 2022

slfan1989 commented Dec 6, 2022

slfan1989 commented Dec 7, 2022

slfan1989 commented Dec 9, 2022

goiri commented Dec 10, 2022

slfan1989 commented Dec 11, 2022

slfan1989 commented Dec 3, 2022 •

edited

Loading