YARN-11386. Fix issue with classpath resolution #5183

GauthamBanasandra · 2022-12-04T10:36:06Z

Description of PR

While launching the AM, the client puts the classpath into environment HashMap of the ContainerLaunchContext. To support cross-platform compatibility, some special notations must be used by the client. For example, <CPS> must be used as the classpath separator instead of ";" (Windows) or ":" (Linux). The NM would resolve all the <CPS> using the appropriate path separator according to the OS platform, prior to launching the container. In addition to this, the NM is also expected to expand and resolve all of the wildcard ( * ) occurrences in the classpath before launching the container, since the JVM doesn't understand the wildcard charater.

The issue we see here is, neither <CPS> resolution nor wildcard expansion is happening.

I tested this from Spark. To run a Spark application on YARN, one needs to set the spark.yarn.jars config to point to the location where Spark jars are present. NM would then add these jars to the classpath before launching the Spark AM container. The resolution didn't happen -

Manifest-Version:
1.0
Class-Path:
file:/D:/tmp/hadoop-Gautham/nm-local-dir/usercache/Gautham/appcache/application_1670138957874_0001/container_1670138957874_0001_01_000001/%7B%7BPWD%7D%7D%3CCPS%3E%7B%7BPWD%7D%7D/__spark_conf__%3CCPS%3E%7B%7BPWD%7D%7D/__spark_libs__/*%3CCPS%3E/D:/projects/github/apache/spark/jars/*%3CCPS%3E%7B%7BPWD%7D%7D/__spark_conf__/__hadoop_conf__
file:/D:/tmp/hadoop-Gautham/nm-local-dir/usercache/Gautham/appcache/application_1670138957874_0001/container_1670138957874_0001_01_000001/__spark_conf__/
file:/D:/tmp/hadoop-Gautham/nm-local-dir/usercache/Gautham/appcache/application_1670138957874_0001/container_1670138957874_0001_01_000001/__app__.jar

Note that %3CCPS%3E in the above code block should've been replaced by ";" or ":" as part of classpath resolution. Since this didn't happen, NM failed to launch the Spark AM container -

Could not find or load main class org.apache.spark.deploy.yarn.ApplicationMaster

How was this patch tested?

I tested locally by submitting a Spark job and ensured that it ran successfully.

For code changes:

Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

GauthamBanasandra · 2022-12-04T10:51:25Z

Here are the classpath resolutions before and after applying the fix (the current PR) -
classpaths.zip

hadoop-yetus · 2022-12-04T12:43:12Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 36s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s		The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
			_ trunk Compile Tests _
+1 💚	mvninstall	38m 33s		trunk passed
+1 💚	compile	1m 49s		trunk passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04
+1 💚	compile	1m 44s		trunk passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08
+1 💚	checkstyle	0m 58s		trunk passed
+1 💚	mvnsite	1m 7s		trunk passed
+1 💚	javadoc	1m 6s		trunk passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04
+1 💚	javadoc	0m 55s		trunk passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08
+1 💚	spotbugs	1m 54s		trunk passed
+1 💚	shadedclient	21m 41s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 45s		the patch passed
+1 💚	compile	1m 31s		the patch passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04
+1 💚	javac	1m 31s		the patch passed
+1 💚	compile	1m 26s		the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08
+1 💚	javac	1m 26s		the patch passed
+1 💚	blanks	0m 1s		The patch has no blanks issues.
+1 💚	checkstyle	0m 34s		the patch passed
+1 💚	mvnsite	0m 47s		the patch passed
+1 💚	javadoc	0m 40s		the patch passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04
+1 💚	javadoc	0m 38s		the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08
+1 💚	spotbugs	1m 34s		the patch passed
+1 💚	shadedclient	21m 27s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
-1 ❌	unit	24m 18s	/patch-unit-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager.txt	hadoop-yarn-server-nodemanager in the patch passed.
+1 💚	asflicense	0m 51s		The patch does not generate ASF License warnings.
		125m 48s

Reason	Tests
Failed junit tests	hadoop.yarn.server.nodemanager.containermanager.launcher.TestContainerLaunch

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5183/1/artifact/out/Dockerfile
GITHUB PR	#5183
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname	Linux a177fbff7f99 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `e467176`
Default Java	Private Build-1.8.0_352-8u352-ga-1~20.04-b08
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_352-8u352-ga-1~20.04-b08
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5183/1/testReport/
Max. process+thread count	561 (vs. ulimit of 5500)
modules	C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5183/1/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2022-12-04T17:34:49Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 35s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 1 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	39m 7s		trunk passed
+1 💚	compile	1m 43s		trunk passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04
+1 💚	compile	1m 42s		trunk passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08
+1 💚	checkstyle	1m 0s		trunk passed
+1 💚	mvnsite	1m 8s		trunk passed
+1 💚	javadoc	1m 7s		trunk passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04
+1 💚	javadoc	0m 55s		trunk passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08
+1 💚	spotbugs	1m 55s		trunk passed
+1 💚	shadedclient	21m 53s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 44s		the patch passed
+1 💚	compile	1m 32s		the patch passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04
+1 💚	javac	1m 32s		the patch passed
+1 💚	compile	1m 27s		the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08
+1 💚	javac	1m 27s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	0m 35s		the patch passed
+1 💚	mvnsite	0m 48s		the patch passed
-1 ❌	javadoc	0m 41s	/patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdkUbuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.txt	hadoop-yarn-server-nodemanager in the patch failed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04.
-1 ❌	javadoc	0m 38s	/patch-javadoc-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-nodemanager-jdkPrivateBuild-1.8.0_352-8u352-ga-1~20.04-b08.txt	hadoop-yarn-server-nodemanager in the patch failed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08.
+1 💚	spotbugs	1m 36s		the patch passed
+1 💚	shadedclient	21m 17s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	24m 21s		hadoop-yarn-server-nodemanager in the patch passed.
+1 💚	asflicense	0m 51s		The patch does not generate ASF License warnings.
		126m 3s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5183/2/artifact/out/Dockerfile
GITHUB PR	#5183
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname	Linux ed244069f45f 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `92741d0`
Default Java	Private Build-1.8.0_352-8u352-ga-1~20.04-b08
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_352-8u352-ga-1~20.04-b08
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5183/2/testReport/
Max. process+thread count	746 (vs. ulimit of 5500)
modules	C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5183/2/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2022-12-05T15:18:49Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 38s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 1 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	47m 15s		trunk passed
+1 💚	compile	1m 37s		trunk passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04
+1 💚	compile	1m 41s		trunk passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08
+1 💚	checkstyle	0m 52s		trunk passed
+1 💚	mvnsite	0m 55s		trunk passed
+1 💚	javadoc	0m 55s		trunk passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04
+1 💚	javadoc	0m 54s		trunk passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08
+1 💚	spotbugs	1m 54s		trunk passed
+1 💚	shadedclient	21m 21s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 43s		the patch passed
+1 💚	compile	1m 32s		the patch passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04
+1 💚	javac	1m 32s		the patch passed
+1 💚	compile	1m 21s		the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08
+1 💚	javac	1m 21s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	0m 29s		the patch passed
+1 💚	mvnsite	0m 42s		the patch passed
+1 💚	javadoc	0m 33s		the patch passed with JDK Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04
+1 💚	javadoc	0m 37s		the patch passed with JDK Private Build-1.8.0_352-8u352-ga-1~20.04-b08
+1 💚	spotbugs	1m 36s		the patch passed
+1 💚	shadedclient	21m 18s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	24m 4s		hadoop-yarn-server-nodemanager in the patch passed.
+1 💚	asflicense	0m 42s		The patch does not generate ASF License warnings.
		131m 56s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5183/3/artifact/out/Dockerfile
GITHUB PR	#5183
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname	Linux 4d56f767d981 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `ed17d08`
Default Java	Private Build-1.8.0_352-8u352-ga-1~20.04-b08
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.17+8-post-Ubuntu-1ubuntu220.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_352-8u352-ga-1~20.04-b08
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5183/3/testReport/
Max. process+thread count	558 (vs. ulimit of 5500)
modules	C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5183/3/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

GauthamBanasandra · 2022-12-05T15:53:12Z

@jbrennan333 could you please review this PR? This is related to one of your commits - YARN-10664.

jbrennan333

Good catch! This change looks good to me.

* This PR ensures that all the special notations such as <CPS> are resolved before getting added to classpath.

Fix classpath expansion

e467176

Fix unit tests

92741d0

Fix Javadoc

ed17d08

GauthamBanasandra marked this pull request as ready for review December 5, 2022 15:52

jbrennan333 approved these changes Dec 5, 2022

View reviewed changes

goiri approved these changes Dec 5, 2022

View reviewed changes

GauthamBanasandra merged commit dadd3d9 into apache:trunk Dec 6, 2022

GauthamBanasandra deleted the fix-classpath branch December 6, 2022 11:02

slfan1989 pushed a commit to slfan1989/hadoop that referenced this pull request Dec 20, 2022

YARN-11386. Fix issue with classpath resolution (apache#5183)

94db31c

* This PR ensures that all the special notations such as <CPS> are resolved before getting added to classpath.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

YARN-11386. Fix issue with classpath resolution #5183

YARN-11386. Fix issue with classpath resolution #5183

GauthamBanasandra commented Dec 4, 2022 •

edited

Loading

GauthamBanasandra commented Dec 4, 2022

hadoop-yetus commented Dec 4, 2022

hadoop-yetus commented Dec 4, 2022

hadoop-yetus commented Dec 5, 2022

GauthamBanasandra commented Dec 5, 2022 •

edited

Loading

jbrennan333 left a comment

YARN-11386. Fix issue with classpath resolution #5183

YARN-11386. Fix issue with classpath resolution #5183

Conversation

GauthamBanasandra commented Dec 4, 2022 • edited Loading

Description of PR

How was this patch tested?

For code changes:

GauthamBanasandra commented Dec 4, 2022

hadoop-yetus commented Dec 4, 2022

hadoop-yetus commented Dec 4, 2022

hadoop-yetus commented Dec 5, 2022

GauthamBanasandra commented Dec 5, 2022 • edited Loading

jbrennan333 left a comment

Choose a reason for hiding this comment

GauthamBanasandra commented Dec 4, 2022 •

edited

Loading

GauthamBanasandra commented Dec 5, 2022 •

edited

Loading