HDDS-1183. Override getDelegationToken API for OzoneFileSystem. Contr… #526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ibuted by Xiaoyu Yao.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
ajayydv
reviewed
Feb 28, 2019
hadoop-ozone/ozonefs/src/main/java/org/apache/hadoop/fs/ozone/OzoneFileSystem.java
Show resolved
Hide resolved
hadoop-ozone/ozonefs/src/main/java/org/apache/hadoop/fs/ozone/OzoneFileSystem.java
Show resolved
Hide resolved
|
+1, will add robot test as part HDDS-595. |
|
As I see it was reverted on the trunk. Can we have some information what was the problem? |
|
I see. Thanks the information. (I investigated a build problem and I was not sure if this revert is connected. But now I see that it's just an administration revert) |
shanthoosh
pushed a commit
to shanthoosh/hadoop
that referenced
this pull request
Oct 15, 2019
In existing implementation, `ZkBarrierChangeHandler` is executed from the `ZkEventThread` and has following drawbacks: * `ZkWatch` events are buffered into a in-memory queue(maintained by ZkClient) and delivered one at a time to ZkClient listener implementations. If the exeuction of a delivered `ZkWatch` event is in progress, then no other `ZkWatch` event will be delivered to the listeners. If `ZkBarrierChangeHandler` is executed from `ZkEventThread`, any increase in processing latency will delay the delivery of other `ZkWatch` events(buffered in in-memory queue of ZkClient). * During session expiration(zkConnection error scenario), buffering all events into `ScheduleAfterDebounceTime` helps us to garbage collect older generation events(to ensure correctness and not execute older generation `ZkWatch` events). Author: Shanthoosh Venkataraman <santhoshvenkat1988@gmail.com> Author: Shanthoosh Venkataraman <svenkataraman@linkedin.com> Reviewers: Jagadish <jagadish@apache.org> Closes apache#526 from shanthoosh/schedule_barrier_change_in_debounce_thread
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ibuted by Xiaoyu Yao.