HADOOP-18592 Sasl connection failure should log remote address #5294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💔 -1 overall
This message was automatically generated. |
cnauroth
approved these changes
Jan 12, 2023
| @@ -736,19 +733,17 @@ public Object run() throws IOException, InterruptedException { | |||
| + UserGroupInformation.getLoginUser().getUserName() + " to " | |||
| + remoteId; | |||
| LOG.warn(msg, ex); | |||
| throw (IOException) new IOException(msg).initCause(ex); | |||
| throw new IOException(msg, ex); | |||
There was a problem hiding this comment.
what about using NetUtils.wrapException which is how we should be reporting this stuff -it includes port info too where specified, and includes links to the wiki pages to help people debug it
There was a problem hiding this comment.
Destination address host:port would be included with this exception. However, yes NetUtils.wrapException is excellent utility and worth using here as it also covers wider variety of exceptions and updates the error msg accordingly.
virajjasani
force-pushed
the
HADOOP-18592-trunk
branch
from
9c1a1a1
to
9adc931
Compare
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
steveloughran
requested changes
Jan 17, 2023
| remoteId.getAddress().getPort(), | ||
| NetUtils.getHostname(), | ||
| 0, | ||
| new IOException(msg, ex)); |
There was a problem hiding this comment.
+1 for the change.
ex is only ever an IOException; we should preserve it so that the type doesn't get lost in the chain.
- change the signature of the method to be
IOException exand then pass it into wrap exception
There was a problem hiding this comment.
Oh yes, it is already of type IOException, should have seen this earlier and would not have got lost in the stacktrace..
Let me make this change, thanks.
There was a problem hiding this comment.
preserve the type of the exception as it goes down. this keeps the information and removes one level of exception wrapping
Agree, updated the PR.
|
💔 -1 overall
This message was automatically generated. |
|
@steveloughran, updated the PR based on your latest review. |
|
@cnauroth @steveloughran Does this look good to go? Thanks |
cnauroth
approved these changes
Jan 24, 2023
There was a problem hiding this comment.
+1
Thank you, @virajjasani . I can do the commit later this week.
|
Thanks for the review @steveloughran |
liuml07
pushed a commit
that referenced
this pull request
Feb 1, 2023
Contributed by Viraj Jasani <vjasani@apache.org> Signed-off-by: Chris Nauroth <cnauroth@apache.org> Signed-off-by: Steve Loughran <stevel@apache.org> Signed-off-by: Mingliang Liu <liuml07@apache.org>
|
@liuml07 , thanks for committing. I got delayed. @virajjasani , thank you for the patch! |
ferdelyi
pushed a commit
to ferdelyi/hadoop
that referenced
this pull request
May 26, 2023
…che#5294) Contributed by Viraj Jasani <vjasani@apache.org> Signed-off-by: Chris Nauroth <cnauroth@apache.org> Signed-off-by: Steve Loughran <stevel@apache.org> Signed-off-by: Mingliang Liu <liuml07@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If Sasl connection fails with some generic error, we miss logging remote server that the client was trying to connect to.
Sample log:
We should log the remote server address.