Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HADOOP-16058 S3A tests to include Terasort #530

Closed

Conversation

steveloughran
Copy link
Contributor

@steveloughran steveloughran commented Feb 28, 2019

HADOOP-16058. Add S3A tests to run terasort for the magic and directory committers.

Contributed by Steve Loughran.

Contains:

MAPREDUCE-7090. BigMapOutput example doesn't work with paths off cluster fs

MAPREDUCE-7091. Terasort on S3A to switch to new committers

MAPREDUCE-7092. MR examples to work better against cloud stores

Bonus feature: prints the results to see which committers are faster in the specific test setup. As that's a function of latency to the store, bandwidth and size of jobs, it's not at all meaningful, just interesting.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 0 Docker mode activated.
-1 patch 7 #530 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help.
Subsystem Report/Notes
GITHUB PR #530
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-530/1/console
Powered by Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 0 Docker mode activated.
-1 patch 6 #530 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help.
Subsystem Report/Notes
GITHUB PR #530
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-530/2/console
Powered by Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

+ MAPREDUCE-7090, MAPREDUCE-7091, MAPREDUCE-7092: set the examples and terasort up for cloudstore testing

Change-Id: I6b0bf12a6355bb8598a2db280c994876d93eb0f2
-Pulls up the code to set up MR clusters for committer tests into a new intermediate base class, one which does not contain the code to actually set up those base clusters.
instead the cluster setup/teradown is done in the @BeforeClass/@afterclass operations of the subclasses, so guaranteeing isolation and a lifecycle which matches those
child classes.

Having done this, it hasn't made the terasort conflict go away; I've concluded now that that's due to some code in Terasort which uses LocalFS to save a partition list. Rather than do dramatic things to Terasort (e.g. add the ability to declare new local paths), I've just serialized the Terasorrt tests -after shrinking down their test size

I haven't reverted the design which pushes cluster setup/teardown into the child classes, even though I'm not sure it is needed, just because it does make clear the lifecycle of class-level data types.

+address checkstyle warnings from the previous patch, where possible.

Change-Id: I781a2090ecbe78ff18a57b87a06b3149024554ea
Change-Id: I92d9704152f46b5bce30d1b16f63364dfcb0b7ee
…nInfo in HADOOP-16093. That'll resurface in other patches of mine, I suspect.

Change-Id: Icfddb3470a32eb71b86f84d176ea2fae52b5adf5
@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 0 Docker mode activated.
-1 patch 7 #530 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help.
Subsystem Report/Notes
GITHUB PR #530
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-530/3/console
Powered by Apache Yetus 0.9.0 http://yetus.apache.org

This message was automatically generated.

shanthoosh pushed a commit to shanthoosh/hadoop that referenced this pull request Oct 15, 2019
**Problem:**
Currently, average build time of samza codebase is 15 to 20 minutes. However, travis has a build idle timeout of 10 minutes and fails the build if the gradle build command doesn't log anything to console
for 10 minutes(occurs when running tests in samza-test module).

Sample travis build failure error:
```
No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself.
Check the details on how to adjust your build configuration on: https://docs.travis-ci.com/user/common-build-problems/#Build-times-out-because-no-output-was-received
```

**Fix:**
Increasing the build idle-wait timeout value to 20 minutes.

Author: Shanthoosh Venkataraman <santhoshvenkat1988@gmail.com>

Reviewers: Daniel Nishimura <dnishimura@linkedin.com>

Closes apache#530 from shanthoosh/increase_travis_build_wait_time
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants