-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HADOOP-18644. Add bswap support for LoongArch #5453
Conversation
💔 -1 overall
This message was automatically generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. +1 from my side.
@steveloughran would you mind to have another reviews. Thanks.
I'm not safe near native code; you will have to find someone else I'm afraid. Not done C/C++ this century |
@iwasakims Would you mind to give another review? Thanks. |
Committed to trunk considering this is compatible changes. Thanks @zhaixiaojuan for your contribution. |
…ibuted by zhaixiaojuan. Reviewed-by: He Xiaoqiao <hexiaoqiao@apache.org>
Description of PR
This PR adds bswap support for LoongArch.
The LoongArch architecture (LoongArch) is an Instruction Set Architecture (ISA) that has a RISC style.
Documentations:
ISA:
https://loongson.github.io/LoongArch-Documentation/LoongArch-Vol1-EN.html
ABI:
https://loongson.github.io/LoongArch-Documentation/LoongArch-ELF-ABI-EN.html
More docs can be found at:
https://loongson.github.io/LoongArch-Documentation/README-EN.html
How was this patch tested?
building and verifying compilation worked.
For code changes:
LICENSE
,LICENSE-binary
,NOTICE-binary
files?