Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HADOOP-18644. Add bswap support for LoongArch #5453

Merged
merged 1 commit into from
Mar 23, 2023

Conversation

zhaixiaojuan
Copy link
Contributor

Description of PR

This PR adds bswap support for LoongArch.

The LoongArch architecture (LoongArch) is an Instruction Set Architecture (ISA) that has a RISC style.
Documentations:
ISA:
https://loongson.github.io/LoongArch-Documentation/LoongArch-Vol1-EN.html
ABI:
https://loongson.github.io/LoongArch-Documentation/LoongArch-ELF-ABI-EN.html
More docs can be found at:
https://loongson.github.io/LoongArch-Documentation/README-EN.html

How was this patch tested?

building and verifying compilation worked.

For code changes:

  • Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
  • Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

@hadoop-yetus
Copy link

💔 -1 overall

Vote Subsystem Runtime Logfile Comment
+0 🆗 reexec 76m 6s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+0 🆗 codespell 0m 0s codespell was not available.
+0 🆗 detsecrets 0m 0s detect-secrets was not available.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-1 ❌ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 💚 mvninstall 39m 56s trunk passed
+1 💚 compile 0m 58s trunk passed
+1 💚 mvnsite 0m 34s trunk passed
+1 💚 shadedclient 60m 41s branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚 mvninstall 0m 22s the patch passed
+1 💚 compile 0m 47s the patch passed
+1 💚 cc 0m 47s the patch passed
+1 💚 golang 0m 47s the patch passed
+1 💚 javac 0m 47s the patch passed
+1 💚 blanks 0m 0s The patch has no blanks issues.
+1 💚 mvnsite 0m 22s the patch passed
+1 💚 shadedclient 19m 4s patch has no errors when building and testing our client artifacts.
_ Other Tests _
+1 💚 unit 2m 53s hadoop-mapreduce-client-nativetask in the patch passed.
+1 💚 asflicense 0m 40s The patch does not generate ASF License warnings.
162m 23s
Subsystem Report/Notes
Docker ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5453/1/artifact/out/Dockerfile
GITHUB PR #5453
Optional Tests dupname asflicense compile cc mvnsite javac unit codespell detsecrets golang
uname Linux e0bf2ce9c8da 4.15.0-200-generic #211-Ubuntu SMP Thu Nov 24 18:16:04 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality dev-support/bin/hadoop.sh
git revision trunk / 026cec3
Default Java Red Hat, Inc.-1.8.0_362-b08
Test Results https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5453/1/testReport/
Max. process+thread count 559 (vs. ulimit of 5500)
modules C: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask U: hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-nativetask
Console output https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5453/1/console
versions git=2.9.5 maven=3.6.3
Powered by Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

Copy link
Contributor

@Hexiaoqiao Hexiaoqiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. +1 from my side.
@steveloughran would you mind to have another reviews. Thanks.

@steveloughran
Copy link
Contributor

I'm not safe near native code; you will have to find someone else I'm afraid. Not done C/C++ this century

@Hexiaoqiao
Copy link
Contributor

@iwasakims Would you mind to give another review? Thanks.

@Hexiaoqiao Hexiaoqiao merged commit 028cde0 into apache:trunk Mar 23, 2023
@Hexiaoqiao
Copy link
Contributor

Committed to trunk considering this is compatible changes. Thanks @zhaixiaojuan for your contribution.

ferdelyi pushed a commit to ferdelyi/hadoop that referenced this pull request May 26, 2023
…ibuted by zhaixiaojuan.

Reviewed-by: He Xiaoqiao <hexiaoqiao@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants