HDFS-16995. Remove unused parameters at NameNodeHttpServer#initWebHdfs #5601

wzhallright · 2023-04-27T07:28:58Z

Description of PR

Parameters of keytab and hostname was not used at intWebHdfs
So maybe is should remove it.
The related code was removed at HADOOP-16354

How was this patch tested?

The current UT can coverage this changes.

For code changes:

ayushtkn

format the code properly post deletions, post that should be fine

ayushtkn · 2023-04-27T10:50:03Z

...ect/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeHttpServer.java

+  public static void initWebHdfs(Configuration conf, HttpServer2 httpServer2,
+                                 String jerseyResourcePackage)
+          throws IOException {


code isn't formatted properly

ayushtkn · 2023-04-27T10:50:23Z

...ect/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeHttpServer.java

+
+    initWebHdfs(conf, httpServer,
        NamenodeWebHdfsMethods.class.getPackage().getName());


this even doesn't look properly formatted

Thanks for review. I will format the code later.

@ayushtkn I've formatted the code, please take a review when you have time.Thanks.

hadoop-yetus · 2023-04-27T13:34:43Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 36s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 1s		codespell was not available.
+0 🆗	detsecrets	0m 1s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s		The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
			_ trunk Compile Tests _
+0 🆗	mvndep	16m 50s		Maven dependency ordering for branch
+1 💚	mvninstall	26m 4s		trunk passed
+1 💚	compile	6m 23s		trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1
+1 💚	compile	5m 49s		trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09
+1 💚	checkstyle	1m 16s		trunk passed
+1 💚	mvnsite	2m 16s		trunk passed
+1 💚	javadoc	1m 48s		trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1
+1 💚	javadoc	2m 37s		trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09
+1 💚	spotbugs	4m 44s		trunk passed
+1 💚	shadedclient	20m 20s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 29s		Maven dependency ordering for patch
+1 💚	mvninstall	1m 52s		the patch passed
+1 💚	compile	5m 53s		the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1
+1 💚	javac	5m 53s		the patch passed
+1 💚	compile	5m 41s		the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09
+1 💚	javac	5m 41s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	1m 5s		the patch passed
+1 💚	mvnsite	2m 0s		the patch passed
+1 💚	javadoc	1m 26s		the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1
+1 💚	javadoc	2m 23s		the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09
+1 💚	spotbugs	4m 38s		the patch passed
+1 💚	shadedclient	20m 38s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	204m 28s		hadoop-hdfs in the patch passed.
-1 ❌	unit	21m 4s	/patch-unit-hadoop-hdfs-project_hadoop-hdfs-rbf.txt	hadoop-hdfs-rbf in the patch passed.
+1 💚	asflicense	0m 51s		The patch does not generate ASF License warnings.
		364m 17s

Reason	Tests
Failed junit tests	hadoop.hdfs.server.federation.router.TestRouterRPCMultipleDestinationMountTableResolver

Subsystem	Report/Notes
Docker	ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5601/1/artifact/out/Dockerfile
GITHUB PR	#5601
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname	Linux 52b36fdf07aa 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3 19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `a1140e5`
Default Java	Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5601/1/testReport/
Max. process+thread count	3654 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5601/1/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2023-04-27T17:27:44Z

💔 -1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 36s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s		The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
			_ trunk Compile Tests _
+0 🆗	mvndep	16m 22s		Maven dependency ordering for branch
+1 💚	mvninstall	26m 10s		trunk passed
+1 💚	compile	6m 1s		trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1
+1 💚	compile	5m 45s		trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09
+1 💚	checkstyle	1m 17s		trunk passed
+1 💚	mvnsite	2m 15s		trunk passed
+1 💚	javadoc	1m 50s		trunk passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1
+1 💚	javadoc	2m 31s		trunk passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09
+1 💚	spotbugs	4m 46s		trunk passed
+1 💚	shadedclient	20m 40s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+0 🆗	mvndep	0m 29s		Maven dependency ordering for patch
+1 💚	mvninstall	1m 49s		the patch passed
+1 💚	compile	6m 2s		the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1
+1 💚	javac	6m 2s		the patch passed
+1 💚	compile	5m 38s		the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09
+1 💚	javac	5m 38s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	1m 4s		the patch passed
+1 💚	mvnsite	1m 58s		the patch passed
+1 💚	javadoc	1m 26s		the patch passed with JDK Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1
+1 💚	javadoc	2m 19s		the patch passed with JDK Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09
+1 💚	spotbugs	4m 37s		the patch passed
+1 💚	shadedclient	20m 46s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
-1 ❌	unit	206m 29s	/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt	hadoop-hdfs in the patch passed.
+1 💚	unit	20m 57s		hadoop-hdfs-rbf in the patch passed.
+1 💚	asflicense	0m 48s		The patch does not generate ASF License warnings.
		365m 45s

Reason	Tests
Failed junit tests	hadoop.hdfs.server.datanode.TestDirectoryScanner

Subsystem	Report/Notes
Docker	ClientAPI=1.42 ServerAPI=1.42 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5601/2/artifact/out/Dockerfile
GITHUB PR	#5601
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell detsecrets
uname	Linux 0a265c57cbc5 4.15.0-206-generic #217-Ubuntu SMP Fri Feb 3 19:10:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `fcf37cb`
Default Java	Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.18+10-post-Ubuntu-0ubuntu120.04.1 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_362-8u362-ga-0ubuntu1~20.04.1-b09
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5601/2/testReport/
Max. process+thread count	3362 (vs. ulimit of 5500)
modules	C: hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-rbf U: hadoop-hdfs-project
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-5601/2/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

ayushtkn

Changes LGTM

HDFS-16995. Remove unused parameters at NameNodeHttpServer#initWebHdfs

a1140e5

ayushtkn reviewed Apr 27, 2023

View reviewed changes

format code

fcf37cb

ayushtkn approved these changes Apr 27, 2023

View reviewed changes

ayushtkn merged commit 0e63152 into apache:trunk Apr 27, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HDFS-16995. Remove unused parameters at NameNodeHttpServer#initWebHdfs #5601

HDFS-16995. Remove unused parameters at NameNodeHttpServer#initWebHdfs #5601

wzhallright commented Apr 27, 2023

ayushtkn left a comment

ayushtkn Apr 27, 2023

ayushtkn Apr 27, 2023

wzhallright Apr 27, 2023

wzhallright Apr 27, 2023

hadoop-yetus commented Apr 27, 2023

hadoop-yetus commented Apr 27, 2023

ayushtkn left a comment


		initWebHdfs(conf, httpServer,
		NamenodeWebHdfsMethods.class.getPackage().getName());

HDFS-16995. Remove unused parameters at NameNodeHttpServer#initWebHdfs #5601

HDFS-16995. Remove unused parameters at NameNodeHttpServer#initWebHdfs #5601

Conversation

wzhallright commented Apr 27, 2023

Description of PR

How was this patch tested?

For code changes:

ayushtkn left a comment

Choose a reason for hiding this comment

ayushtkn Apr 27, 2023

Choose a reason for hiding this comment

ayushtkn Apr 27, 2023

Choose a reason for hiding this comment

wzhallright Apr 27, 2023

Choose a reason for hiding this comment

wzhallright Apr 27, 2023

Choose a reason for hiding this comment

hadoop-yetus commented Apr 27, 2023

hadoop-yetus commented Apr 27, 2023

ayushtkn left a comment

Choose a reason for hiding this comment