-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HDFS-16995. Remove unused parameters at NameNodeHttpServer#initWebHdfs #5601
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
format the code properly post deletions, post that should be fine
public static void initWebHdfs(Configuration conf, HttpServer2 httpServer2, | ||
String jerseyResourcePackage) | ||
throws IOException { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code isn't formatted properly
|
||
initWebHdfs(conf, httpServer, | ||
NamenodeWebHdfsMethods.class.getPackage().getName()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this even doesn't look properly formatted
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for review. I will format the code later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ayushtkn I've formatted the code, please take a review when you have time.Thanks.
💔 -1 overall
This message was automatically generated. |
💔 -1 overall
This message was automatically generated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM
Description of PR
Parameters of keytab and hostname was not used at
intWebHdfs
So maybe is should remove it.
The related code was removed at HADOOP-16354
How was this patch tested?
The current UT can coverage this changes.
For code changes: