HDFS-17043. HttpFS implementation for getAllErasureCodingPolicies #5734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎊 +1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
slfan1989
reviewed
Jun 12, 2023
| Map<String, String> params = new HashMap<>(); | ||
| params.put(OP_PARAM, Operation.GETECPOLICIES.toString()); | ||
| HttpURLConnection conn = | ||
| getConnection(Operation.GETECPOLICIES.getMethod(), params, new Path(getUri() |
There was a problem hiding this comment.
expend, getUri().toString() uses variables, which may make the code clearer
There was a problem hiding this comment.
Thanks for your suggestion, I'll make the required code changes promptly
|
LGTM. |
|
🎊 +1 overall
This message was automatically generated. |
|
@ayushtkn Would you mind to take another reviews? Thanks. |
slfan1989
approved these changes
Jun 14, 2023
ayushtkn
reviewed
Jun 14, 2023
| params.put(OP_PARAM, Operation.GETECPOLICIES.toString()); | ||
| Path path = new Path(getUri().toString(), "/"); | ||
| HttpURLConnection conn = | ||
| getConnection(Operation.GETECPOLICIES.getMethod(), params, path, true); |
There was a problem hiding this comment.
do we need this makeQualified to be true here? we hardcoded / itself here, getAllStoragePolicies seems to pass false as well
There was a problem hiding this comment.
Thank you for your valuable suggestion. I sincerely appreciate it and will promptly implement the required adjustments to the code!
| WebHdfsFileSystem webHdfsFileSystem = (WebHdfsFileSystem) httpFs; | ||
| diffErasureCodingPolicies = webHdfsFileSystem.getAllErasureCodingPolicies(); | ||
| } else { | ||
| Assert.fail(fs.getClass().getSimpleName() + " doesn't support getSnapshotDiff"); |
|
🎊 +1 overall
This message was automatically generated. |
|
@ayushtkn @slfan1989 Thank you for your assistance in reviewing the code! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: HDFS-17043. HttpFS implementation for getAllErasureCodingPolicies