HDFS-17194. Enhance the log message for striped block recovery #6094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
The failed unit test seems unrelated to the change. Hi Sirs @Hexiaoqiao @ayushtkn @ZanderXu Could you please help me review this minor changes when you have free time ? Thanks a lot~ |
goiri
reviewed
Sep 19, 2023
| @@ -427,26 +426,41 @@ protected void recover() throws IOException { | |||
| // simply choose the one with larger length. | |||
| // TODO: better usage of redundant replicas | |||
| syncBlocks.put(blockId, new BlockRecord(id, proxyDN, info)); | |||
| } else { | |||
| if (LOG.isDebugEnabled()) { | |||
There was a problem hiding this comment.
No need to run isDebugEnabled() if you use {}
There was a problem hiding this comment.
Thanks @goiri help reivew and suggestions.
I will update later PR.
| InterDatanodeProtocol.LOG.warn("Failed to recover block (block=" | ||
| + block + ", datanode=" + id + ")", e); | ||
| InterDatanodeProtocol.LOG.warn("Failed to recover block (block={}, internalBlk={}, " + | ||
| "datanode={})", block, internalBlk, id, e); | ||
| } | ||
| } | ||
| checkLocations(syncBlocks.size()); | ||
|
|
||
| final long safeLength = getSafeLength(syncBlocks); | ||
| if (LOG.isDebugEnabled()) { |
There was a problem hiding this comment.
ok, I will update later it.
|
The PR has been updated. Hi @goiri please help review this changes again when you have free time. Thanks a lot~ |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
haiyang1987
force-pushed
the
HDFS-17194
branch
from
beb6ed6
to
4eedf9c
Compare
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
The failed unit test seems unrelated to the change. Hi Sirs @goiri @Hexiaoqiao @ZanderXu please help me review this changes again when you have free time . Thanks a lot~ |
goiri
approved these changes
Sep 25, 2023
ayushtkn
approved these changes
Sep 27, 2023
There was a problem hiding this comment.
@goiri I am bit curious on removing the isDebugEnabled checks.
Like here
- if (LOG.isDebugEnabled()) {
- LOG.debug("syncBlock replicaInfo: block=" + block +
- ", from datanode " + r.id + ", receivedState=" + rState.name() +
- ", receivedLength=" + r.rInfo.getNumBytes() +
- ", bestState=FINALIZED, finalizedLength=" + finalizedLength);
- }
+ LOG.debug("syncBlock replicaInfo: block={}, from datanode {}, receivedState={}, " +
+ "receivedLength={}, bestState=FINALIZED, finalizedLength={}",
+ block, r.id, rState.name(), r.rInfo.getNumBytes(), finalizedLength);
}
There are method calls like r.rInfo.getNumBytes() these will be called & resolved irrespective whether debug logging is enabled or not, right? Even the concat on will be performed before passing to LOG.debug, Wouldn't it be better to have a isDebug gaurd where there are method calls or the log message is big & we use concat.
I am good with current as well
Thanks @ayushtkn for your review. So here we maybe need to update the code and add |
jiajunmao
pushed a commit
to jiajunmao/hadoop-MLEC
that referenced
this pull request
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
https://issues.apache.org/jira/browse/HDFS-17194
In order to convenient troubleshoot problems, consider add internalBlk information to the RecoveryTaskStriped#recover log message and optimize some log output