-
Notifications
You must be signed in to change notification settings - Fork 8.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HDFS-17343. Revert "HDFS-16016. BPServiceActor to provide new thread to handle IBR (#2998)" #6457
Conversation
apache#2998)" This reverts commit c1bf3cb
@slfan1989 |
@slfan1989 Thank you for creating the revert PR. Considering HDFS-16016 has already been released in 3.3.6, it might be better to create a new JIRA to manage this revert PR, rather than reopening HDFS-16016. |
@yuanboliu HDFS-17129 was caused by HDFS-16016. Please read the discussion in #6244. |
@tasanuma Thanks for your suggestion! I will create a new JIRA to complete the revert and update HDFS-16016 back. |
@tasanuma @slfan1989 |
@yuanboliu |
💔 -1 overall
This message was automatically generated. |
I agree with @tasanuma's idea. |
🎊 +1 overall
This message was automatically generated. |
@tasanuma @Hexiaoqiao @virajjasani Can you help review this PR? Thank you very much! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1. Thanks for working on this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. +1 from my side.
Thanks for working on the revert to unblock 3.4.0! |
@ayushtkn Can you help review this PR? Thank you very much! |
Revert doesn't need approval, just revert and remove 3.4.0 from the fix version in the original ticket and mention it has been reverted as part of this ticket for this reason |
Creating another ticket is my request, as I commented here. We also want to revert HDFS-16016 from branch-3.3, but we cannot remove 3.3.6 from the fix version. So, if it has been released once or more, I would request another JIRA for reverting it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep, the released versions shouldn't be removed, just the unreleased versions should be removed from the fix version & just link this ticket & put a comment on the original ticket for posterity "that this ticket got reverted as part of X ticket"
& We are all set
@tasanuma @Hexiaoqiao @ayushtkn @virajjasani Thanks for reviewing the code! merged into trunk. |
#2998)" (#6457) Contributed by Shilun Fan. This reverts commit c1bf3cb. Reviewed-by: Takanobu Asanuma <tasanuma@apache.org> Reviewed-by: He Xiaoqiao <hexiaoqiao@apache.org> Reviewed-by: Ayush Saxena <ayushsaxena@apache.org> Reviewed-by: Viraj Jasani <vjasani@apache.org> Signed-off-by: Shilun Fan <slfan1989@apache.org>
#2998)" (#6457) Contributed by Shilun Fan. This reverts commit c1bf3cb. Reviewed-by: Takanobu Asanuma <tasanuma@apache.org> Reviewed-by: He Xiaoqiao <hexiaoqiao@apache.org> Reviewed-by: Ayush Saxena <ayushsaxena@apache.org> Reviewed-by: Viraj Jasani <vjasani@apache.org> Signed-off-by: Shilun Fan <slfan1989@apache.org>
apache#2998)" (apache#6457) Contributed by Shilun Fan. This reverts commit c1bf3cb. Reviewed-by: Takanobu Asanuma <tasanuma@apache.org> Reviewed-by: He Xiaoqiao <hexiaoqiao@apache.org> Reviewed-by: Ayush Saxena <ayushsaxena@apache.org> Reviewed-by: Viraj Jasani <vjasani@apache.org> Signed-off-by: Shilun Fan <slfan1989@apache.org>
Description of PR
JIRA: HDFS-17343. Revert HDFS-16016. BPServiceActor to provide new thread to handle IBR.
Revert "HDFS-16016. BPServiceActor to provide new thread to handle IBR (#2998)"
This reverts commit c1bf3cb
How was this patch tested?
For code changes:
LICENSE
,LICENSE-binary
,NOTICE-binary
files?