HBASE-23180 hbck2 testing tool #47
Conversation
jatsakthi
requested review from
busbey,
saintstack,
petersomogyi and
wchevreuil
|
Refer to this link for build results (access rights to CI server needed): |
jatsakthi
force-pushed
the
HBASE-23180
branch
from
3f523e5
to
104e4d3
Compare
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
|
|
||
| # Replace the passed parameters in here [starting from --working-dir] with appropriate values | ||
| ./dev-support/testingtool/hbck2_test.sh --hbck2 "${SELF}/../../${hbase_hbck2_jar}" \ | ||
| --single-process --working-dir /Users/sakthi/test/hbck2-testing-tool/output/hbck2 \ |
There was a problem hiding this comment.
Can you change the directories here?
| } | ||
| } | ||
|
|
||
|
|
| private void deleteRegionFromMeta(String tname) throws IOException, InterruptedException { | ||
| TableName tn = TableName.valueOf(tname); | ||
| try (Connection connection = ConnectionFactory.createConnection(conf)) { | ||
| Table MetaTable = connection.getTable(TableName.valueOf("hbase:meta")); |
There was a problem hiding this comment.
nit: s/MetaTable/metaTable/
| Thread.sleep(500); | ||
|
|
||
| ris = MetaTableAccessor.getTableRegions(connection, tn); | ||
| System.out.println(String.format("Current Regions of the table " + tn.getNameAsString() |
There was a problem hiding this comment.
You might not need to use String.format in this case.
ris is a List, do you want to print it out?
|
Thanks for your comments @petersomogyi . I have updated the PR. |
|
@saintstack , @busbey , @wchevreuil can I get any of your reviews as well here? |
|
@petersomogyi can I get your +1 here? |
| */ | ||
| package org.apache.hbase; | ||
|
|
||
| import static java.lang.System.exit; |
There was a problem hiding this comment.
nit: we only use this once, just call System.exit there.
| tool.deleteRegionFromMeta(tableName); | ||
| } | ||
| else { | ||
| System.out.println("ERROR: Unknown option passed."); |
There was a problem hiding this comment.
Took care of these as well.
| } | ||
|
|
||
| private static void printUsageAndExit() { | ||
| System.out.println("hbckActions <options>"); |
| echo "ERROR: Instead of finding 1000 rows, we found ${assign_rowcount}." | ||
| exit 2 | ||
| else | ||
| echo "SUCCESS: deleteRegionInMeta succedeed" |
There was a problem hiding this comment.
nit: "SUCCESS: deleteRegionInMeta recovery process succeeded"
jatsakthi
force-pushed
the
HBASE-23180
branch
from
3b1ab3a
to
2c039af
Compare
|
Thanks for your reviews @busbey . I have addressed them and updated the pr. |
This adds a new tool that spins up a hbase on hadoop minicluster and mimicks actions of hbck2 to verify it's functionalities
jatsakthi
force-pushed
the
HBASE-23180
branch
from
2c039af
to
95633e6
Compare
|
How does the PR look now, @busbey ? |
|
Looks great! Thanks for getting this done. |
|
Thanks for your reviews, Peter & Sean. Let me get this in. |
This adds a new tool that spins up a hbase on hadoop minicluster and
mimicks actions of hbck2 to verify it's functionalities