HBASE-28191 Meta browser can happen NPE when server or targetServer o…

…f region is null (#5512) Signed-off-by: Duo Zhang <zhangduo@apache.org>
apache · Nov 10, 2023 · 218cb08 · 218cb08
1 parent b433282
commit 218cb08
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/hbase-server/src/main/resources/hbase-webapps/master/table.jsp b/hbase-server/src/main/resources/hbase-webapps/master/table.jsp
@@ -504,12 +504,13 @@
       final RegionInfo regionInfo = regionReplicaInfo.getRegionInfo();
       final ServerName serverName = regionReplicaInfo.getServerName();
       final RegionState.State regionState = regionReplicaInfo.getRegionState();
-      final int rsPort = master.getRegionServerInfoPort(serverName);
 
       final long seqNum = regionReplicaInfo.getSeqNum();
 
       final String regionSpanFormat = "<span title=" + HConstants.CATALOG_FAMILY_STR + ":%s>%s</span>";
-      final String targetServerName = regionReplicaInfo.getTargetServerName().toString();
+      final String targetServerName = regionReplicaInfo.getTargetServerName() != null
+        ? regionReplicaInfo.getTargetServerName().toString()
+        : "";
       final Map<String, RegionInfo> mergeRegions = regionReplicaInfo.getMergeRegionInfo();
       final String mergeRegionNames = (mergeRegions == null) ? "" :
         mergeRegions.entrySet().stream()
@@ -527,7 +528,7 @@
           <td title="endKey"><%= endKeyDisplay %></td>
           <td title="replicaId"><%= replicaIdDisplay %></td>
           <td title="regionState"><%= regionStateDisplay %></td>
-          <td title="<%= serverColumnName + "," + startCodeColumnName %>"><%= buildRegionServerLink(serverName, rsPort, regionInfo, regionState) %></td>
+          <td title="<%= serverColumnName + "," + startCodeColumnName %>"><%= serverName != null ? buildRegionServerLink(serverName, master.getRegionServerInfoPort(serverName), regionInfo, regionState) : "" %></td>
           <td title="<%= seqNumColumnName %>"><%= seqNum %></td>
           <td title="<%= serverNameColumnName %>"><%= targetServerName %></td>
           <td><%= mergeRegionNames %></td>