fix mocks in broken tests

apache · Mar 14, 2023 · 37591b1 · 37591b1
1 parent 9847b38
commit 37591b1
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 9 deletions.
diff --git a/hbase-client/src/main/java/org/apache/hadoop/hbase/client/RpcRetryingCallerFactory.java b/hbase-client/src/main/java/org/apache/hadoop/hbase/client/RpcRetryingCallerFactory.java
@@ -100,13 +100,9 @@ public static RpcRetryingCallerFactory instantiate(Configuration configuration,
     if (rpcCallerFactoryClazz.equals(clazzName)) {
       factory = new RpcRetryingCallerFactory(configuration, connectionConf, interceptor, metrics);
     } else {
-      try {
-        factory = ReflectionUtils.instantiateWithCustomCtor(rpcCallerFactoryClazz,
-          new Class[] { Configuration.class }, new Object[] { configuration, connectionConf });
-      } catch (UnsupportedOperationException e) {
-        factory = ReflectionUtils.instantiateWithCustomCtor(rpcCallerFactoryClazz,
-          new Class[] { Configuration.class }, new Object[] { configuration });
-      }
+      factory = ReflectionUtils.instantiateWithCustomCtor(rpcCallerFactoryClazz,
+        new Class[] { Configuration.class, ConnectionConfiguration.class },
+        new Object[] { configuration, connectionConf });
     }
     return factory;
   }

diff --git a/hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestClientScanner.java b/hbase-client/src/test/java/org/apache/hadoop/hbase/client/TestClientScanner.java
@@ -89,6 +89,7 @@ public void setup() throws IOException {
     conf = new Configuration();
     connectionConfig = new ConnectionConfiguration(conf);
     Mockito.when(clusterConn.getConfiguration()).thenReturn(conf);
+    Mockito.when(clusterConn.getConnectionConfiguration()).thenReturn(connectionConfig);
   }
 
   @After

diff --git a/hbase-server/src/test/java/org/apache/hadoop/hbase/client/HConnectionTestingUtility.java b/hbase-server/src/test/java/org/apache/hadoop/hbase/client/HConnectionTestingUtility.java
@@ -129,7 +129,7 @@ public static ClusterConnection getMockedConnectionAndDecorate(final Configurati
       RpcControllerFactory.instantiate(conf));
     Mockito.when(c.getAsyncProcess()).thenReturn(asyncProcess);
     Mockito.when(c.getNewRpcRetryingCallerFactory(conf))
-      .thenReturn(RpcRetryingCallerFactory.instantiate(conf, c.getConnectionConfiguration(),
+      .thenReturn(RpcRetryingCallerFactory.instantiate(conf, connectionConfiguration,
         RetryingCallerInterceptorFactory.NO_OP_INTERCEPTOR, null, null));
     Mockito.when(c.getRpcControllerFactory()).thenReturn(Mockito.mock(RpcControllerFactory.class));
     Table t = Mockito.mock(Table.class);

diff --git a/hbase-server/src/test/java/org/apache/hadoop/hbase/quotas/TestSpaceQuotaOnBulkLoad.java b/hbase-server/src/test/java/org/apache/hadoop/hbase/quotas/TestSpaceQuotaOnBulkLoad.java
@@ -99,7 +99,7 @@ public void testNoBulkLoadsWithNoWrites() throws Exception {
 
     // The table is now in violation. Try to do a bulk load
     ClientServiceCallable<Void> callable = helper.generateFileToLoad(tableName, 1, 50);
-    ClusterConnection conn = (ClusterConnection) TEST_UTIL.getConfiguration();
+    ClusterConnection conn = (ClusterConnection) TEST_UTIL.getConnection();
     RpcRetryingCallerFactory factory =
       new RpcRetryingCallerFactory(TEST_UTIL.getConfiguration(), conn.getConnectionConfiguration());
     RpcRetryingCaller<Void> caller = factory.<Void> newCaller();