-
Notifications
You must be signed in to change notification settings - Fork 3.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
HBASE-25873 Refactor and cleanup the code for CostFunction
- Loading branch information
Showing
18 changed files
with
229 additions
and
202 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
104 changes: 104 additions & 0 deletions
104
.../main/java/org/apache/hadoop/hbase/master/balancer/RegionReplicaGroupingCostFunction.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,104 @@ | ||
| /** | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package org.apache.hadoop.hbase.master.balancer; | ||
|
|
||
| import java.util.Arrays; | ||
| import org.apache.yetus.audience.InterfaceAudience; | ||
|
|
||
| /** | ||
| * A cost function for region replicas. We give a high cost for hosting replicas of the same region | ||
| * in the same server, host or rack. We do not prevent the case though, since if numReplicas > | ||
| * numRegionServers, we still want to keep the replica open. | ||
| */ | ||
| @InterfaceAudience.Private | ||
| abstract class RegionReplicaGroupingCostFunction extends CostFunction { | ||
|
|
||
| protected long maxCost = 0; | ||
| protected long[] costsPerGroup; // group is either server, host or rack | ||
|
|
||
| @Override | ||
| final void prepare(BalancerClusterState cluster) { | ||
| super.prepare(cluster); | ||
| if (!isNeeded()) { | ||
| return; | ||
| } | ||
| loadCosts(); | ||
| } | ||
|
|
||
| protected abstract void loadCosts(); | ||
|
|
||
| protected final long getMaxCost(BalancerClusterState cluster) { | ||
| // max cost is the case where every region replica is hosted together regardless of host | ||
| int[] primariesOfRegions = new int[cluster.numRegions]; | ||
| System.arraycopy(cluster.regionIndexToPrimaryIndex, 0, primariesOfRegions, 0, | ||
| cluster.regions.length); | ||
|
|
||
| Arrays.sort(primariesOfRegions); | ||
|
|
||
| // compute numReplicas from the sorted array | ||
| return costPerGroup(primariesOfRegions); | ||
| } | ||
|
|
||
| @Override | ||
| boolean isNeeded() { | ||
| return cluster.hasRegionReplicas; | ||
| } | ||
|
|
||
| @Override | ||
| protected double cost() { | ||
| if (maxCost <= 0) { | ||
| return 0; | ||
| } | ||
|
|
||
| long totalCost = 0; | ||
| for (int i = 0; i < costsPerGroup.length; i++) { | ||
| totalCost += costsPerGroup[i]; | ||
| } | ||
| return scale(0, maxCost, totalCost); | ||
| } | ||
|
|
||
| /** | ||
| * For each primary region, it computes the total number of replicas in the array (numReplicas) | ||
| * and returns a sum of numReplicas-1 squared. For example, if the server hosts regions a, b, c, | ||
| * d, e, f where a and b are same replicas, and c,d,e are same replicas, it returns (2-1) * (2-1) | ||
| * + (3-1) * (3-1) + (1-1) * (1-1). | ||
| * @param primariesOfRegions a sorted array of primary regions ids for the regions hosted | ||
| * @return a sum of numReplicas-1 squared for each primary region in the group. | ||
| */ | ||
| protected final long costPerGroup(int[] primariesOfRegions) { | ||
| long cost = 0; | ||
| int currentPrimary = -1; | ||
| int currentPrimaryIndex = -1; | ||
| // primariesOfRegions is a sorted array of primary ids of regions. Replicas of regions | ||
| // sharing the same primary will have consecutive numbers in the array. | ||
| for (int j = 0; j <= primariesOfRegions.length; j++) { | ||
| int primary = j < primariesOfRegions.length ? primariesOfRegions[j] : -1; | ||
| if (primary != currentPrimary) { // we see a new primary | ||
| int numReplicas = j - currentPrimaryIndex; | ||
| // square the cost | ||
| if (numReplicas > 1) { // means consecutive primaries, indicating co-location | ||
| cost += (numReplicas - 1) * (numReplicas - 1); | ||
| } | ||
| currentPrimary = primary; | ||
| currentPrimaryIndex = j; | ||
| } | ||
| } | ||
|
|
||
| return cost; | ||
| } | ||
| } |
Oops, something went wrong.