Adjust log level based on interest

apache · Nov 6, 2021 · 81e68c4 · 81e68c4
1 parent adc2f3d
commit 81e68c4
Showing 1 changed file with 12 additions and 1 deletion.
diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/DefaultHeapMemoryTuner.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/DefaultHeapMemoryTuner.java
@@ -352,7 +352,18 @@ private StepDirection getTuneDirection(TunerContext context) {
         }
       }
     }
-    LOG.info(tunerLog.toString());
+    // Log NEUTRAL decisions at DEBUG, because they are the most frequent and not that interesting.
+    // Log other decisions at INFO because they are making meaningful operational changes.
+    switch (newTuneDirection) {
+      case NEUTRAL:
+        if (LOG.isDebugEnabled()) {
+          LOG.debug(tunerLog.toString());
+        }
+        break;
+      default:
+        LOG.info(tunerLog.toString());
+        break;
+    }
     return newTuneDirection;
   }