Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
HBASE-21890 Use execute instead of submit to submit a task in RemoteP…
…rocedureDispatcher Signed-off-by: Michael Stack <stack@apache.org>
- Loading branch information
Showing
3 changed files
with
177 additions
and
44 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
141 changes: 141 additions & 0 deletions
141
...apache/hadoop/hbase/procedure2/TestRemoteProcedureDispatcherUncaughtExceptionHandler.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,141 @@ | ||
| /** | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package org.apache.hadoop.hbase.procedure2; | ||
|
|
||
| import java.lang.Thread.UncaughtExceptionHandler; | ||
| import java.util.Set; | ||
| import java.util.concurrent.TimeUnit; | ||
| import org.apache.hadoop.hbase.HBaseClassTestRule; | ||
| import org.apache.hadoop.hbase.HBaseCommonTestingUtility; | ||
| import org.apache.hadoop.hbase.testclassification.MasterTests; | ||
| import org.apache.hadoop.hbase.testclassification.SmallTests; | ||
| import org.junit.After; | ||
| import org.junit.Before; | ||
| import org.junit.ClassRule; | ||
| import org.junit.Rule; | ||
| import org.junit.Test; | ||
| import org.junit.experimental.categories.Category; | ||
| import org.junit.rules.ExpectedException; | ||
|
|
||
| /** | ||
| * Make sure the {@link UncaughtExceptionHandler} will be called when there are unchecked exceptions | ||
| * thrown in the task. | ||
| * <p/> | ||
| * See HBASE-21875 and HBASE-21890 for more details. | ||
| */ | ||
| @Category({ MasterTests.class, SmallTests.class }) | ||
| public class TestRemoteProcedureDispatcherUncaughtExceptionHandler { | ||
|
|
||
| private static HBaseCommonTestingUtility UTIL = new HBaseCommonTestingUtility(); | ||
|
|
||
| @ClassRule | ||
| public static final HBaseClassTestRule CLASS_RULE = | ||
| HBaseClassTestRule.forClass(TestRemoteProcedureDispatcherUncaughtExceptionHandler.class); | ||
|
|
||
| private static final class ExceptionHandler implements UncaughtExceptionHandler { | ||
|
|
||
| private Throwable error; | ||
|
|
||
| @Override | ||
| public synchronized void uncaughtException(Thread t, Throwable e) { | ||
| this.error = e; | ||
| notifyAll(); | ||
| } | ||
|
|
||
| public synchronized void get() throws Throwable { | ||
| while (error == null) { | ||
| wait(); | ||
| } | ||
| throw error; | ||
| } | ||
| } | ||
|
|
||
| private static final class Dispatcher extends RemoteProcedureDispatcher<Void, Integer> { | ||
|
|
||
| private final UncaughtExceptionHandler handler; | ||
|
|
||
| public Dispatcher(UncaughtExceptionHandler handler) { | ||
| super(UTIL.getConfiguration()); | ||
| this.handler = handler; | ||
| } | ||
|
|
||
| @Override | ||
| protected UncaughtExceptionHandler getUncaughtExceptionHandler() { | ||
| return handler; | ||
| } | ||
|
|
||
| @Override | ||
| protected void remoteDispatch(Integer key, Set<RemoteProcedure> operations) { | ||
| } | ||
|
|
||
| @Override | ||
| protected void abortPendingOperations(Integer key, Set<RemoteProcedure> operations) { | ||
| } | ||
| } | ||
|
|
||
| @Rule | ||
| public ExpectedException thrown = ExpectedException.none(); | ||
|
|
||
| private ExceptionHandler handler; | ||
|
|
||
| private Dispatcher dispatcher; | ||
|
|
||
| @Before | ||
| public void setUp() { | ||
| handler = new ExceptionHandler(); | ||
| dispatcher = new Dispatcher(handler); | ||
| dispatcher.start(); | ||
| } | ||
|
|
||
| @After | ||
| public void tearDown() { | ||
| dispatcher.stop(); | ||
| dispatcher = null; | ||
| handler = null; | ||
| } | ||
|
|
||
| @Test | ||
| public void testSubmit() throws Throwable { | ||
| String message = "inject error"; | ||
| thrown.expect(RuntimeException.class); | ||
| thrown.expectMessage(message); | ||
| dispatcher.submitTask(new Runnable() { | ||
|
|
||
| @Override | ||
| public void run() { | ||
| throw new RuntimeException(message); | ||
| } | ||
| }); | ||
| handler.get(); | ||
| } | ||
|
|
||
| @Test | ||
| public void testDelayedSubmit() throws Throwable { | ||
| String message = "inject error"; | ||
| thrown.expect(RuntimeException.class); | ||
| thrown.expectMessage(message); | ||
| dispatcher.submitTask(new Runnable() { | ||
|
|
||
| @Override | ||
| public void run() { | ||
| throw new RuntimeException(message); | ||
| } | ||
| }, 100, TimeUnit.MILLISECONDS); | ||
| handler.get(); | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters