HBASE-23753 Update of errorprone generated failures #1103
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hbase-client/src/main/java/org/apache/hadoop/hbase/HRegionInfo.java hbase-server/src/main/java/org/apache/hadoop/hbase/executor/EventHandler.java Complains about mismatch in types when Compare. Implement Compare in base Interface. hbase-client/src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufUtil.java Complains pbs never return null. hbase-server/src/test/java/org/apache/hadoop/hbase/replication/regionserver/TestReplicationSinkManager.java Needed redo because errorprone complains can't mock Service from guava. hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionReplicasWithRestartScenarios.java hbase-server/src/test/java/org/apache/hadoop/hbase/security/access/TestSnapshotScannerHDFSAclController.java Unrelated...adding one-liner debug statements chasing other test failures.
bharathv
approved these changes
Jan 29, 2020
| @@ -18,6 +18,7 @@ | |||
| */ | |||
| package org.apache.hadoop.hbase.executor; | |||
|
|
|||
| import java.awt.*; | |||
There was a problem hiding this comment.
nit: looks incorrect? Might also run into checkstyle issue with start import.
There was a problem hiding this comment.
Mistake. Thanks.
| if(getPriority() != eh.getPriority()) { | ||
| return (getPriority() < eh.getPriority()) ? -1 : 1; | ||
| public int compareTo(EventHandler o) { | ||
| if(getPriority() != o.getPriority()) { |
There was a problem hiding this comment.
nit: include a null check in the beginning for o?
| when(replicationEndpoint.getRegionServers()) | ||
| .thenReturn(serverNames); | ||
|
|
||
| this.replicationEndpoint.setRegionServers(serverNames); |
There was a problem hiding this comment.
nit: I guess 'this' is redundant in multiple places.
virajjasani
approved these changes
Jan 29, 2020
|
💔 -1 overall
This message was automatically generated. |
|
Closing. This was merged to master and branch-2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hbase-client/src/main/java/org/apache/hadoop/hbase/HRegionInfo.java
hbase-server/src/main/java/org/apache/hadoop/hbase/executor/EventHandler.java
Complains about mismatch in types when Compare. Implement Compare in
base Interface.
hbase-client/src/main/java/org/apache/hadoop/hbase/protobuf/ProtobufUtil.java
Complains pbs never return null.
hbase-server/src/test/java/org/apache/hadoop/hbase/replication/regionserver/TestReplicationSinkManager.java
Needed redo because errorprone complains can't mock Service from guava.
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionReplicasWithRestartScenarios.java
hbase-server/src/test/java/org/apache/hadoop/hbase/security/access/TestSnapshotScannerHDFSAclController.java
Unrelated...adding one-liner debug statements chasing other test
failures.