HBASE-23782 We still reference the hard coded meta descriptor in some… #1115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💔 -1 overall
This message was automatically generated. |
virajjasani
approved these changes
Feb 2, 2020
| @@ -153,7 +148,6 @@ public FSTableDescriptors(final Configuration conf, final FileSystem fs, | |||
| updateTableDescriptor(td); | |||
| } | |||
| } | |||
| this.metaTableDescriptor = td; | |||
There was a problem hiding this comment.
Looks like this constructor can have just these initializations:
this.fs = fs;
this.rootdir = rootdir;
this.fsreadonly = fsreadonly;
this.usecache = usecache;
… places when listing table descriptors
|
🎊 +1 overall
This message was automatically generated. |
asfgit
pushed a commit
that referenced
this pull request
Feb 3, 2020
… places when listing table descriptors (#1115) Signed-off-by: Viraj Jasani <vjasani@apache.org>
saintstack
reviewed
Feb 3, 2020
| assertEquals(get, listByNs); | ||
| return get; | ||
| } | ||
|
|
bharathv
reviewed
Feb 3, 2020
| } catch (TableInfoMissingException e) { | ||
| TableDescriptorBuilder builder = createMetaTableDescriptorBuilder(conf); | ||
| if (metaObserver != null) { | ||
| metaObserver.apply(builder); |
There was a problem hiding this comment.
Just FYI, this change broke the error prone build.
https://builds.apache.org/job/HBase%20Nightly/job/master/1618/artifact/output-general/patch-compile-root.txt
[ERROR] /home/jenkins/jenkins-slave/workspace/HBase_Nightly_master@2/component/hbase-server/src/main/java/org/apache/hadoop/hbase/util/FSTableDescriptors.java:[147,28] error: [ReturnValueIgnored] Return value of this method must be used
(see https://errorprone.info/bugpattern/ReturnValueIgnored)
Did you mean to remove this line?
[INFO] 1 error
You can reproduce with "mvn clean compile -DskipTests -PerrorProne"
|
Pushed an addendum to fix the error prone problem. |
bharathv
added a commit
to bharathv/hbase
that referenced
this pull request
Feb 5, 2020
… in some places when listing table descriptors (apache#1115)" This reverts commit ab00399.
thangTang
pushed a commit
to thangTang/hbase
that referenced
this pull request
Apr 16, 2020
… places when listing table descriptors (apache#1115) Signed-off-by: Viraj Jasani <vjasani@apache.org>
thangTang
pushed a commit
to thangTang/hbase
that referenced
this pull request
Apr 16, 2020
… places when listing table descriptors (apache#1115) Signed-off-by: Viraj Jasani <vjasani@apache.org>
infraio
pushed a commit
to infraio/hbase
that referenced
this pull request
Aug 17, 2020
… places when listing table descriptors (apache#1115) Signed-off-by: Viraj Jasani <vjasani@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… places when listing table descriptors