Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HBASE-23740 Invalid StoreFile WARN log message printed for recovered.… #1198

Merged
merged 2 commits into from
Feb 26, 2020
Merged

HBASE-23740 Invalid StoreFile WARN log message printed for recovered.… #1198

merged 2 commits into from
Feb 26, 2020

Conversation

pankaj72981
Copy link
Contributor

Skipping the WARN log for the recovered.hfile dir.

@Apache-HBase

This comment has been minimized.

Sign in to view
virajjasani
virajjasani approved these changes Feb 23, 2020
View reviewed changes
Copy link
Contributor

@virajjasani virajjasani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, pending QA (latest run failed due to OutOfMemory error)

hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionFileSystem.java Outdated Show resolved Hide resolved
@Apache-HBase

This comment has been minimized.

Sign in to view
@Apache-HBase
Copy link

🎊 +1 overall

Vote Subsystem Runtime Comment
+0 🆗 reexec 1m 22s Docker mode activated.
_ Prechecks _
+1 💚 dupname 0m 0s No case conflicting files found.
+1 💚 hbaseanti 0m 0s Patch does not have any anti-patterns.
+1 💚 @author 0m 0s The patch does not contain any @author tags.
-0 ⚠️ test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ master Compile Tests _
+1 💚 mvninstall 6m 17s master passed
+1 💚 compile 1m 8s master passed
+1 💚 checkstyle 1m 21s master passed
+1 💚 shadedjars 5m 36s branch has no errors when building our shaded downstream artifacts.
+1 💚 javadoc 0m 40s master passed
+0 🆗 spotbugs 5m 22s Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚 findbugs 5m 19s master passed
_ Patch Compile Tests _
+1 💚 mvninstall 6m 0s the patch passed
+1 💚 compile 1m 4s the patch passed
+1 💚 javac 1m 4s the patch passed
+1 💚 checkstyle 1m 11s the patch passed
+1 💚 whitespace 0m 0s The patch has no whitespace issues.
+1 💚 shadedjars 5m 14s patch has no errors when building our shaded downstream artifacts.
+1 💚 hadoopcheck 18m 49s Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
+1 💚 javadoc 0m 36s the patch passed
+1 💚 findbugs 4m 48s the patch passed
_ Other Tests _
+1 💚 unit 98m 14s hbase-server in the patch passed.
+1 💚 asflicense 0m 27s The patch does not generate ASF License warnings.
165m 24s
Subsystem Report/Notes
Docker Client=19.03.6 Server=19.03.6 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1198/3/artifact/out/Dockerfile
GITHUB PR #1198
Optional Tests dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile
uname Linux e8fa8c207081 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 GNU/Linux
Build tool maven
Personality /home/jenkins/jenkins-slave/workspace/Base-PreCommit-GitHub-PR_PR-1198/out/precommit/personality/provided.sh
git revision master / 400b7ce
Default Java 1.8.0_181
Test Results https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1198/3/testReport/
Max. process+thread count 6222 (vs. ulimit of 10000)
modules C: hbase-server U: hbase-server
Console output https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1198/3/console
versions git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

@pankaj72981 pankaj72981 merged commit 3c3aae9 into apache:master Feb 26, 2020
@pankaj72981
Copy link
Contributor Author

Thanks everyone for the review.

asfgit pushed a commit that referenced this pull request Feb 26, 2020
@pankaj72981
HBASE-23740 Invalid StoreFile WARN log message printed for recovered.… (
8b7cdc9 
#1198)

* HBASE-23740 Invalid StoreFile WARN log message printed for recovered.hfiles directory

* HBASE-23740 Invalid StoreFile WARN log message printed for recovered.hfiles directory

(cherry picked from commit 3c3aae9)
thangTang pushed a commit to thangTang/hbase that referenced this pull request Apr 16, 2020
@pankaj72981 @thangTang
HBASE-23740 Invalid StoreFile WARN log message printed for recovered.… (
16dcb0d 
apache#1198)

* HBASE-23740 Invalid StoreFile WARN log message printed for recovered.hfiles directory

* HBASE-23740 Invalid StoreFile WARN log message printed for recovered.hfiles directory
thangTang pushed a commit to thangTang/hbase that referenced this pull request Apr 16, 2020
@pankaj72981 @thangTang
HBASE-23740 Invalid StoreFile WARN log message printed for recovered.… (
0102d29 
apache#1198)

* HBASE-23740 Invalid StoreFile WARN log message printed for recovered.hfiles directory

* HBASE-23740 Invalid StoreFile WARN log message printed for recovered.hfiles directory
infraio pushed a commit to infraio/hbase that referenced this pull request Aug 17, 2020
@pankaj72981 @infraio
HBASE-23740 Invalid StoreFile WARN log message printed for recovered.… (
0c78819 
apache#1198)

* HBASE-23740 Invalid StoreFile WARN log message printed for recovered.hfiles directory

* HBASE-23740 Invalid StoreFile WARN log message printed for recovered.hfiles directory

(cherry picked from commit 3c3aae9)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saintstack saintstack saintstack approved these changes

@petersomogyi petersomogyi petersomogyi approved these changes

@virajjasani virajjasani virajjasani approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@pankaj72981 @Apache-HBase @saintstack @petersomogyi @virajjasani