HBASE-23944 The method setClusterLoad of SimpleLoadBalancer is incorr… #1243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
infraio
reviewed
Mar 6, 2020
| @@ -402,13 +402,13 @@ protected void updateLoad(final Map<ServerName, ServerAndLoad> map, | |||
| return servers; | |||
| } | |||
|
|
|||
| protected HashMap<TableName, TreeMap<ServerName, List<RegionInfo>>> mockClusterServersWithTables(Map<ServerName, List<RegionInfo>> clusterServers) { | |||
| HashMap<TableName, TreeMap<ServerName, List<RegionInfo>>> result = new HashMap<>(); | |||
| protected Map<TableName, Map<ServerName, List<RegionInfo>>> mockClusterServersWithTables(Map<ServerName, List<RegionInfo>> clusterServers) { | |||
There was a problem hiding this comment.
use the return value of method mockClusterServersWithTables as clusterLoad
the extend feature of treeMap is no use , Map is enough
infraio
reviewed
Mar 6, 2020
| Map<TableName, Map<ServerName, List<RegionInfo>>> clusterLoad = new TreeMap<>(); | ||
| Map<ServerName, List<RegionInfo>> clusterServers = mockUniformClusterServers(mockUniformCluster); | ||
| List<ServerAndLoad> clusterList = convertToList(clusterServers); | ||
| clusterLoad.put(TableName.valueOf(name.getMethodName()), clusterServers); | ||
| // use overall can achieve both table and cluster level balance | ||
| HashMap<TableName, TreeMap<ServerName, List<RegionInfo>>> result1 = mockClusterServersWithTables(clusterServers); | ||
| loadBalancer.setClusterLoad(clusterLoad); | ||
| Map<TableName, Map<ServerName, List<RegionInfo>>> result1 = mockClusterServersWithTables(clusterServers); |
There was a problem hiding this comment.
The difference of results1 and clusterLoad is?
There was a problem hiding this comment.
clusterLoad's value is map (server to all region on it , whatever region's table), clusterLoad's key is no use
results1's value is map(server to region ,the region only belong to the key table), results1's key is actual tableName
in balance by table, we should use results1
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
…ect when balance by table
|
💔 -1 overall
This message was automatically generated. |
|
💔 -1 overall
This message was automatically generated. |
|
🎊 +1 overall
This message was automatically generated. |
asfgit
pushed a commit
that referenced
this pull request
Mar 7, 2020
…ect when balance by table (#1243) Signed-off-by: Guanghao Zhang <zghao@apache.org>
asfgit
pushed a commit
that referenced
this pull request
Mar 7, 2020
…ect when balance by table (#1243) Signed-off-by: Guanghao Zhang <zghao@apache.org>
asfgit
pushed a commit
that referenced
this pull request
Mar 7, 2020
…ect when balance by table (#1243) Signed-off-by: Guanghao Zhang <zghao@apache.org>
thangTang
pushed a commit
to thangTang/hbase
that referenced
this pull request
Apr 16, 2020
…ect when balance by table (apache#1243) Signed-off-by: Guanghao Zhang <zghao@apache.org>
thangTang
pushed a commit
to thangTang/hbase
that referenced
this pull request
Apr 16, 2020
…ect when balance by table (apache#1243) Signed-off-by: Guanghao Zhang <zghao@apache.org>
infraio
pushed a commit
to infraio/hbase
that referenced
this pull request
Aug 17, 2020
…ect when balance by table (apache#1243) Signed-off-by: Guanghao Zhang <zghao@apache.org>
symat
pushed a commit
to symat/hbase
that referenced
this pull request
Feb 17, 2021
…ect when balance by table (apache#1243) Signed-off-by: Guanghao Zhang <zghao@apache.org> (cherry picked from commit 6587a95) Change-Id: Icb9adfb5af4613e40c806fc8c07ab9fa78c7f5f1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ect when balance by table