HBASE-23561 acquire lock before update regionsMap #1263

mwkang · 2020-03-10T08:09:59Z

computeIfAbsent not guaranteed to be applied once atomically. therefore they can have a different value.
I should acquire a lock before update two maps.

Apache-HBase · 2020-03-10T09:23:57Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 35s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	8m 29s	master passed
+1 💚	checkstyle	1m 53s	master passed
+0 🆗	spotbugs	6m 48s	Used deprecated FindBugs config; considering switching to SpotBugs.
-1 ❌	findbugs	4m 42s	hbase-server in master failed.
		_ Patch Compile Tests _
+1 💚	mvninstall	7m 29s	the patch passed
+1 💚	checkstyle	1m 53s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	23m 54s	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
-1 ❌	findbugs	4m 37s	hbase-server in the patch failed.
		_ Other Tests _
+1 💚	asflicense	0m 19s	The patch does not generate ASF License warnings.
		63m 32s

Subsystem	Report/Notes
Docker	Client=19.03.7 Server=19.03.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1263/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#1263
Optional Tests	dupname asflicense spotbugs findbugs hadoopcheck hbaseanti checkstyle
uname	Linux 99097c7b7e87 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `31484f0`
findbugs	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1263/1/artifact/yetus-general-check/output/branch-findbugs-hbase-server.txt
findbugs	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1263/1/artifact/yetus-general-check/output/patch-findbugs-hbase-server.txt
Max. process+thread count	84 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1263/1/console
versions	git=2.17.1 maven=2018-06-17T18:33:14Z)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-03-10T10:05:07Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 5s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --findbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	5m 59s	master passed
+1 💚	compile	1m 2s	master passed
+1 💚	shadedjars	5m 21s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 39s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	5m 47s	the patch passed
+1 💚	compile	1m 0s	the patch passed
+1 💚	javac	1m 0s	the patch passed
+1 💚	shadedjars	5m 13s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 35s	the patch passed
		_ Other Tests _
+1 💚	unit	76m 28s	hbase-server in the patch passed.
		104m 51s

Subsystem	Report/Notes
Docker	Client=19.03.7 Server=19.03.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1263/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR	#1263
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux b5a4b970adc7 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `31484f0`
Default Java	1.8.0_232
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1263/1/testReport/
Max. process+thread count	5285 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1263/1/console
versions	git=2.17.1 maven=2018-06-17T18:33:14Z)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-03-10T10:26:50Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 6s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --findbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	7m 23s	master passed
+1 💚	compile	1m 17s	master passed
+1 💚	shadedjars	5m 36s	branch has no errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 44s	hbase-server in master failed.
		_ Patch Compile Tests _
+1 💚	mvninstall	8m 40s	the patch passed
+1 💚	compile	1m 39s	the patch passed
+1 💚	javac	1m 39s	the patch passed
+1 💚	shadedjars	6m 49s	patch has no errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 54s	hbase-server in the patch failed.
		_ Other Tests _
+1 💚	unit	90m 30s	hbase-server in the patch passed.
		126m 32s

Subsystem	Report/Notes
Docker	Client=19.03.7 Server=19.03.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1263/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#1263
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux cde5231a14d5 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `31484f0`
Default Java	2020-01-14
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1263/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1263/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1263/1/testReport/
Max. process+thread count	5560 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1263/1/console
versions	git=2.17.1 maven=2018-06-17T18:33:14Z)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

saintstack · 2020-03-10T18:23:31Z

What is going on here @mwkang ? This should be a new JIRA? You have attached this to HBASE-23561, an issue that is closed. Thanks.

saintstack · 2020-03-10T18:25:36Z

Is this issue related to HBASE-23561? It seems so. Its like an addendum? Maybe it belongs on HBASE-23561 then?

mwkang · 2020-03-11T03:44:23Z

@saintstack I'm sorry if I did something wrong.

I did patch HBASE-23561 but I added it because I thought it would be a problem later.
This patch belongs to HBASE-23561.

Note Link: #1193 (comment)

saintstack · 2020-03-11T23:57:51Z

Nothing wrong done. Was having trouble figuring this an addendum and not some new work. Thanks.

mwkang · 2020-03-12T00:54:43Z

thank you for your review and comment.

Addendum: tie add and delete of regionMap and encodedRegionsMap Signed-off-by: stack <stack@apache.org>

HBASE-23561 acquire lock before update regionsMap

87a287e

saintstack merged commit 6f1e8ab into apache:master Mar 11, 2020

thangTang pushed a commit to thangTang/hbase that referenced this pull request Apr 16, 2020

HBASE-23561 acquire lock before update regionsMap (apache#1263)

6e4eb6d

Addendum: tie add and delete of regionMap and encodedRegionsMap Signed-off-by: stack <stack@apache.org>

thangTang pushed a commit to thangTang/hbase that referenced this pull request Apr 16, 2020

HBASE-23561 acquire lock before update regionsMap (apache#1263)

9a0c71e

Addendum: tie add and delete of regionMap and encodedRegionsMap Signed-off-by: stack <stack@apache.org>

ndimiduk pushed a commit to ndimiduk/hbase that referenced this pull request Feb 21, 2023

HBASE-23561 acquire lock before update regionsMap (apache#1263)

468fb7c

Addendum: tie add and delete of regionMap and encodedRegionsMap Signed-off-by: stack <stack@apache.org>

ndimiduk pushed a commit to ndimiduk/hbase that referenced this pull request Feb 27, 2023

HBASE-23561 acquire lock before update regionsMap (apache#1263)

f78bf84

Addendum: tie add and delete of regionMap and encodedRegionsMap Signed-off-by: stack <stack@apache.org>

ndimiduk pushed a commit that referenced this pull request Mar 1, 2023

HBASE-23561 acquire lock before update regionsMap (#1263)

13e06c7

Addendum: tie add and delete of regionMap and encodedRegionsMap Signed-off-by: stack <stack@apache.org>

ndimiduk pushed a commit to ndimiduk/hbase that referenced this pull request Mar 1, 2023

HBASE-23561 acquire lock before update regionsMap (apache#1263)

20d3b88

Addendum: tie add and delete of regionMap and encodedRegionsMap Signed-off-by: stack <stack@apache.org>

ndimiduk pushed a commit that referenced this pull request Mar 3, 2023

HBASE-23561 acquire lock before update regionsMap (#1263)

cbfdbff

Addendum: tie add and delete of regionMap and encodedRegionsMap Signed-off-by: stack <stack@apache.org>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HBASE-23561 acquire lock before update regionsMap #1263

HBASE-23561 acquire lock before update regionsMap #1263

mwkang commented Mar 10, 2020

Apache-HBase commented Mar 10, 2020

Apache-HBase commented Mar 10, 2020

Apache-HBase commented Mar 10, 2020

saintstack commented Mar 10, 2020

saintstack commented Mar 10, 2020

mwkang commented Mar 11, 2020

saintstack commented Mar 11, 2020

mwkang commented Mar 12, 2020 •

edited

HBASE-23561 acquire lock before update regionsMap #1263

HBASE-23561 acquire lock before update regionsMap #1263

Conversation

mwkang commented Mar 10, 2020

Apache-HBase commented Mar 10, 2020

Apache-HBase commented Mar 10, 2020

Apache-HBase commented Mar 10, 2020

saintstack commented Mar 10, 2020

saintstack commented Mar 10, 2020

mwkang commented Mar 11, 2020

saintstack commented Mar 11, 2020

mwkang commented Mar 12, 2020 • edited

mwkang commented Mar 12, 2020 •

edited