HBASE-23954 SplitParent region should not be balanced #1264

nyl3532016 · 2020-03-10T09:28:04Z

No description provided.

Apache-HBase · 2020-03-10T10:14:24Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 31s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	5m 34s	master passed
+1 💚	checkstyle	1m 7s	master passed
+0 🆗	spotbugs	4m 48s	Used deprecated FindBugs config; considering switching to SpotBugs.
+1 💚	findbugs	4m 45s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	5m 1s	the patch passed
+1 💚	checkstyle	1m 6s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	15m 58s	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
-1 ❌	findbugs	3m 0s	hbase-server in the patch failed.
		_ Other Tests _
+1 💚	asflicense	0m 15s	The patch does not generate ASF License warnings.
		44m 1s

Subsystem	Report/Notes
Docker	Client=19.03.7 Server=19.03.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1264/1/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#1264
Optional Tests	dupname asflicense spotbugs findbugs hadoopcheck hbaseanti checkstyle
uname	Linux 56e02120553d 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `31484f0`
findbugs	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1264/1/artifact/yetus-general-check/output/patch-findbugs-hbase-server.txt
Max. process+thread count	93 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1264/1/console
versions	git=2.17.1 maven=2018-06-17T18:33:14Z) findbugs=3.1.11
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

infraio · 2020-03-10T10:30:50Z

hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/RegionStates.java

-            .collect(Collectors.toList()));
+          ensemble.put(serverNode.getServerName(),
+            serverNode.getRegionInfoList().stream()
+                .filter(region -> !isTableDisabled(tableStateManager, region.getTable())


filter twice is easy to read?
.filter(region -> !isTableDisabled(tableStateManager, region.getTable()).filter(region -> !region.isSplitParent())

Apache-HBase · 2020-03-10T11:09:56Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 30s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --findbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	6m 36s	master passed
+1 💚	compile	1m 7s	master passed
+1 💚	shadedjars	5m 1s	branch has no errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 41s	hbase-server in master failed.
		_ Patch Compile Tests _
+1 💚	mvninstall	6m 5s	the patch passed
+1 💚	compile	1m 4s	the patch passed
+1 💚	javac	1m 4s	the patch passed
+1 💚	shadedjars	4m 53s	patch has no errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	0m 39s	hbase-server in the patch failed.
		_ Other Tests _
-0 ⚠️	unit	70m 38s	hbase-server in the patch failed.
		99m 33s

Subsystem	Report/Notes
Docker	Client=19.03.7 Server=19.03.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1264/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#1264
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux b2ecc15ec268 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `31484f0`
Default Java	2020-01-14
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1264/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1264/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1264/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1264/1/testReport/
Max. process+thread count	9179 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1264/1/console
versions	git=2.17.1 maven=2018-06-17T18:33:14Z)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-03-10T11:35:07Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	0m 32s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --findbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	6m 17s	master passed
+1 💚	compile	1m 0s	master passed
+1 💚	shadedjars	5m 9s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 36s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	5m 34s	the patch passed
+1 💚	compile	1m 2s	the patch passed
+1 💚	javac	1m 2s	the patch passed
+1 💚	shadedjars	5m 7s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 35s	the patch passed
		_ Other Tests _
+1 💚	unit	96m 54s	hbase-server in the patch passed.
		124m 37s

Subsystem	Report/Notes
Docker	Client=19.03.7 Server=19.03.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1264/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR	#1264
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 3d7307a2aa2f 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `31484f0`
Default Java	1.8.0_232
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1264/1/testReport/
Max. process+thread count	7055 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1264/1/console
versions	git=2.17.1 maven=2018-06-17T18:33:14Z)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-03-10T12:32:52Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 37s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	hbaseanti	0m 0s	Patch does not have any anti-patterns.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
		_ master Compile Tests _
+1 💚	mvninstall	6m 18s	master passed
+1 💚	checkstyle	1m 18s	master passed
+0 🆗	spotbugs	4m 57s	Used deprecated FindBugs config; considering switching to SpotBugs.
-1 ❌	findbugs	3m 28s	hbase-server in master failed.
		_ Patch Compile Tests _
+1 💚	mvninstall	5m 48s	the patch passed
+1 💚	checkstyle	1m 15s	the patch passed
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	hadoopcheck	21m 37s	Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2.
-1 ❌	findbugs	4m 30s	hbase-server in the patch failed.
		_ Other Tests _
+1 💚	asflicense	0m 21s	The patch does not generate ASF License warnings.
		55m 41s

Subsystem	Report/Notes
Docker	Client=19.03.7 Server=19.03.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1264/2/artifact/yetus-general-check/output/Dockerfile
GITHUB PR	#1264
Optional Tests	dupname asflicense spotbugs findbugs hadoopcheck hbaseanti checkstyle
uname	Linux feb166d26ff3 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `31484f0`
findbugs	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1264/2/artifact/yetus-general-check/output/branch-findbugs-hbase-server.txt
findbugs	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1264/2/artifact/yetus-general-check/output/patch-findbugs-hbase-server.txt
Max. process+thread count	84 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1264/2/console
versions	git=2.17.1 maven=2018-06-17T18:33:14Z)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-03-10T13:45:49Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 37s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --findbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	6m 15s	master passed
+1 💚	compile	1m 3s	master passed
+1 💚	shadedjars	5m 34s	branch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 39s	master passed
		_ Patch Compile Tests _
+1 💚	mvninstall	5m 46s	the patch passed
+1 💚	compile	1m 4s	the patch passed
+1 💚	javac	1m 4s	the patch passed
+1 💚	shadedjars	5m 16s	patch has no errors when building our shaded downstream artifacts.
+1 💚	javadoc	0m 37s	the patch passed
		_ Other Tests _
+1 💚	unit	98m 58s	hbase-server in the patch passed.
		128m 37s

Subsystem	Report/Notes
Docker	Client=19.03.7 Server=19.03.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1264/2/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile
GITHUB PR	#1264
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 84fbf37c76b4 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `31484f0`
Default Java	1.8.0_232
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1264/2/testReport/
Max. process+thread count	7236 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1264/2/console
versions	git=2.17.1 maven=2018-06-17T18:33:14Z)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

Apache-HBase · 2020-03-10T14:26:50Z

🎊 +1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	2m 13s	Docker mode activated.
-0 ⚠️	yetus	0m 3s	Unprocessed flag(s): --brief-report-file --findbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck
		_ Prechecks _
		_ master Compile Tests _
+1 💚	mvninstall	10m 58s	master passed
+1 💚	compile	1m 51s	master passed
+1 💚	shadedjars	8m 20s	branch has no errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	1m 11s	hbase-server in master failed.
		_ Patch Compile Tests _
+1 💚	mvninstall	9m 51s	the patch passed
+1 💚	compile	1m 56s	the patch passed
+1 💚	javac	1m 56s	the patch passed
+1 💚	shadedjars	8m 21s	patch has no errors when building our shaded downstream artifacts.
-0 ⚠️	javadoc	1m 8s	hbase-server in the patch failed.
		_ Other Tests _
-0 ⚠️	unit	121m 31s	hbase-server in the patch failed.
		169m 33s

Subsystem	Report/Notes
Docker	Client=19.03.7 Server=19.03.7 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1264/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile
GITHUB PR	#1264
Optional Tests	javac javadoc unit shadedjars compile
uname	Linux 392d4d07c965 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/hbase-personality.sh
git revision	master / `31484f0`
Default Java	2020-01-14
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1264/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt
javadoc	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1264/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt
unit	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1264/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt
Test Results	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1264/2/testReport/
Max. process+thread count	6817 (vs. ulimit of 10000)
modules	C: hbase-server U: hbase-server
Console output	https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1264/2/console
versions	git=2.17.1 maven=2018-06-17T18:33:14Z)
Powered by	Apache Yetus 0.11.1 https://yetus.apache.org

This message was automatically generated.

virajjasani

+1

Co-authored-by: niuyulin <niuyulin@xiaomi.com> Signed-off-by: Viraj Jasani <vjasani@apache.org> Signed-off-by: Guanghao Zhang <zghao@apache.org> Signed-off-by: stack <stack@apache.org>

Co-authored-by: niuyulin <niuyulin@xiaomi.com> Signed-off-by: Viraj Jasani <vjasani@apache.org> Signed-off-by: Guanghao Zhang <zghao@apache.org> Signed-off-by: stack <stack@apache.org> (cherry picked from commit 9949204) Change-Id: Id5f920d25d44775c3659a2e8d1b49c5f6b4d2592

infraio reviewed Mar 10, 2020

View reviewed changes

HBASE-23954 SplitParent region should not be balanced

572db61

nyl3532016 force-pushed the branch2 branch from 4d6b4a0 to 572db61 Compare March 10, 2020 10:44

virajjasani approved these changes Mar 10, 2020

View reviewed changes

saintstack approved these changes Mar 10, 2020

View reviewed changes

saintstack merged commit 6e6b241 into apache:master Mar 10, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HBASE-23954 SplitParent region should not be balanced #1264

HBASE-23954 SplitParent region should not be balanced #1264

nyl3532016 commented Mar 10, 2020

Apache-HBase commented Mar 10, 2020

infraio Mar 10, 2020

nyl3532016 Mar 10, 2020

Apache-HBase commented Mar 10, 2020

Apache-HBase commented Mar 10, 2020

Apache-HBase commented Mar 10, 2020

Apache-HBase commented Mar 10, 2020

Apache-HBase commented Mar 10, 2020

virajjasani left a comment

HBASE-23954 SplitParent region should not be balanced #1264

HBASE-23954 SplitParent region should not be balanced #1264

Conversation

nyl3532016 commented Mar 10, 2020

Apache-HBase commented Mar 10, 2020

infraio Mar 10, 2020

Choose a reason for hiding this comment

nyl3532016 Mar 10, 2020

Choose a reason for hiding this comment

Apache-HBase commented Mar 10, 2020

Apache-HBase commented Mar 10, 2020

Apache-HBase commented Mar 10, 2020

Apache-HBase commented Mar 10, 2020

Apache-HBase commented Mar 10, 2020

virajjasani left a comment

Choose a reason for hiding this comment